Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp4671234pxy; Tue, 27 Apr 2021 10:01:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyPTMeKNj227/Z3DsHfSXmLmNIXsZ0DRsxAWAhBADVS2v3EY6OoraskAC8xTUWR23qTAfEG X-Received: by 2002:a63:1a47:: with SMTP id a7mr22668341pgm.437.1619542862401; Tue, 27 Apr 2021 10:01:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619542862; cv=none; d=google.com; s=arc-20160816; b=paE3Tw2gSflxqjxr8JjQoN2eOes1b8tz3V3OwXOpplR053K+vnc/8iY+QNVQfJcQP5 6mSb0VB7zNVu1HPKlrbAUrc+IZRliQ+JD/R9dj3KBZ8vGw4GVtzoIlNYOmUdu//B5Iyr z480A9BOJ7PIUVprMB/jP6OSw6+7IIlUVzUpGEfXGoCqsn2GICub6i/EsB5ITulVX+e5 EvypBGvXUHKbLoUKVil9FNwtmQy0cTYYIURkKZnIN1uHns2YWyQTvirYYXaOwrttNa3f yXCU1w/94A6CGCFg57r40xnUas5kwSwk003+sBt3kFltILaKsCmknKTJ/c1lqxodUCQ4 LHFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=sDXerW9GdK+XwbZDIQ63ZPCDfH88wYtwrkEeDj8MkUg=; b=ladRLsyLh58bJ7v3G+3UoTEqz8t+2SgIfHMyG0dG5kOM0/baMWM68QPMX6+WsCtmFO wltCv7VbdLVBJSNri9sfMfosu5Ged8+yfjfZcmBGyOcqKUjsNmSPyJLXh672ykbJWTAU AzYKqkBJZELXSdbU0yO37oiZlH9IJH1ZuDBeY0OdwYCUCaYr3Qkn46icxJ6IIYRgk3Aq 5dLTwj24iPQPP9dK3hlr8X5VlFRXOwlchbVdgXK9gnAJLo/PZvj5C2IDc0jsZ5bdvbZm XtyDM5zbfQcDLGCva43rnER/iu0qWT4obaonqk7b06BZLzJWojyguws7pclFgqFwO1qA 4i5g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=srib0Xb1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e124si458388pgc.395.2021.04.27.10.00.50; Tue, 27 Apr 2021 10:01:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=srib0Xb1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237920AbhD0RAw (ORCPT + 99 others); Tue, 27 Apr 2021 13:00:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:46282 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236647AbhD0RAs (ORCPT ); Tue, 27 Apr 2021 13:00:48 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 514AA61165; Tue, 27 Apr 2021 17:00:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1619542803; bh=uW/820nOgA6vr/HbEDoEb84/ezgMtg3O0P9vdlhKkXk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=srib0Xb1p++VfBaEj1wsBcW69R8klwQXc3wpZtTIfgtnNqPUKoBYKxZ/U9KlgZXL5 Bbn4jaAmbz5fZuelqjjfEmZYxREe3UOpNS7cWHWJkpSmUWLOTay+QMpzEL9jGO5WG+ r+rJ61ueo4KNbijKFxnBHZRerMU6QCviZ1GILtSM= Date: Tue, 27 Apr 2021 19:00:01 +0200 From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Aditya Pakki , "David S . Miller" Subject: Re: [PATCH 175/190] Revert "ipv6/route: Add a missing check on proc_dointvec" Message-ID: References: <20210421130105.1226686-1-gregkh@linuxfoundation.org> <20210421130105.1226686-176-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210421130105.1226686-176-gregkh@linuxfoundation.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 21, 2021 at 03:00:50PM +0200, Greg Kroah-Hartman wrote: > This reverts commit f0fb9b288d0a7e9cc324ae362e2dfd2cc2217ded. > > Commits from @umn.edu addresses have been found to be submitted in "bad > faith" to try to test the kernel community's ability to review "known > malicious" changes. The result of these submissions can be found in a > paper published at the 42nd IEEE Symposium on Security and Privacy > entitled, "Open Source Insecurity: Stealthily Introducing > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University > of Minnesota) and Kangjie Lu (University of Minnesota). > > Because of this, all submissions from this group must be reverted from > the kernel tree and will need to be re-reviewed again to determine if > they actually are a valid fix. Until that work is complete, remove this > change to ensure that no problems are being introduced into the > codebase. > > Cc: Aditya Pakki > Cc: David S. Miller > Signed-off-by: Greg Kroah-Hartman > --- > net/ipv6/route.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/net/ipv6/route.c b/net/ipv6/route.c > index 373d48073106..0e85741423d7 100644 > --- a/net/ipv6/route.c > +++ b/net/ipv6/route.c > @@ -6169,16 +6169,12 @@ static int ipv6_sysctl_rtcache_flush(struct ctl_table *ctl, int write, > { > struct net *net; > int delay; > - int ret; > if (!write) > return -EINVAL; > > net = (struct net *)ctl->extra1; > delay = net->ipv6.sysctl.flush_delay; > - ret = proc_dointvec(ctl, write, buffer, lenp, ppos); > - if (ret) > - return ret; > - > + proc_dointvec(ctl, write, buffer, lenp, ppos); > fib6_run_gc(delay <= 0 ? 0 : (unsigned long)delay, net, delay > 0); > return 0; > } > -- > 2.31.1 > Original looks correct, dropping this revert. greg k-h