Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210427174719.GA14124@ubuntu>
In-Reply-To: <20210427174719.GA14124@ubuntu>
From:   Sergio Paracuellos <sergio.paracuellos@gmail.com>
Date:   Tue, 27 Apr 2021 19:55:30 +0200
Message-ID: <CAMhs-H_jfdTV4JYD+_Xy+1w452AjjAut-jjFhEt+GmLjTw8+8A@mail.gmail.com>
Subject: Re: [PATCH] staging: mt7621-pci: fix a multiple assignment code style issue
To:     Iain Craig <coldcity@gmail.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        linux-staging@lists.linux.dev,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Iain.

On Tue, Apr 27, 2021 at 7:47 PM Iain Craig <coldcity@gmail.com> wrote:
>
> avoid multiple assignments while setting pcie->io members to NULL.
>
> Signed-off-by: Iain Craig <coldcity@gmail.com>
> ---
>  drivers/staging/mt7621-pci/pci-mt7621.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/mt7621-pci/pci-mt7621.c b/drivers/staging/mt7621-pci/pci-mt7621.c
> index 115250115f10..f3b5b8ac03b5 100644
> --- a/drivers/staging/mt7621-pci/pci-mt7621.c
> +++ b/drivers/staging/mt7621-pci/pci-mt7621.c
> @@ -306,7 +306,9 @@ static int mt7621_pci_parse_request_of_pci_ranges(struct pci_host_bridge *host)
>          * resource manually instead.
>          */
>         pcie->io.name = node->full_name;
> -       pcie->io.parent = pcie->io.child = pcie->io.sibling = NULL;
> +       pcie->io.parent = NULL;
> +       pcie->io.child = NULL;
> +       pcie->io.sibling = NULL;

In this particular case I think the original code is correct as it is.
Also this is the style used around different kernel places to assign
these fields.

>         for_each_of_pci_range(&parser, &range) {
>                 switch (range.flags & IORESOURCE_TYPE_BITS) {
>                 case IORESOURCE_IO:
> --
> 2.25.1
>

Best regards,
    Sergio Paracuellos

>