Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp4729278pxy; Tue, 27 Apr 2021 11:14:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz7k4z9p5nwIdd271oIrbIj+W/tIumchHj9JcqEy0uq8DBdFOa8nTVwYx0zTgiAa3wQ/99E X-Received: by 2002:a17:907:e87:: with SMTP id ho7mr24235306ejc.2.1619547256071; Tue, 27 Apr 2021 11:14:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619547256; cv=none; d=google.com; s=arc-20160816; b=Ku8JLWdsliZjj7chYl7UxUiR29vl8h8VUiBk5ZeEnlxBgPS+N++/gK53O2aT3s1o38 TaABRZD8Af7DqKc3fwAKYH90gfkhwQ5iLcbNeazNynBkhNTz+47CUUNOWLma5ThbYIa0 PnyoKSTfVJ9wmlyOvW9u0sEqasyiBUA9Rx3KhKeKtNeE+1Ist/jPVeMvAozbVoBjrZoN 0LuuNQVLaF2+o0G9ZR79lodSZFBU2uEtxtCZfWpVxeeRm+J5FxWCinYFXSL9rUQgWSu9 PR4aT8Xr2XXS3u8tMloMTJxPCfg4K7OIClWE6PuxQqJZ9HGbvWbA5Qw+fx27VeWNXlic htRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=+YFKMrSVYWbw53F0xe26aT+DB5zde3Wnx8o9zi/ubl4=; b=hJzrZtrBRgNQF3G7ppFLi6CneK92w8VhiJdEKJ1XOFO6Gvcg3fAc82B7R8STfLHRYb 9DB9FgKqX99k06CJksfrPxuzyPWgTAFqO9vEdEi13BZiPqA9i7g8/6iY1p5X8O08Ffk4 In/CNHVJCMrh3kChXD87B49LK8arRl/V80zODjZQ1EZLgdf/XSvM+viTFzYmTeZagQB9 pUCdmcnxfbEEcW/hDX24V2WYZHX+BJ4ctBBqj5xQjk7SGR4wPBsKgrtZj/6zU4I85QTF zFuMfedlbGitks1Od+2QfAgvRIu6LuTvycCX3YgYDMnWYBvLkCKZIFik4b2vLoNjVBqz yNpQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=qUwaSyxP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w13si3111557edx.373.2021.04.27.11.13.52; Tue, 27 Apr 2021 11:14:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=qUwaSyxP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236776AbhD0SLH (ORCPT + 99 others); Tue, 27 Apr 2021 14:11:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:37596 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235505AbhD0SLG (ORCPT ); Tue, 27 Apr 2021 14:11:06 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 535C360BBB; Tue, 27 Apr 2021 18:10:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1619547022; bh=hMNih56Z7Me63IH021Heuif5NMjLNzLrXKN9bgT0KrQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qUwaSyxP3IEJLA0PXt00vgdVzEcxZZtxTM52qfHq2bNIPloTjmemV6IxceFsud7kt fdkFp3kTaxSfLl8WaqP7AMLbWLRF1VJ7DROBs8JN0zrIbB8ug0+0QULrqQSb55ynEj VBojc0fhMMdbXyIwEC37OwYoWSdE0Gc3PR99CEQ0= Date: Tue, 27 Apr 2021 20:10:20 +0200 From: Greg KH To: Jitendra Khasdev Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8192e: fix array of flexible structures Message-ID: References: <20210427174945.1323-1-jkhasdev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210427174945.1323-1-jkhasdev@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 27, 2021 at 11:19:45PM +0530, Jitendra Khasdev wrote: > This patch fixes sparse warning "array of flexible structures" > for rtllib.h. > > eg. drivers/staging/rtl8192e/rtllib.h:832:48: warning: array of > flexible structures > > Signed-off-by: Jitendra Khasdev > --- > drivers/staging/rtl8192e/rtllib.h | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h > index 4cabaf2..c7cb318 100644 > --- a/drivers/staging/rtl8192e/rtllib.h > +++ b/drivers/staging/rtl8192e/rtllib.h > @@ -802,7 +802,7 @@ struct rtllib_authentication { > __le16 transaction; > __le16 status; > /*challenge*/ > - struct rtllib_info_element info_element[]; > + struct rtllib_info_element *info_element; You just changed the definition of this structure, and the other structures here. Are you sure this is working properly? thanks, greg k-h