Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp4747066pxy; Tue, 27 Apr 2021 11:38:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxYU8Qr3XZKEk8ED15itI50rmv3gPXhQGfxEyg96MQit7QGGxFKZ3S3saTotUyEzQaazi1u X-Received: by 2002:a17:906:b104:: with SMTP id u4mr24717891ejy.211.1619548686446; Tue, 27 Apr 2021 11:38:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619548686; cv=none; d=google.com; s=arc-20160816; b=ZqaAyOi8jZFkyPkEeSbO+coPV7u/mvzBs2xR9AHvKiczFc1eNVX84+WD07XnCswVIl m4M/zhrgAKYJn5/SPBFPXBqPbXdrfNCYczDvglLktN9egMQCMUdvz2hjccMGTqQm7ciA 0BIzQK2ma/awOzqIJ/gxWy8mnYM9V+g4QonVzY0cTjEz85NX43AMhv4Hi2Jqa1oo754p mwZ0ZIRbDaLpsWcHsCn/auooJP5rL5Ciptx0duqxhpILx9oM72Ah9+d4izwGCPP6Wb8N RZrURngftEg/X40T4cnFFR5UsNIEWefdZ/JV3nWuJWasD1DbFH9Cnd6p6OuMukdXrimn uYyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=A5xmzT0WzJDDHOkvVRV5AjYHf40HsChk8Njw4hrRnLE=; b=jLDLSCzq1tlvnP8PFFa1XNhcV9HzY+kTcpqaly3UDueB35laHevziVc+tKcCmMN+HK KV/l1hK4Cw1e2vygw6vHGcJd7qFDQGkQkGol2u7QMwhzWYPtkSe6DLp/PRMLBrbEMhEF eqY9NS4YapXzyqRWKl9u+gKoSFJpxT87mnDa7Am+YX27nawSsc0WD6N8H+5ZUAYBpcHP V3xCiw5eKV7fJqxJZmUp3puaARZMZZCAiO5OLzzaalLvHUm/25exJLKKI0UeFxIox/1o evfXmNOIXuOtLELxGJvFk4BFlaOJeqj5iEOdYJ3xk9JfXTGUizXAOEYQu7zQmvbMmKtD zSMw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@googlemail.com header.s=20161025 header.b=L+krghGI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=googlemail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r8si617939ejr.135.2021.04.27.11.37.42; Tue, 27 Apr 2021 11:38:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@googlemail.com header.s=20161025 header.b=L+krghGI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=googlemail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236962AbhD0SfE (ORCPT + 99 others); Tue, 27 Apr 2021 14:35:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236651AbhD0SfE (ORCPT ); Tue, 27 Apr 2021 14:35:04 -0400 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24648C061574; Tue, 27 Apr 2021 11:34:20 -0700 (PDT) Received: by mail-ed1-x529.google.com with SMTP id z5so34657382edr.11; Tue, 27 Apr 2021 11:34:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=A5xmzT0WzJDDHOkvVRV5AjYHf40HsChk8Njw4hrRnLE=; b=L+krghGInoAmAnhlwYLKrfeFLlhwJ2XNz0eMB+qbGVam0e4IpcRGvwGWsHILy9BoAe 42hxvV5AIwoqswQWVws33bu3lrb4G/EDzaZeH9Sjpjg86KnllVdZcHwosnY83WwEHMaa OQ6k/0rSO7ICThQ1eC1GyQHyozbfpeDFMCgtG3Rz9v2ANWoxAMY3KgGJWhGhh3A+2hy9 3cb6L2DJepCN+gJBuwOklGTQM8PMxvEpohYPHaKyCs8G2QHeSn+Sy9ZXdTjyntMX4ssQ LG+UPm/oCsOhPGbDi7reSDUpXvky+bVr7lMW0vdJpYpY3snEzuxHtMQ3bEWjhm8dIikb xoMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=A5xmzT0WzJDDHOkvVRV5AjYHf40HsChk8Njw4hrRnLE=; b=APtnIM+K0PGf6otVjolrpQEcgOVQBlJW1AUzKgyvLqvRUsUPFojjkm1NkmJdNRyNl5 yU/fnWcTs8ABFL35Unw4oiOVUo2x3GviDqQCLvGCG3b0f1LZHOoTcQow1+ceVTqw80oT lBxzLowmcCFKgUnlh07wGeMDnwdJXExFur+fMuhakK3ZjQISgHVUnHTlDliyU3awW84E PEgkjnTz0jXuVCdN6s04GD/P6vPq8oKBzN6p78VIzhUp1D2VdROzhLPWHvJNrUFqRUkp IdquXgrhbbIDVfdQzzY7oIG5uJ8mnIoA2L5QyTj89rH0tO89IKre6gBypxASfRqvfQkr yuEw== X-Gm-Message-State: AOAM533POqc5CWKNxqbPreFuDQ54yasgIQFN1lpRxm1rBxBF1iDU0gDK KeXranbT3UaT0BrIQ1UNl1N3B//bntHprJhi92XWAdMxc8Q= X-Received: by 2002:a50:bb27:: with SMTP id y36mr6183368ede.365.1619548458935; Tue, 27 Apr 2021 11:34:18 -0700 (PDT) MIME-Version: 1.0 References: <20210426175559.3110575-1-narmstrong@baylibre.com> In-Reply-To: <20210426175559.3110575-1-narmstrong@baylibre.com> From: Martin Blumenstingl Date: Tue, 27 Apr 2021 20:34:08 +0200 Message-ID: Subject: Re: [PATCH 1/2] mmc: meson-gx: make replace WARN_ONCE with dev_warn_once about scatterlist offset alignment To: Neil Armstrong Cc: ulf.hansson@linaro.org, khilman@baylibre.com, linux-mmc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Christian Hewitt Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Neil, On Mon, Apr 26, 2021 at 7:58 PM Neil Armstrong wrote: > > Some drivers like ath10k can sometimg give an sg buffer with an offset whose alignment sometimg -> sometimes > is not compatible with the Amlogic DMA descriptor engine requirements. > > Simply replace with dev_warn_once() to inform user this should be fixed to avoid > degraded performance. > > This should be ultimately fixed in ath10k, but since it's only a performance issue > the warning should be removed. > > Fixes: 79ed05e329c3 ("mmc: meson-gx: add support for descriptor chain mode") > Reported-by: Christian Hewitt > Signed-off-by: Neil Armstrong Acked-by: Martin Blumenstingl