Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 162/190] Revert "dmaengine: qcom_hidma: Check for driver
 register failure"
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org
Cc:     Aditya Pakki <pakki001@umn.edu>, Vinod Koul <vkoul@kernel.org>
References: <20210421130105.1226686-1-gregkh@linuxfoundation.org>
 <20210421130105.1226686-163-gregkh@linuxfoundation.org>
 <YIgkAw8UVh4F6tQB@kroah.com>
From:   Sinan Kaya <okaya@kernel.org>
Message-ID: <811891cb-8749-152d-84ff-ed925e278f0f@kernel.org>
Date:   Tue, 27 Apr 2021 15:03:28 -0400
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.0
MIME-Version: 1.0
In-Reply-To: <YIgkAw8UVh4F6tQB@kroah.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 4/27/2021 10:47 AM, Greg Kroah-Hartman wrote:
> The original change is NOT correct, as it does not correctly unwind from
> the resources that was allocated before the call to
> platform_driver_register().
> 
> As platform_driver_register() should never really fail here, I'll just
> revert this patch and maybe someone, if they care about this driver, can
> unwind the mess here.  Given that this driver doesn't look to ever be
> able to be unloaded from the system, failing the init call does not look
> to be a wise idea.

Please go ahead. I was out-of-office for the last few days.