Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp4850942pxy; Tue, 27 Apr 2021 14:14:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxsHjDJBNeeziwtOXXMiehz54N8qjaxCK9W4/1Fo6/ZjeJ95wVy97oa5/eE02/R4JD08AG0 X-Received: by 2002:a17:902:eb54:b029:ed:19ae:bb17 with SMTP id i20-20020a170902eb54b02900ed19aebb17mr15711621pli.61.1619558058428; Tue, 27 Apr 2021 14:14:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619558058; cv=none; d=google.com; s=arc-20160816; b=tFmIuocCUJzVvoFlGaqJ1qNu5poyQG9Lihm+aeZzwsKd91s8lpvlB34f8OoGhUmVnL 9L562aSl4SS3fBVND0Ij2r4HAstbn1UfaumUw4Hd8RiojpggMi4sZvULbNaqM53KOHCb atMkKQ/JZkiRkMJc1Rqt95tf46+QFIpi54c5SvrftuPOiqRQelS3AEXyFrYYCoYFvexR A7o78NeUdrI4B+QWACkoyZ62qOOLqDJM+eto4HlT1k/nCyODBR+2+GrNuLVE3C6W3TMT CZ4GYIUQqF+vmg0YNAcOrkGYWSM2WPoUHc9oGQam4l/fzuECDdOM4RgDPpG72Ka6zQa+ ehKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=6JNlMvFIiVoN2VENt03vW1c+HyOcBXKzBziEI2mmaxM=; b=EaDlc4noo5j929F+7576VfSql5yLEQ7Pe04BtnvhwQcSNMmCiQJLldYDnXtMC4BDO6 CDsWX4Z2dyESJI6gEPO69iWKdy0cSDP/sIAnpYzz7q/8szBDuYG8F0qfjtLm91xmewTN kZxcEi68VlkucLiMyAMdf+G9BNcVBhQTZn5DO+PWcr3SkpUE4pTUgxUcgxbSH4aqHk/B gwpWsRJNyRfO78sssW6BEhHi0+DASFh7wTlQeoCmjY8VBDh/RjQ+6jzxm7QQdwW49gTk naIg9Hn/r8Kn3bhl6aoOt6ItYXFX7S3rURzaz6UU9K1YW7nC+T9gYtrhtL+CKt8fPUBU 07TQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=mCbeWSwB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o3si1087546pgm.369.2021.04.27.14.14.00; Tue, 27 Apr 2021 14:14:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=mCbeWSwB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239306AbhD0VLD (ORCPT + 99 others); Tue, 27 Apr 2021 17:11:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:38836 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239047AbhD0VKx (ORCPT ); Tue, 27 Apr 2021 17:10:53 -0400 Received: by mail.kernel.org (Postfix) with ESMTPS id 0BD5561401; Tue, 27 Apr 2021 21:10:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619557810; bh=d82NCV/TH6w3zyVp8P1oiizsMEP4o+OYdZ9mR7Wfo5I=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=mCbeWSwBNUsnYosJdQ2ylI1FWCJsDPpTG8g8xkt/HbfRF8hNTgM5RplLsPpaHYrAd 8/qFHBkF1UYvU88j3KMnGWUN0MtV5jHkvAQpOrRa0XB5ddO8CmQ+rn8zNOgid1cSEG ikCVoWqFC/zCE21K4FbsvLnKjKPLgyXIDIZeAJi9QongI+YXNzVW3V58KWpPEYyu/W oSU2G3nsK3uRJvr/qdQBBWcTj+u94JhMVmaxFgOiXRSbeH1D2GYwdUsccRovPEEcL4 11+ohBu/6yvBNVOFMOQaiq/48VTCmUJrBCleiPInAKn7WjHzDS+Gai8bKjyRs0LEbn Tl7tYTHhqRuPw== Received: from pdx-korg-docbuild-2.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by pdx-korg-docbuild-2.ci.codeaurora.org (Postfix) with ESMTP id 02FA960A36; Tue, 27 Apr 2021 21:10:10 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH net] net: bridge: mcast: fix broken length + header check for MRDv6 Adv. From: patchwork-bot+netdevbpf@kernel.org Message-Id: <161955781000.15707.777989471738202707.git-patchwork-notify@kernel.org> Date: Tue, 27 Apr 2021 21:10:10 +0000 References: <20210425152736.8421-1-linus.luessing@c0d3.blue> In-Reply-To: <20210425152736.8421-1-linus.luessing@c0d3.blue> To: =?utf-8?q?Linus_L=C3=BCssing_=3Clinus=2Eluessing=40c0d3=2Eblue=3E?=@ci.codeaurora.org Cc: netdev@vger.kernel.org, roopa@nvidia.com, nikolay@nvidia.com, kuba@kernel.org, davem@davemloft.net, bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sun, 25 Apr 2021 17:27:35 +0200 you wrote: > The IPv6 Multicast Router Advertisements parsing has the following two > issues: > > For one thing, ICMPv6 MRD Advertisements are smaller than ICMPv6 MLD > messages (ICMPv6 MRD Adv.: 8 bytes vs. ICMPv6 MLDv1/2: >= 24 bytes, > assuming MLDv2 Reports with at least one multicast address entry). > When ipv6_mc_check_mld_msg() tries to parse an Multicast Router > Advertisement its MLD length check will fail - and it will wrongly > return -EINVAL, even if we have a valid MRD Advertisement. With the > returned -EINVAL the bridge code will assume a broken packet and will > wrongly discard it, potentially leading to multicast packet loss towards > multicast routers. > > [...] Here is the summary with links: - [net] net: bridge: mcast: fix broken length + header check for MRDv6 Adv. https://git.kernel.org/netdev/net-next/c/99014088156c You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html