Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <bug-212379-6385@https.bugzilla.kernel.org/> <bug-212379-6385-VMOjMpWM97@https.bugzilla.kernel.org/>
 <YIc40YXZh4plkhnc@zn.tnic> <CAHp75VfYKcYjiafFRmb8nBLeJ3VOs0wu6OxhysE31UStQNroiw@mail.gmail.com>
 <CAHp75VfMfghCWo_47FhtUGU_qt+Jzaz1kqY4+=oZgbzazyfPUA@mail.gmail.com>
In-Reply-To: <CAHp75VfMfghCWo_47FhtUGU_qt+Jzaz1kqY4+=oZgbzazyfPUA@mail.gmail.com>
From:   Daniel Drake <drake@endlessos.org>
Date:   Wed, 28 Apr 2021 07:42:03 +0800
Message-ID: <CAD8Lp45xrqsbq4X_8EkSh_TVd0B-BMeq=xOunq1P=SizyK5ugw@mail.gmail.com>
Subject: Re: [Bug 212379] AMD GPIO chip IRQs stops working (ELN4690, WCOM51C7, BMA250E)
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Borislav Petkov <bp@alien8.de>, Coiby Xu <coiby.xu@gmail.com>,
        Ken Xue <Ken.Xue@amd.com>,
        Nehal Shah <Nehal-bakulchandra.Shah@amd.com>,
        Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
        vectorflaredesigns@gmail.com,
        Linus Walleij <linus.walleij@linaro.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        lkml <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Apr 27, 2021 at 10:25 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> Looking into history of changes it might be related to (Cc Daniel as well):
>
> commit d21b8adbd475dba19ac2086d3306327b4a297418
> Author: Daniel Drake <drake@endlessm.com>
> Date:   Wed Aug 14 17:05:40 2019 +0800
>
>    pinctrl: amd: disable spurious-firing GPIO IRQs

I think it's unlikely to be related (seems like the affected drivers
are claiming their IRQs so this would have no effect), but good to
poke every angle of course.
This could be confirmed by enabling dyndbg to see if the "Disabling
spurious GPIO" message gets emitted.

There's also a debugfs dump file for amd_gpio, could be useful to
compare this before & after the failure.

Daniel