Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp55703pxy; Tue, 27 Apr 2021 22:40:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJytpDPg93P2IBfjI2K7/IaccNcjYDlFMe79vjS5x+DTqq47V6su9BExj8oYIER7IOcbg209 X-Received: by 2002:aa7:8d03:0:b029:259:f2ed:1849 with SMTP id j3-20020aa78d030000b0290259f2ed1849mr27662259pfe.30.1619588446775; Tue, 27 Apr 2021 22:40:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619588446; cv=none; d=google.com; s=arc-20160816; b=PdYpCAO7OmJV17g3zmC1YCOJt4oMrBwKKjOZ6xSfnHq655NarLCOqFg3HmLqL1liDy Sx7uYsyErB5vf35fJGelkMaVkj5B//234E6TX2NH+yQ65Mr7hMxi32rVc8w6nEMvTl4T rKoNX7WZkziHtyJ3aCXQ+mFPNAf1QWMsp5hg+CBO4gwhB4SlvPJ1AvtXxeDrHVPHbGGr uTkZ22xTVkaH0R3tYKAiOJeYgwgk0S2YyWlu/OHBTCkro16yPnd2KaWgXbZ+uD41Qlp3 CIlx2D2PYft+DEqsgqe4AFjuiyiRtpg18Qwz3r0gdVulpPcf+rBxdnAo/xW6zQ82Tzb5 YMmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=FO7yfXPlSqM+JixDfPvieb2+0Lm/xWu2k8AvWDiCihU=; b=ZbX2IpPcHGng/bLdGSUAmTPOeqtPXF2BNXz1rptuHhvNvQNv5XEBiJmUERJD53dT1+ 4E6c6/UAMB7+n19YzOVKceqFYmY/LgRqc87QPI+ffQFEuRHhWDigipJ8MkpwguU9xwQq RRfdeEarZ8DGUrAYjI0req3P0mRNToms6Q7sGU5IASOApn50u7PCXKk3tbEhZVfjSLQd babvH4nZcZlmjEt0w/W+7B0ra4ShcH3W8BG+NfnmkStT4edjKqdu4CJ6b7wALG2Jsq7v fuu9jeMjtihnzVGhvNWfrlQwFYN3XPqL0nWM2eW/F6HqKSLIeNtPtOoklEVCyDaP4i9d y9zg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=QJHPLaOk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y6si2619167plr.68.2021.04.27.22.40.33; Tue, 27 Apr 2021 22:40:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=QJHPLaOk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234350AbhD1Fkk (ORCPT + 99 others); Wed, 28 Apr 2021 01:40:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:55280 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232529AbhD1Fkk (ORCPT ); Wed, 28 Apr 2021 01:40:40 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6619B61151; Wed, 28 Apr 2021 05:39:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1619588395; bh=qcm2LKOyvDfsY6a0QATO2wrAge2b/0RgJtqGlQMzAKw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QJHPLaOkE/26FQppgSYR6oa/zWoI/0J39mGG/bGKCep6b627WACt9jFPFzXFiLdf9 GaXAAHZPz1kBoXP7m56Qu+GEAhFDOy+PwfXt8ncaXxWO/gmICQpa+ubvbtF2y9q8bl JDr8mJEwjcRbd6QWfeVAHarSkKqrDwIky/tYkcBs= Date: Wed, 28 Apr 2021 07:39:52 +0200 From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Kangjie Lu , "David S . Miller" Subject: Re: [PATCH 128/190] Revert "net: strparser: fix a missing check for create_singlethread_workqueue" Message-ID: References: <20210421130105.1226686-1-gregkh@linuxfoundation.org> <20210421130105.1226686-129-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210421130105.1226686-129-gregkh@linuxfoundation.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 21, 2021 at 03:00:03PM +0200, Greg Kroah-Hartman wrote: > This reverts commit 228cd2dba27cee9956c1af97e6445be056881e41. > > Commits from @umn.edu addresses have been found to be submitted in "bad > faith" to try to test the kernel community's ability to review "known > malicious" changes. The result of these submissions can be found in a > paper published at the 42nd IEEE Symposium on Security and Privacy > entitled, "Open Source Insecurity: Stealthily Introducing > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University > of Minnesota) and Kangjie Lu (University of Minnesota). > > Because of this, all submissions from this group must be reverted from > the kernel tree and will need to be re-reviewed again to determine if > they actually are a valid fix. Until that work is complete, remove this > change to ensure that no problems are being introduced into the > codebase. > > Cc: Kangjie Lu > Cc: David S. Miller > Signed-off-by: Greg Kroah-Hartman > --- > net/strparser/strparser.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/net/strparser/strparser.c b/net/strparser/strparser.c > index b3815c1e8f2e..efce4ddaa320 100644 > --- a/net/strparser/strparser.c > +++ b/net/strparser/strparser.c > @@ -542,8 +542,6 @@ EXPORT_SYMBOL_GPL(strp_check_rcv); > static int __init strp_dev_init(void) > { > strp_wq = create_singlethread_workqueue("kstrp"); > - if (unlikely(!strp_wq)) > - return -ENOMEM; > > return 0; > } > -- > 2.31.1 > In the original commit "unlikely" should not have been used as it is not needed at all (the compiler and CPU already know this), but the commit is correct so I'll drop this revert. greg k-h