Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: skakit=codeaurora.org@mg.codeaurora.org
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Wed, 28 Apr 2021 11:28:07 +0530
From:   skakit@codeaurora.org
To:     Matthias Kaehlcke <mka@chromium.org>
Cc:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, kgunda@codeaurora.org
Subject: Re: [RESEND PATCH V3 4/5] arm64: dts: qcom: pmk8350: Add PMIC
 peripherals for pmk8350
In-Reply-To: <YH8PjqhZtiNhNv8h@google.com>
References: <1618398783-7834-1-git-send-email-skakit@codeaurora.org>
 <1618398783-7834-3-git-send-email-skakit@codeaurora.org>
 <YH8PjqhZtiNhNv8h@google.com>
Message-ID: <1853cf98592b092cba25542b91c89d9c@codeaurora.org>
User-Agent: Roundcube Webmail/1.3.9
Precedence: bulk

On 2021-04-20 22:59, Matthias Kaehlcke wrote:
> On Wed, Apr 14, 2021 at 04:43:00PM +0530, satya priya wrote:
> 
>> Subject: arm64: dts: qcom: pmk8350: Add PMIC peripherals for pmk8350
> 
> nit: why 'PMIC peripherals', are these peripherals somehow specific
> to PMICs?
> 

Okay will change it.

>> Add PON, RTC and other PMIC infra modules support for PMK8350.
> 
> nit: it seems somewhat arbitrary to specifically mention PON and RTC,
> and then treat the ADC and the thermal monitor as 'others'. You could
> just spell them out too.
> 

Okay.

>> 
>> Signed-off-by: satya priya <skakit@codeaurora.org>
>> ---
>>  arch/arm64/boot/dts/qcom/pmk8350.dtsi | 55 
>> ++++++++++++++++++++++++++++++++++-
>>  1 file changed, 54 insertions(+), 1 deletion(-)
>> 
>> diff --git a/arch/arm64/boot/dts/qcom/pmk8350.dtsi 
>> b/arch/arm64/boot/dts/qcom/pmk8350.dtsi
>> index 1530b8f..bbd9fa7 100644
>> --- a/arch/arm64/boot/dts/qcom/pmk8350.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/pmk8350.dtsi
>> @@ -3,6 +3,12 @@
>>   * Copyright (c) 2021, Linaro Limited
>>   */
>> 
>> +#include <dt-bindings/iio/qcom,spmi-adc7-pm8350.h>
>> +#include <dt-bindings/iio/qcom,spmi-adc7-pmk8350.h>
>> +#include <dt-bindings/iio/qcom,spmi-adc7-pmr735a.h>
>> +#include <dt-bindings/iio/qcom,spmi-adc7-pmr735b.h>
> 
> the includes of the constants for the other PMICs seems to be an
> remainder from older vesions, which included nodes for the on die
> temperatures of these PMICs.

As I have added on die temp nodes for these pmics in sc7280-idp file, 
will add these header files also there.

Thanks,
Satya Priya