Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp76709pxy; Tue, 27 Apr 2021 23:16:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxFzfz7OpaTHvk4BY2Njp7ORseg8DqjsrlSRsyhpivHVcR02EeJNU1UrW4bVDom4nzEFNtk X-Received: by 2002:a05:6402:30a5:: with SMTP id df5mr9014228edb.250.1619590594598; Tue, 27 Apr 2021 23:16:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619590594; cv=none; d=google.com; s=arc-20160816; b=Q9riDlt/L9TYH22qzNwl3lZuenR01Tl0D4WYluK03PnrCQ/AmtFrQ7IOnHgLk4scKy M0wjkfTjexapSjkYoHHypQI7hgaeT+L+imWtDhz8drxQhKGSoYfrUaEiRbluj94IyKR2 e7GkKgpZ966nzc43Gbr3Dz8yupKAKmvAUm0HCS8GEl5xvZZc2b/NtGrFeAvggAxZ2soN 2TBKhmKCF47MTISxvam2QasYi7/rELOPvgrklTmhbF5IwtG5BqpHWPlX5iki0S5FDP3V tP9+T3l+Qm00z32dGgBJLmjz9JJfNoYNl0FI/9xLKZTf4myGAY9JzRrIY7KfgvZ0qaXy r08w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=srfOTXJvUmnxbntppyLEwNI0q29ggWq8qkSvHmWn6R0=; b=TR9xP7j/ngzBaj0aaktaQeJRDOkwMmWT5VE3KSy5lFopvfnD6mVteCPcV/03qVQ+sA MZnj6P/wwsKmQ/1ymS7PkgX6Q1RaU/J32xspKSML9kpJ8hMClSjnePeLx4q7D0VLWVnu dlhvgUphYp6J2PiInF60xvSgFBY3M0WIvkj5b6PlQB2PEFB9Zbhc4hopnF1xgmbcUwX+ TXqcthjGIWzSLCzloYwA0zvU9wVyNXvcqM21ZZrcH/JY1UrtcsFWQ3m62rvnk9+P3uyH RqJX8X2Igx1MzpQNn77FN9FHbdxCiRqGAMO9575XTgkN27FLpbY83uiKWP0fC0oIztrb iotg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ne18si1917480ejc.115.2021.04.27.23.16.10; Tue, 27 Apr 2021 23:16:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236021AbhD1GPi (ORCPT + 99 others); Wed, 28 Apr 2021 02:15:38 -0400 Received: from verein.lst.de ([213.95.11.211]:47960 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229464AbhD1GPi (ORCPT ); Wed, 28 Apr 2021 02:15:38 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id D529168B05; Wed, 28 Apr 2021 08:14:51 +0200 (CEST) Date: Wed, 28 Apr 2021 08:14:51 +0200 From: Christoph Hellwig To: Sergey Senozhatsky Cc: Tomasz Figa , Hans Verkuil , Ricardo Ribalda , Christoph Hellwig , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv2 8/8] videobuf2: handle non-contiguous DMA allocations Message-ID: <20210428061451.GB5084@lst.de> References: <20210427131344.139443-1-senozhatsky@chromium.org> <20210427131344.139443-9-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210427131344.139443-9-senozhatsky@chromium.org> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 27, 2021 at 10:13:43PM +0900, Sergey Senozhatsky wrote: > This adds support for new noncontiguous DMA API, which > requires allocators to have two execution branches: one > for the current API, and one for the new one. > > Signed-off-by: Sergey Senozhatsky > [hch: untested conversion to the ne API] > Signed-off-by: Christoph Hellwig I think you can skip my signoff and the note here for the trivial conversion. The code looks fine to me from the DMA API perspective: Acked-by: Christoph Hellwig