Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [v1] MIPS:DTS:Correct device id of pcie for Loongnon-2K
To:     Jiaxun Yang <jiaxun.yang@flygoat.com>,
        Rob Herring <robh+dt@kernel.org>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        Qing Zhang <zhangqing@loongson.cn>
Cc:     devicetree@vger.kernel.org, linux-mips@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20210425130915.31001-1-maoxiaochuan@loongson.cn>
 <28bbe1bf-f421-afc7-07d3-e123764afe99@flygoat.com>
From:   Xiaochuan Mao <maoxiaochuan@loongson.cn>
Message-ID: <bce8bedc-30f9-f413-c68a-f5edf85046ee@loongson.cn>
Date:   Wed, 28 Apr 2021 14:53:17 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.1
MIME-Version: 1.0
In-Reply-To: <28bbe1bf-f421-afc7-07d3-e123764afe99@flygoat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Precedence: bulk


On 2021/4/25 下午9:49, Jiaxun Yang wrote:
>
> 在 2021/4/25 21:09, Xiaochuan Mao 写道:
>> from Loongson-2K user manual know that Loongson-2K have two
>> pcie controller pcie0 and pcie1, pcie0 have four port named port0~port3
>> and pcie1 have 2 port named port0~port1. the device id of port0 is 7a19
>> in each pcie controller and others are 7a09.
>>
>> Signed-off-by: Xiaochuan Mao <maoxiaochuan@loongson.cn>
>> ---
>> v1:
>> revert class code
>
>
> Could you please help me check the actual hardware?
>
> TBH I remeber I filled it with actual hardware values.

here is the pci info  on the board:

pci_device_match_ids: vendor:0014, device:7A03, class:00020000 , devfn:00001800

pci_device_match_ids: vendor:0014, device:7A03, class:00020000 , devfn:00001900
pci_device_match_ids: vendor:0014, device:7A04, class:000C0380 , devfn:00002000
pci_device_match_ids: vendor:0014, device:7A14, class:000C0320 , devfn:00002100
pci_device_match_ids: vendor:0014, device:7A24, class:000C0310 , devfn:00002200
pci_device_match_ids: vendor:0014, device:7A05, class:00030200 , devfn:00002800
pci_device_match_ids: vendor:0014, device:7A06, class:00030000 , devfn:00003000
pci_device_match_ids: vendor:0014, device:7A07, class:00040300 , devfn:00003800
pci_device_match_ids: vendor:0014, device:7A08, class:00010601 , devfn:00004000
pci_device_match_ids: vendor:0014, device:7A19, class:00060400 , devfn:00004800
pci_device_match_ids: vendor:0014, device:7A09, class:00060400 , devfn:00005000
pci_device_match_ids: vendor:0014, device:7A09, class:00060400 , devfn:00005800
pci_device_match_ids: vendor:0014, device:7A09, class:00060400 , devfn:00006000
pci_device_match_ids: vendor:0014, device:7A19, class:00060400 , devfn:00006800
>
> Btw the tittle should be prefixed with [PATCH v2]
>
> You may generate version suffix with `git format-patch -v2` or try to utilize patch management tools like git-publish[1].
>
> Thanks.
>
> [1]: https://github.com/stefanha/git-publish
>
got it , thanks for suggest.  I'll send v2.

> - Jiaxun
>
>
>> ---
>
> [...]

-- 
--xiaochuan