Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 28 Apr 2021 09:28:31 +0200
From:   Jiri Olsa <jolsa@redhat.com>
To:     "Jin, Yao" <yao.jin@linux.intel.com>
Cc:     acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
        mingo@redhat.com, alexander.shishkin@linux.intel.com,
        Linux-kernel@vger.kernel.org, ak@linux.intel.com,
        kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH v6 00/26] perf tool: AlderLake hybrid support series 1
Message-ID: <YIkOn9ZaTv87Kmjw@krava>
References: <20210427070139.25256-1-yao.jin@linux.intel.com>
 <YIgIiZVxOWdYTwef@krava>
 <d5309468-d6d6-ab8d-2f06-22b4f6e98917@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <d5309468-d6d6-ab8d-2f06-22b4f6e98917@linux.intel.com>
Precedence: bulk

On Wed, Apr 28, 2021 at 09:57:40AM +0800, Jin, Yao wrote:

SNIP

> > >           1.003959036 seconds time elapsed
> > > 
> > > Note that, since the whole patchset for AlderLake hybrid support is very
> > > large (40+ patches). For simplicity, it's splitted into several patch
> > > series.
> > > 
> > > The patch series 1 only supports the basic functionality. The advanced
> > > supports for perf-c2c/perf-mem/topdown/metrics/topology header and others
> > > will be added in follow-up patch series.
> > > 
> > > The perf tool codes can also be found at:
> > > https://github.com/yaoj/perf.git
> > 
> > hi,
> > did you update the branch for v6? I think I can't see
> > the new update there
> > 
> > thanks,
> > jirka
> > 
> 
> I just pushed the latest updates to https://github.com/yaoj/perf.git. Sorry it's getting late.
> 
> Actually it's Arnaldo's tmp.perf/core branch. Arnaldo has applied the patch
> series on tmp.perf/core and with an update on "[PATCH v6 01/26] tools
> headers uapi: Update tools's copy of
>  linux/perf_event.h".

np, I used Arnaldo's branch for review

> 
> If there are more comments which need to be addressed, we will start from tmp.perf/core for v7.
> 
> Thanks
> Jin Yao
> 
> > > 
> > > Note that, this patch series is based on tmp.perf/core branch.
> > > 
> > > v6:
> > > ---
> > > - Rebase to tmp.perf/core branch.
> > > 
> > > - A minor update in v6 patch series.
> > > 
> > >    In '[PATCH v6 18/26] perf tests: Add hybrid cases for 'Parse event
> > >    definition strings' test', we add a test case for cache events with
> > >    pmu prefix.
> > > 
> > >    No other updates.

I can't test the functionality, but apart from that all seems fine
and non-hybrid stuff keeps working ;-)

Reviewed-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka