Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp138577pxy; Wed, 28 Apr 2021 00:54:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzQbgukvcgaTERLGurcwH8VBsSROcJKdXDFzQkyyw5E61f6lUGbV4m64arn6PfswUtVvMYG X-Received: by 2002:a17:90a:5d0a:: with SMTP id s10mr31420408pji.170.1619596471200; Wed, 28 Apr 2021 00:54:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619596471; cv=none; d=google.com; s=arc-20160816; b=IBoDG+PMDJTCOuFY6MbID/ewMgnhGudZEs7fY4YdG0S5qZGs6/CgVvaMS37nGcJXbl ggkqT6I/tk847okbRsNj+Gy72z/S/wLza7afjPqNY9DqLSQSjXUVPTszsAPpjKTUPM+b 6bPthz5p3wF2yV+4nrLsXuSKHk3tksOwFx363ah4uF+l7Zy8GuPkFclqJLFZbeSfS1dJ lvu7BZ7OIO1wxrr8Pp7DBmM4aVSxhRbSwWWvH/wH5ogLoH1e6fX4MKALzZcud2MeU9Yw LMerWHr8bbwsxV1OrarLAuLYFySkoH1+o8LPuAihOEC5/QYo7sF2zZrAS17fnyyk9AQt ryOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=AKjr5Mo/adx/g8/qcHycfBQ5/KxoVEwsWbF6MXeqaAY=; b=gHvtbawQzcpfR8zXtmJyyUjIrv4+ZdjNfudWsBlVd9awjoqIHlFDmxZ1PsdIbkbNh0 gc46QBEyTbnPqrgilOywEguQLKILOwaX1tFlz2g+tDXVO2eHHeYgH7mVhhbcD+NMdJR6 zhE21wbNYXF29jBQbdb6Id1DRcZ7EClxlh7oQRFMgQzuorKRd0YLdNkJtMyANREGf4sX stjFU9L8Eotts4081nWi5L25S/JoayIyWYaJ8eVrnt2b0wPW2Tg82t66oaQDdQ+HTz3o a5gTp72epSyZ1eVqdCd8/PI8wHnNCpVrukczB3/hFeAYSfMJG11W6Mg1uZHeadFgz4nL EOaw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=GC+7KIp4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j7si2787672plk.121.2021.04.28.00.54.17; Wed, 28 Apr 2021 00:54:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=GC+7KIp4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235862AbhD1Hya (ORCPT + 99 others); Wed, 28 Apr 2021 03:54:30 -0400 Received: from mx0a-00069f02.pphosted.com ([205.220.165.32]:59886 "EHLO mx0a-00069f02.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229643AbhD1Hy2 (ORCPT ); Wed, 28 Apr 2021 03:54:28 -0400 Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 13S7rL8e002509; Wed, 28 Apr 2021 07:53:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=AKjr5Mo/adx/g8/qcHycfBQ5/KxoVEwsWbF6MXeqaAY=; b=GC+7KIp40xm5AzbROZ8bEHHNTSgU+5byZl9+xLkFtXSL5nMpjIC1zIzYnLbuuMc3cCDq RzbB73PtCZisn9hRiVf4OtrpMCV2v0ZBoM69EGFk5YM6YJ2XK/6OsauCgtuH4fEL8rZQ bZEd/xH77HzllDFsnzzJVb0bMhBL8fs5ecRMG4kboXQ9vaIGGa5HE5SEov6eFvyvFWOl C4S+eLvpheT5yJXdovaVNxjxw8RHqZCj02nGT4qZaq3YKCe5PQyoAuamolJlXa8eB278 01GNiQnzvzKwO5k/Gma97C4X5BUllF1mGlofJ2k3vBNOE2G7OK6MDKAUB4LvF92CILIE vQ== Received: from oracle.com (aserp3020.oracle.com [141.146.126.70]) by mx0b-00069f02.pphosted.com with ESMTP id 385sgq91tf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 28 Apr 2021 07:53:33 +0000 Received: from aserp3020.oracle.com (aserp3020.oracle.com [127.0.0.1]) by pps.podrdrct (8.16.0.36/8.16.0.36) with SMTP id 13S7p1qf156396; Wed, 28 Apr 2021 07:53:32 GMT Received: from pps.reinject (localhost [127.0.0.1]) by aserp3020.oracle.com with ESMTP id 384b58238h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 28 Apr 2021 07:53:32 +0000 Received: from aserp3020.oracle.com (aserp3020.oracle.com [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 13S7rW2R166987; Wed, 28 Apr 2021 07:53:32 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3020.oracle.com with ESMTP id 384b582384-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 28 Apr 2021 07:53:32 +0000 Received: from abhmp0018.oracle.com (abhmp0018.oracle.com [141.146.116.24]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 13S7rUdk023886; Wed, 28 Apr 2021 07:53:31 GMT Received: from kadam (/102.36.221.92) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 28 Apr 2021 00:53:30 -0700 Date: Wed, 28 Apr 2021 10:53:23 +0300 From: Dan Carpenter To: Fabio Aiuto Cc: Deepak R Varma , Mauro Carvalho Chehab , Sakari Ailus , Greg Kroah-Hartman , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/6] staging: media: atomisp: reformat code comment blocks Message-ID: <20210428075323.GP1981@kadam> References: <7cf7b8253550460e7273c94bae005939000679fd.1618859059.git.drv@mailo.com> <20210420084448.GC1411@agape.jhs> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210420084448.GC1411@agape.jhs> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-GUID: d1KBNGNDMsVudIB_tINeTfsVoRLkojPf X-Proofpoint-ORIG-GUID: d1KBNGNDMsVudIB_tINeTfsVoRLkojPf Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 20, 2021 at 10:44:48AM +0200, Fabio Aiuto wrote: > On Tue, Apr 20, 2021 at 12:45:04AM +0530, Deepak R Varma wrote: > > switch(AnalogGain) > > { > > case 0: > > @@ -1069,8 +1071,9 @@ static long mt9m114_s_exposure(struct v4l2_subdev *sd, > > */ > > if (DigitalGain >= 16 || DigitalGain <= 1) > > DigitalGain = 1; > > - /* AnalogGainToWrite = > > - (u16)((DigitalGain << 12) | AnalogGainToWrite); */ > > + > > + /* AnalogGainToWrite = (u16)((DigitalGain << 12) | AnalogGainToWrite); > > + */ > > this is best recommended for one line comment: > > /* AnalogGainToWrite = (u16)((DigitalGain << 12) | AnalogGainToWrite); */ > I'm going through old emails... Just delete all commented out code. regards, dan carpenter