Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Walter Harms <wharms@bfs.de>
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        "gcherian@marvell.com" <gcherian@marvell.com>,
        "herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
        "davem@davemloft.net" <davem@davemloft.net>
CC:     "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>
Subject: AW: [PATCH] crypto: cavium - Use 'hlist_for_each_entry' to simplify
 code
Thread-Topic: [PATCH] crypto: cavium - Use 'hlist_for_each_entry' to simplify
 code
Thread-Index: AQHXPADcKh3hPUi810mckHZ+wU3y0arJqq9s
Date:   Wed, 28 Apr 2021 09:34:58 +0000
Message-ID: <c621542318e644239008eea5f670390e@bfs.de>
References: <5a7692aa1d2ffb81e981fdf87b060db7e55956b8.1619593010.git.christophe.jaillet@wanadoo.fr>
In-Reply-To: <5a7692aa1d2ffb81e981fdf87b060db7e55956b8.1619593010.git.christophe.jaillet@wanadoo.fr>
Accept-Language: de-DE, en-US
Content-Language: de-DE
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Precedence: bulk

It is also possible to drop the else and simplify
further.

hlist_for_each_entry(chunk, &queue->chead, nextchunk)
if (chunk !=3D queue->qhead) {
                                queue->qhead =3D chunk;
                                break;
                        }

re,
 wh
________________________________________
Von: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Gesendet: Mittwoch, 28. April 2021 09:33:37
An: gcherian@marvell.com; herbert@gondor.apana.org.au; davem@davemloft.net
Cc: linux-crypto@vger.kernel.org; linux-kernel@vger.kernel.org; kernel-jani=
tors@vger.kernel.org; Christophe JAILLET
Betreff: [PATCH] crypto: cavium - Use 'hlist_for_each_entry' to simplify co=
de

WARNUNG: Diese E-Mail kam von au=DFerhalb der Organisation. Klicken Sie nic=
ht auf Links oder =F6ffnen Sie keine Anh=E4nge, es sei denn, Sie kennen den=
/die Absender*in und wissen, dass der Inhalt sicher ist.


Use 'hlist_for_each_entry' instead of hand writing it.
This saves a few lines of code.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
Compile tested only
---
 drivers/crypto/cavium/cpt/cptvf_reqmanager.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/crypto/cavium/cpt/cptvf_reqmanager.c b/drivers/crypto/=
cavium/cpt/cptvf_reqmanager.c
index 4fe7898c8561..feb0f76783dd 100644
--- a/drivers/crypto/cavium/cpt/cptvf_reqmanager.c
+++ b/drivers/crypto/cavium/cpt/cptvf_reqmanager.c
@@ -244,11 +244,7 @@ static int send_cpt_command(struct cpt_vf *cptvf, unio=
n cpt_inst_s *cmd,
        memcpy(ent, (void *)cmd, qinfo->cmd_size);

        if (++queue->idx >=3D queue->qhead->size / 64) {
-               struct hlist_node *node;
-
-               hlist_for_each(node, &queue->chead) {
-                       chunk =3D hlist_entry(node, struct command_chunk,
-                                           nextchunk);
+               hlist_for_each_entry(chunk, &queue->chead, nextchunk) {
                        if (chunk =3D=3D queue->qhead) {
                                continue;
                        } else {
--
2.30.2