Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp237720pxy; Wed, 28 Apr 2021 03:21:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyNXSAQM+TDa3BTCLPpeFP7HrzoAIjMWzB6l/UnMiuQtAdOwkRtin9V/60fJDW2XELBqjLW X-Received: by 2002:a17:906:2818:: with SMTP id r24mr28208342ejc.502.1619605284396; Wed, 28 Apr 2021 03:21:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619605284; cv=none; d=google.com; s=arc-20160816; b=XxoQ8DCA2v4cHaE30dj2JvX9iOp565uiH1RXjBiJxxrwJBTQXeD0B7pXnKW0EyEwZS l4+CtqyguD3WJuCPDCOqIf10xZN1uJ40/RRzqT1pp5ARjEt64md8Drch+uWKSh0mfM8z 8WT2CmSlGIlvB65sXZCnWGDsKQFFewvbnblDPaN8KRXGiBaEAnNoVR/poDFuQMjiN3cO yl3H8kZN3tQTRQBCHHEMuufHfG878aUxbtRkcbYSITGf/sES+JY8EV1V8NKPGOUmLrAS zR+NWXS7US9IEWzcLxM5dFrPqrfxw0WswjbO2yEg86ALeZ0IVTNOL1z4mFijZYZzPzW6 kd7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:dkim-signature; bh=hLCHCvSeJ/vv8w0+IunICaZcwOByQ5mOnzLPDvJakqs=; b=xh/VF4AW0XxzpJc62wM4LiAr3GQ4wfw1p1FCg+EAh6lurFxzvahe5OD4JC7QjsyBHl 7DOHdJyckQxl/7nAVB2DHwZQmkUdruJEM59nswCC3AR4phT5//FhkTNQebgxHc+M65Hj kWxWf38BJfgFOcncHxfnCccWIO9fd9zBtTLbJ1keGd20EtJZPT5ZeoByKvBJc9q9Dq1R adlZc9vY/aDrzNbl/Aaga1bOQPxyHrxvx2crm/D4ZMq160B1qd4tossajfMTSx1YAvT+ 7lqYMW3LyNgOcj3REnESi3SDZzK975q46q1l3lE/ogTyO7hUTmtBXJthfkkpRgztAh8k SZxg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=g7Av8htm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m23si2707848ejn.692.2021.04.28.03.21.01; Wed, 28 Apr 2021 03:21:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=g7Av8htm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238533AbhD1KDL (ORCPT + 99 others); Wed, 28 Apr 2021 06:03:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:57902 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238576AbhD1KC5 (ORCPT ); Wed, 28 Apr 2021 06:02:57 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id D409361428; Wed, 28 Apr 2021 10:02:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619604132; bh=4rKfuNxuT4bY7djH2rV77hgx7bS4JZfyV6crN8ofwZI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=g7Av8htmkt01vAK8/U/9xLLfL9SxwETJSdSP5L/qUByPEVW4ELVrARqQ8unxz3f3X 3u1CNi/Na1pWw+NeqLvuFCVw2iZTCBo4aqkuUvASUfNzLmIWFX8zZz3vCzdGjeCqRO u0ztUqxPs0FU70cPpcnvNNpeah+1P/3D02bOOt6shvDbmYKMUu4gELJTkq5jCG/Jep R/vuhQtciHRgJFe7mXSLkNBNw+DY2i5Xax0bHuzXtFaYgE7q0lRcjaNkxI0jSNniT9 Vg4Ha53dM6yd2K1zI/ZxATSxQi63vpNQWEG/SaYCy/Arx4jvCZk/HPJW+DvDsQZhcW 29rZ6ZpbVExRA== From: Felipe Balbi To: Sandeep Maheswaram , Andy Gross , Bjorn Andersson , Greg Kroah-Hartman , Stephen Boyd , Doug Anderson , Matthias Kaehlcke Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Manu Gautam , Sandeep Maheswaram Subject: Re: [PATCH v7 4/5] usb: dwc3: qcom: Configure wakeup interrupts during suspend In-Reply-To: <1619586716-8687-5-git-send-email-sanm@codeaurora.org> References: <1619586716-8687-1-git-send-email-sanm@codeaurora.org> <1619586716-8687-5-git-send-email-sanm@codeaurora.org> Date: Wed, 28 Apr 2021 13:02:04 +0300 Message-ID: <87o8dyk9r7.fsf@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Sandeep Maheswaram writes: > Configure interrupts based on hs_phy_mode to avoid triggering of > interrupts during system suspend and suspend the device successfully. > > Signed-off-by: Sandeep Maheswaram > Reviewed-by: Matthias Kaehlcke > --- > drivers/usb/dwc3/dwc3-qcom.c | 26 ++++++++++++++++++++------ > 1 file changed, 20 insertions(+), 6 deletions(-) > > diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c > index 66183c6..82125bc 100644 > --- a/drivers/usb/dwc3/dwc3-qcom.c > +++ b/drivers/usb/dwc3/dwc3-qcom.c > @@ -316,22 +316,36 @@ static void dwc3_qcom_disable_wakeup_irq(int irq) >=20=20 > static void dwc3_qcom_disable_interrupts(struct dwc3_qcom *qcom) > { > - dwc3_qcom_disable_wakeup_irq(qcom->hs_phy_irq); > + struct dwc3 *dwc =3D platform_get_drvdata(qcom->dwc3); and who's using this? > static void dwc3_qcom_enable_interrupts(struct dwc3_qcom *qcom) > { > - dwc3_qcom_enable_wakeup_irq(qcom->hs_phy_irq); > + struct dwc3 *dwc =3D platform_get_drvdata(qcom->dwc3); or this? =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJFBAEBCAAvFiEElLzh7wn96CXwjh2IzL64meEamQYFAmCJMpwRHGJhbGJpQGtl cm5lbC5vcmcACgkQzL64meEamQY3WQ//egPFZ6rFOwMJN2z28acWg0qrBgOq4+zF LgHi7jAre4kEFG8383bfpklyCqyFQrtPCvOxgFEMqDUw+OQCMukYX6PTrfJYRjty L+Yir6Z47XRIaN/Li/AYXaf3Oze2kcsdTEFj0aWhgrd5QCa6q4Yq7KnXiYXQywy/ 2fWI5qLLoh9mK6H5RBNtNWv0eb2PFt+IjJz9NHFfVT1l3HvRJ+cxhSR9VGA+3f/n LqmL0XRfSYhgPWLsAeDDAVO6noJt68Gt4mk/IMD4hU3L5F3hJA5nKzXbgmA58m93 kRbdgl8aY0SwsET1PGrlzstN3nVrMq8KQi7AuXggoRSSbtsshtsnxdZgLb+AYgxX TjRu3A9y4zqq5Q7g9l9wITsy0QLhUM/I+X5+jG/L3kuMtFaJTIqRMdj2oHpxv/dG z5725AkG408ZjJpABkGBC67ziWC56AYeRBveddhYgMv/R4rVAkmQNnYisBwbtUGI 1kBehUikeWznIJwqJJ2sfnQlCL7Ji96zJwok9xdIK1CAllwMW0o4C6ouvhUy+c/v r+D8r/Z/HB7oVH9b6RIzYzQ92KurbcEcFPfgyAHvB8SlPL3UaTM5fb6eTa6Um4Qw 0cBoZFTmMSjrD+tMCnBp7mr4UGQy6yi1RT1l+Thpsr13k8QhQDMeOmlwVhVwNVLl vqr+Z9xRqOg= =5e9z -----END PGP SIGNATURE----- --=-=-=--