Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946410AbWJSTzw (ORCPT ); Thu, 19 Oct 2006 15:55:52 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1946407AbWJSTzw (ORCPT ); Thu, 19 Oct 2006 15:55:52 -0400 Received: from livid.absolutedigital.net ([66.92.46.173]:48141 "EHLO mx2.absolutedigital.net") by vger.kernel.org with ESMTP id S1946410AbWJSTzv (ORCPT ); Thu, 19 Oct 2006 15:55:51 -0400 Date: Thu, 19 Oct 2006 15:55:49 -0400 (EDT) From: Cal Peake To: Alexey Dobriyan cc: "Eric W. Biederman" , Andrew Morton , Linus Torvalds , Albert Cahalan , linux-kernel Subject: Re: [RFC] [PATCH] Improve the remove sysctl warnings. In-Reply-To: <20061019195040.GA5392@martell.zuzino.mipt.ru> Message-ID: References: <787b0d920610181123q1848693ajccf7a91567e54227@mail.gmail.com> <20061018124415.e45ece22.akpm@osdl.org> <20061019195040.GA5392@martell.zuzino.mipt.ru> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1191 Lines: 35 On Thu, 19 Oct 2006, Alexey Dobriyan wrote: > On Thu, Oct 19, 2006 at 12:25:20PM -0400, Cal Peake wrote: > > On Wed, 18 Oct 2006, Eric W. Biederman wrote: > > > > > if (msg_count < 5) { > > > msg_count++; > > > printk(KERN_INFO > > > "warning: process `%s' used the removed sysctl " > > > - "system call\n", current->comm); > > > + "system call with ", current->comm); > > > + for (i = 0; i < tmp.nlen; i++) > > > + printk("%d.", name[i]); > > > + printk("\n"); > > > } > > > > We should prolly kill the counter now. > > sysctl(2) callable by everyone including local lusers willing to fill logs. Users don't even need to write a program to do this, see logger(1). If we keep the counter then after 5 calls we lose potential debugging info. - C. -- "There is nothing wrong with your television set. Do not attempt to adjust the picture. We are controlling transmission." -- The Outer Limits - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/