Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 28 Apr 2021 13:56:19 +0200
From:   Johan Hovold <johan@kernel.org>
To:     Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Cc:     Jacopo Mondi <jacopo@jmondi.org>, linuxarm@huawei.com,
        mauro.chehab@huawei.com, Hans Verkuil <hverkuil-cisco@xs4all.nl>,
        Jacopo Mondi <jacopo+renesas@jmondi.org>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        linux-kernel@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH 38/78] media: i2c: mt9m001: use
 pm_runtime_resume_and_get()
Message-ID: <YIlNY7xJYmqtxVOe@hovoldconsulting.com>
References: <cover.1619191723.git.mchehab+huawei@kernel.org>
 <beddb7295807f43a190f2add6c1665b7475cb154.1619191723.git.mchehab+huawei@kernel.org>
 <20210424082454.2ciold3j3h2jw47m@uno.localdomain>
 <YIPsTsEA/F+o7fhQ@hovoldconsulting.com>
 <20210426163840.67ea8af9@coco.lan>
 <YIgCOA1kSd/lzLFc@hovoldconsulting.com>
 <20210428103148.590191ac@coco.lan>
 <YIkzZs8t0lMWVjzt@hovoldconsulting.com>
 <20210428132853.65b162a0@coco.lan>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210428132853.65b162a0@coco.lan>
Precedence: bulk

On Wed, Apr 28, 2021 at 01:28:53PM +0200, Mauro Carvalho Chehab wrote:
> Em Wed, 28 Apr 2021 12:05:26 +0200
> Johan Hovold <johan@kernel.org> escreveu:

> > Right, a resume failure is a pretty big issue and it's not really clear
> > how to to even handle that generally. But at remove() time you don't
> > have much choice but to go on and release resource anyway. 
> > 
> > So unless actually implementing some error handling too, using
> > pm_runtime_sync_get() without checking for errors is still preferred
> > over pm_runtime_resume_and_get(). That is 
> > 
> > 	pm_runtime_get_sync();
> > 	/* cleanup */
> > 	pm_runtime_disable()
> > 	pm_runtime_put_noidle();
> > 
> > is better than:
> > 
> > 	ret = pm_runtime_resume_and_get();
> > 	/* cleanup */
> > 	pm_runtime_disable();
> > 	if (ret == 0)
> > 		pm_runtime_put_noidle();
> > 
> > unless you also start doing something ret.
> 
> Perhaps the best would be to use, instead:
> 
> 	pm_runtime_get_noresume();
>  	/* cleanup */
>  	pm_runtime_disable()
>  	pm_runtime_put_noidle();
> 	pm_runtime_set_suspended();
> 
> I mean, at least for my eyes, it doesn't make sense to do a PM
> resume during driver's removal/unbind time.

The cleanup bit above would depend on the device being resumed so using
pm_runtime_get_noresume() makes little sense.

Some drivers disable clocks etc explicitly at remove instead of relying
on pm runtime for that and then they'd use the above scheme (plus
explicit pm_runtime_set_suspended()).

Johan