Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 28 Apr 2021 17:56:14 +0530
From:   bkkarthik <bkkarthik@pesu.pes.edu>
To:     Leon Romanovsky <leon@kernel.org>
Cc:     Jaroslav Kysela <perex@perex.cz>,
        Anupama K Patil <anupamakpatil123@gmail.com>,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
        linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
        skhan@linuxfoundation.org, gregkh@linuxfoundation.org,
        kernelnewbies@kernelnewbies.org
Subject: Re: [PATCH] drivers: pnp: proc.c: Handle errors while attaching
 devices
Message-ID: <20210428122614.xhqgv5bneytooczk@burgerking>
References: <20210424194301.jmsqpycvsm7izbk3@ubuntu>
 <YIZJwkux0ghJ8k9d@unreal>
 <20210426175031.w26ovnffjiow346h@burgerking>
 <59a5d631-6658-2034-06c4-467520b5b9f7@perex.cz>
 <YIlTY8p4kpkORPfl@unreal>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="cm3rvmjl7mhm5aus"
Content-Disposition: inline
In-Reply-To: <YIlTY8p4kpkORPfl@unreal>
User-Agent: NeoMutt/20171215
Precedence: bulk


--cm3rvmjl7mhm5aus
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 21/04/28 03:21PM, Leon Romanovsky wrote:
> On Wed, Apr 28, 2021 at 02:04:49PM +0200, Jaroslav Kysela wrote:
> > Dne 26. 04. 21 v 19:50 bkkarthik napsal(a):
> > > On 21/04/26 08:04AM, Leon Romanovsky wrote:
> > >> On Sun, Apr 25, 2021 at 01:13:01AM +0530, Anupama K Patil wrote:
> > >>> isapnp_proc_init() does not look at the return value from
> > >>> isapnp_proc_attach_device(). Check for this return value in
> > >>> isapnp_proc_detach_device().
> > >>>
> > >>> Cleanup in isapnp_proc_detach_device and
> > >>> isapnp_proc_detach_bus() for cleanup.
> > >>>
> > >>> Changed sprintf() to the kernel-space function scnprintf() as it re=
turns
> > >>> the actual number of bytes written.
> > >>>
> > >>> Removed unnecessary variables de, e of type 'struct proc_dir_entry'=
 to
> > >>> save memory.
> > >>
> > >> What exactly do you fix for such an old code?
> > >=20
> > > I was not aware that this code is so old. This fix was made after che=
ckpatch reported assignment inside an if-statement.
> > > Please ignore this patch if th change is not necessary as the code is=
 probably not being used anywhere :)
> > >=20
> > > Maybe the code has to be marked as obsolete in the MAINTAINERS file t=
o prevent patches being sent?
> > >=20
> > >>
> > >>>
> > >>> Suggested-by: Shuah Khan <skhan@linuxfoundation.org>
> > >>> Co-developed-by: B K Karthik <bkkarthik@pesu.pes.edu>
> > >>> Signed-off-by: B K Karthik <bkkarthik@pesu.pes.edu>
> > >>> Signed-off-by: Anupama K Patil <anupamakpatil123@gmail.com>
> > >>> ---
> > >>>  drivers/pnp/isapnp/proc.c | 40 +++++++++++++++++++++++++++++------=
----
> > >>>  1 file changed, 30 insertions(+), 10 deletions(-)
> > >>>
> > >>> diff --git a/drivers/pnp/isapnp/proc.c b/drivers/pnp/isapnp/proc.c
> > >>> index 785a796430fa..46ebc24175b7 100644
> > >>> --- a/drivers/pnp/isapnp/proc.c
> > >>> +++ b/drivers/pnp/isapnp/proc.c
> > >>> @@ -54,34 +54,54 @@ static const struct proc_ops isapnp_proc_bus_pr=
oc_ops =3D {
> > >>>  	.proc_read	=3D isapnp_proc_bus_read,
> > >>>  };
> > >>> =20
> > >>> +static int isapnp_proc_detach_device(struct pnp_dev *dev)
> > >>> +{
> > >>> +	proc_remove(dev->procent);
> > >>> +	dev->procent =3D NULL;
> > >>> +	return 0;
> > >>> +}
> > >>> +
> > >>> +static int isapnp_proc_detach_bus(struct pnp_card *bus)
> > >>> +{
> > >>> +	proc_remove(bus->procdir);
> > >>> +	return 0;
> > >>> +}
> > >>
> > >> Please don't add one line functions that are called only once and ha=
ve
> > >> return value that no one care about it.
> > >=20
> > > These were only intended for a clean-up job, the idea of this functio=
n came from how PCI handles procfs.
> > > Maybe those should be changed?
> >=20
> > Which code you refer? I see:
> >=20
> >        for_each_pci_dev(dev)
> >                 pci_proc_attach_device(dev);
>=20
> He talks about isapnp_proc_detach_*() functions.

Yes, pci_proc_detach_device() and pci_proc_detach_bus() are both one-line f=
unctions as well.
I don't mean to question working code, we only tried to do something simila=
r here for ISA.

thanks,

karthik

>=20
> >=20
> >=20
> > The error codes are ignored, too. It does not harm, if proc entries are=
 not
> > created (in this case - the system is unstable anyway). We should conce=
ntrate
> > only to the wrong pointers usage.
> >=20
> > 						Jaroslav
> >=20
> > --=20
> > Jaroslav Kysela <perex@perex.cz>
> > Linux Sound Maintainer; ALSA Project; Red Hat, Inc.

--cm3rvmjl7mhm5aus
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQGzBAEBCgAdFiEEIRwfsurAmIAiSNrGB1QtCt0juC0FAmCJVGUACgkQB1QtCt0j
uC2ksAv+JU5viUb1QYtJfkCDGxwTlT3dctCstPQ1rSSs0ca8ixgJCrRD2n8DjVQm
0WTR72ZoD5WFbYsfN2q0zDG1MkHJ4dQ2kzRXr/vy59xN9AlCiPKJ6iXQXgsM4H8c
bAfmLYZIwgJAJ59G3BKWpsLbEwhojvTc1tcnGpObk5oNRouaVSi6UnO/+kFyChpJ
M+OlhoJMr64WukQskSu3fKXXzou4DAA6Dzii4JkMssC08RMumf/fReCovkDzDmry
l5wNi0MHzgBPMISCRjHwHUVId2LL8reqib8gZJ6Ok6ILln1qI00jJJChjKhHL3TU
FY8MlWCXz/uW6lwWHiHP00ioeoU2u+IQqifQqd9gQzucp1Ekxw4QQDiDTReT4ob4
FMYo2cOaJm1uLDWKfmamIp6ZCHM7Om1aSms6oOq8F5OzK+VHvUs+9kPiqN9opIf6
/6FM3LyytWxsKAd7NQdI95OLC7EvBMu3iJRNOYj/eCXys8EkfGkff9mCAAnDySjN
S36lDsFk
=VxVi
-----END PGP SIGNATURE-----

--cm3rvmjl7mhm5aus--