Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp619011pxy; Wed, 28 Apr 2021 10:35:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx17No/43XVN3aCKNnp/9McD6uDFahN1BSh7JvmJ4qOkaBKTqWtIQTICCpZTKLsQiutCVnK X-Received: by 2002:aa7:cf12:: with SMTP id a18mr6068113edy.160.1619631334986; Wed, 28 Apr 2021 10:35:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619631334; cv=none; d=google.com; s=arc-20160816; b=zdhKM44swlRPJTseeP0hkP0z1vB9jMF6X6Nd4M6jIe6da/rZnDp3N1biw/ixP8/MqK B5rP0upOr1TLnqoLBOKoYfLfitKMl4vMh04QykRDI5k9hOokD/AdNDOSX6IzMCKMRl7W kpDiryo7+ehZHRUR/Jj4MSw9KBBCwq0S909ZLhYk6AwefuY2sIn1B3zFBInXzEWjL9H+ 1dLW+eHiLvVVRWfDmL2jFKC9F7IEJT4m5dfZKZDq4hbYBnia/8YMZYrNs1pemhS1OXOw W7WMQa5C6f/YiHSf9/5MDjX9Q8CDDB60P65vjiXEruX+y6wBYDooKFcNK8+cvrLYU1yl GGUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:dkim-signature:dkim-signature:from; bh=Yhrm1zOqkUS61+Y9hGn2Bze80Gv2AY9rckCTy31Zc88=; b=TkT4Gxd/WnLCXvk1DqzzxRHcQPVHGs93sCbwges/jOPeK1JRi5FothXINEMMB3zjN7 JzmdFHyF2TokLLUWf3DY6riyPMDaA+YngIEPqOk9CmL292/wgqzLmFqA1Uysz0MfVL8Q uoi7au50j3OM6WntCRU3VRGgNPrvpedgwy594D3qbrdcElgtLTBUrQAE0BQuVMQPUhix zGCVbHU/JX/Jmmg/adimU1SlPZqUub7rCGhMnkiX0yrhVV8Wj+m1GjenMZlT64OqQGOH MgKUnDVQ6LU697FddZOvaxB6oq/K55xmJh0wafdczs+nYOBmAvnFf3+smQTc8QFZO061 ycig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=kQ3kjkTk; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=hwoZbbC7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x11si587311ejv.267.2021.04.28.10.35.10; Wed, 28 Apr 2021 10:35:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=kQ3kjkTk; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=hwoZbbC7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234326AbhD1Oi3 (ORCPT + 99 others); Wed, 28 Apr 2021 10:38:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233516AbhD1Oi3 (ORCPT ); Wed, 28 Apr 2021 10:38:29 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 411A5C061573 for ; Wed, 28 Apr 2021 07:37:44 -0700 (PDT) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1619620662; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Yhrm1zOqkUS61+Y9hGn2Bze80Gv2AY9rckCTy31Zc88=; b=kQ3kjkTk/D3nvQMMtABVVjsGtVeIzF0lwCszgJ8GjKpCgdp1buGNhX3BIbN86/4ETCKvk6 mvpn3fCLMfWWkvM3EgQk5VFIrz3LoihYoR2MRBOR79mEQGf1rFLbYwQbwzpHpoAfqwFB9c hVVPFeg8BHuc0ZNx7tv/yCdc8TbSSsrKoPRXsvi84eYUxnERJA2iMjkl7yZLXe6C+AdLAP rvbD5IOHgPgR/wfvI3Ro78ICI3cwLnjH/L7V70P3IsjpoeZGQvjBMXX4XgkoYVpqmv+xj4 Pixwl0V6GYn6bAl6ATy6PgSR6o7Y9z2CN7NkjRQ2Wz3+rm6fsCuoQo0b9mqayw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1619620662; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Yhrm1zOqkUS61+Y9hGn2Bze80Gv2AY9rckCTy31Zc88=; b=hwoZbbC7j6RaJM9uv/hxOBsjaL/9WksOcBGSMWPoaBZmXJit5Hl7rmmFIv2ptW91jqm0bp 0VG7jZJ4d+Fh7DAA== To: Luming Yu , paulmck@kernel.org Cc: Andi Kleen , LKML , john.stultz@linaro.org, sboyd@kernel.org, corbet@lwn.net, Mark.Rutland@arm.com, maz@kernel.org, kernel-team@fb.com, neeraju@codeaurora.org, feng.tang@intel.com, zhengjun.xing@intel.com, Chris Mason Subject: Re: [PATCH v10 clocksource 1/7] clocksource: Provide module parameters to inject delays in watchdog In-Reply-To: References: <20210425224540.GA1312438@paulmck-ThinkPad-P17-Gen-1> <20210425224709.1312655-1-paulmck@kernel.org> <20210426040736.GS1401198@tassilo.jf.intel.com> <20210426152801.GY975577@paulmck-ThinkPad-P17-Gen-1> <20210426160008.GY1401198@tassilo.jf.intel.com> <20210426161425.GC975577@paulmck-ThinkPad-P17-Gen-1> <20210426175627.GZ1401198@tassilo.jf.intel.com> <20210426182433.GD975577@paulmck-ThinkPad-P17-Gen-1> <20210428135725.GN975577@paulmck-ThinkPad-P17-Gen-1> Date: Wed, 28 Apr 2021 16:37:41 +0200 Message-ID: <877dkmmq4q.ffs@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 28 2021 at 22:24, Luming Yu wrote: > On Wed, Apr 28, 2021 at 9:57 PM Paul E. McKenney wrote: >> Therefore, the code marks the clock unstable if it has four bad reads >> in a row, as it should. > > The hard problem to solve is tsc is still in good shape and it can be verified > with a quick cross check with other thread/core's tsc counts in the > injected situation or in real life case > to prove if it is truly a tsc problem or reference clock's problem of > the watchdog. > > Ideally, we could factor out hard-to-debug unstable tsc problems from > clock source watchdog problems > and get less and less tsc sightings caused by clock source watchdog. The only way to fix this is at the hardware level. Everything else is wishful thinking. Thanks, tglx