Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946473AbWJSUhS (ORCPT ); Thu, 19 Oct 2006 16:37:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1946477AbWJSUhS (ORCPT ); Thu, 19 Oct 2006 16:37:18 -0400 Received: from e6.ny.us.ibm.com ([32.97.182.146]:30342 "EHLO e6.ny.us.ibm.com") by vger.kernel.org with ESMTP id S1946473AbWJSUhP (ORCPT ); Thu, 19 Oct 2006 16:37:15 -0400 Subject: Re: kernel BUG in __cache_alloc_node at linux-2.6.git/mm/slab.c:3177! From: Will Schmidt Reply-To: will_schmidt@vnet.ibm.com To: Christoph Lameter Cc: Anton Blanchard , akpm@osdl.org, linuxppc-dev@ozlabs.org, Paul Mackerras , linux-kernel@vger.kernel.org In-Reply-To: References: <1161026409.31903.15.camel@farscape> <1161031821.31903.28.camel@farscape> <17717.50596.248553.816155@cargo.ozlabs.ibm.com> <17718.39522.456361.987639@cargo.ozlabs.ibm.com> <17719.1849.245776.4501@cargo.ozlabs.ibm.com> <20061019163044.GB5819@krispykreme> Content-Type: text/plain Organization: IBM Date: Thu, 19 Oct 2006 15:37:09 -0500 Message-Id: <1161290229.8946.51.camel@farscape> Mime-Version: 1.0 X-Mailer: Evolution 2.6.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1803 Lines: 45 On Thu, 2006-19-10 at 10:03 -0700, Christoph Lameter wrote: > I would expect this patch to fix your issues. This will allow fallback > allocations to occur in the page allocator during slab bootstrap. This > means your per node queues will be contaminated as they were before. After > the slab allocator is fully booted then the per node queues will become > gradually become node clean. > > I think it would be better if the PPC arch would fix this issue > by either making memory available on node 0 or setting up node 1 as > the boot node. > This didnt fix the problem on my box. I tried this both against mm and linux-2.6.git > Signed-off-by: Christoph Lameter > > Index: linux-2.6.19-rc2-mm1/mm/slab.c > =================================================================== > --- linux-2.6.19-rc2-mm1.orig/mm/slab.c 2006-10-19 11:54:24.000000000 -0500 > +++ linux-2.6.19-rc2-mm1/mm/slab.c 2006-10-19 11:59:24.208194796 -0500 > @@ -1589,7 +1589,10 @@ static void *kmem_getpages(struct kmem_c > * the needed fallback ourselves since we want to serve from our > * per node object lists first for other nodes. > */ > - flags |= cachep->gfpflags | GFP_THISNODE; > + if (g_cpucache_up != FULL) > + flags |= cachep->gfpflags; > + else > + flags |= cachep->gfpflags | GFP_THISNODE; > > page = alloc_pages_node(nodeid, flags, cachep->gfporder); > if (!page) > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@ozlabs.org > https://ozlabs.org/mailman/listinfo/linuxppc-dev - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/