Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Sa, Nuno" <Nuno.Sa@analog.com>
To:     Paul Cercueil <paul@crapouillou.net>,
        Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Peter Meerwald-Stadler <pmeerw@pmeerw.net>
CC:     "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] tools/iio: iio_event_monitor: Fix ioctl error check
Thread-Topic: [PATCH] tools/iio: iio_event_monitor: Fix ioctl error check
Thread-Index: AQHXPEBt7lP4jf8Fa0q9Q53QuBs0oarKDhSA
Date:   Wed, 28 Apr 2021 15:30:43 +0000
Message-ID: <CY4PR03MB3112198E9789BF3D95959E6F99409@CY4PR03MB3112.namprd03.prod.outlook.com>
References: <20210428150815.136150-1-paul@crapouillou.net>
In-Reply-To: <20210428150815.136150-1-paul@crapouillou.net>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 55e16f12-e14d-4325-34ec-08d90a5a9646
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Apr 2021 15:30:43.3194
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: eaa689b4-8f87-40e0-9c6f-7228de4d754a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: X54tSeX+k3kK/iHtiHTIRYPpdUC1Pjk3xwMwT+9XDbP8849bWutMBNNBGty9X8/1KugqPePH1r4ss7NnM4JTew==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB2743
X-Proofpoint-ORIG-GUID: 5mi0tGPcxwm2yp-1yIvY5bxFK5KdqaOQ
X-Proofpoint-GUID: 5mi0tGPcxwm2yp-1yIvY5bxFK5KdqaOQ
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.761
 definitions=2021-04-28_09:2021-04-28,2021-04-28 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 clxscore=1011
 mlxlogscore=999 priorityscore=1501 impostorscore=0 adultscore=0
 suspectscore=0 lowpriorityscore=0 bulkscore=0 spamscore=0 malwarescore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2104060000 definitions=main-2104280101
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Paul Cercueil <paul@crapouillou.net>
> Sent: Wednesday, April 28, 2021 5:08 PM
> To: Jonathan Cameron <jic23@kernel.org>; Lars-Peter Clausen
> <lars@metafoo.de>; Peter Meerwald-Stadler
> <pmeerw@pmeerw.net>
> Cc: linux-iio@vger.kernel.org; linux-kernel@vger.kernel.org; Paul
> Cercueil <paul@crapouillou.net>
> Subject: [PATCH] tools/iio: iio_event_monitor: Fix ioctl error check
>=20
>=20
> The ioctrl() call will return errno=3DEINVAL if the device does not
> support the events interface, and not ENODEV.
>=20
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>

Reviewed-by: Nuno Sa <nuno.sa@analog.com>

> ---
>  tools/iio/iio_event_monitor.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/tools/iio/iio_event_monitor.c
> b/tools/iio/iio_event_monitor.c
> index bb03859db89d..cdd9a84f18fa 100644
> --- a/tools/iio/iio_event_monitor.c
> +++ b/tools/iio/iio_event_monitor.c
> @@ -323,7 +323,7 @@ int main(int argc, char **argv)
>  	ret =3D ioctl(fd, IIO_GET_EVENT_FD_IOCTL, &event_fd);
>  	if (ret =3D=3D -1 || event_fd =3D=3D -1) {
>  		ret =3D -errno;
> -		if (ret =3D=3D -ENODEV)
> +		if (ret =3D=3D -EINVAL)
>  			fprintf(stderr,
>  				"This device does not support
> events\n");
>  		else
> --
> 2.30.2