Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp621056pxy; Wed, 28 Apr 2021 10:37:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwqyyWAoM8ehdsre/Jj9weSJu9N1yluSFpoGgSpFS7BwcQvV1+/iPktjqZTuxK7AZhSQNTV X-Received: by 2002:a17:906:f8d7:: with SMTP id lh23mr30357159ejb.77.1619631389279; Wed, 28 Apr 2021 10:36:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619631389; cv=none; d=google.com; s=arc-20160816; b=TDd2sj6eaKZopuSqUsFiA+uP42G+FFSwXX5dw2BDM/Pth89SWh6J6FBNAh+0G7Hb9t QVziT3oQuiv9jyoXx/e+RJUXOdydcxzK5GfHJ6M43GQYllamZPd3pjLvJxSg7Cjjd5Dy V444fsAuuid7Q6X4/4yzQ7Ldx0Dyxs7LaW8cnjgN9ddu8OUUYv3WkQa+3TU8aihs9mEW w80dLYrjnPsRCC0cOEmyz2j+EmbB/9jgEWK2lE9US5GJzixgfD288hMGuDPwmydpPV/5 83WFTpG1/Riu0K0Pdno+9CGoVfegvuD0DRIKMBFi2jR6dlcRTd8qVXV13hhyZbaeDzEW hVAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:from :dkim-signature; bh=l0nFwYPWPiXFHgUKHwaK5u28Bc2/mwKnyZYYdjE5Uoc=; b=zfLJ0ubVW/ArPUzGrpop3D/d1OPLUchtegbdGv1QXlOyynXGzqY6YZBVAkeLO797jq VNBmI+a/iKV5ce8goYQ+eaJ0UFZ3lzBQ5nXSXfZfYbFnAQvbJ7/0BwODTM8EqyUJklod pyt/QUqUNX5XcrZdRO9bB0iyOfBvCLL8/q6rbqF9oGusEOfmyveoCY29u5fnkMUiBhzy brd743186nKMjdLCBQKMQEsHOQnMiNrho2t5X2S6IwoqTv1nVJU20GPz1gDtb+bNAQjH tOjHkxqRV8ZXw1DmWs0Q4Tb70oPq2JY+rxlwv8WzXr3TGcEfnu0UpcJhOPkEcT9KUZzP dMpg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@kernel.org header.s=k20201202 header.b=YUNO73Ti; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 10si389364edx.129.2021.04.28.10.36.05; Wed, 28 Apr 2021 10:36:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@kernel.org header.s=k20201202 header.b=YUNO73Ti; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240520AbhD1O7G (ORCPT + 99 others); Wed, 28 Apr 2021 10:59:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:36352 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240481AbhD1OyM (ORCPT ); Wed, 28 Apr 2021 10:54:12 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id CE9CA61955; Wed, 28 Apr 2021 14:52:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619621565; bh=oAi5YzlfFlQMfzPh3wYGQ2xjGcqBCgu57W3dE0PjRzI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YUNO73Ti7qVJ8KEBqLIktYQxFH8JYnBtDIc2QAqtJTStv+6bQQs3WmpNXK8MSe+C5 4igrIUbefLK4r4EmdeAch/KeaXscUPM33B/0eyzFNwwg/9ee59a0GM+NjvncX43CXl ncVAKRys9liIr24vhwoVqMu2uID0rr0ovPl+Uq3OlaODXB2KukmcdYpYIpOkSifFi0 l0C1ah/8MDJ4/EotRtrpgX34+tDjpD8K6SsKtdaARgQ07GVJhg2MNfdI0HNPCRWCft yoZ7EG0NikOmtSvWytQCxy09/1i1TGPFB2PyCTEBn/8uDlZMPGMklVmDoTO0otZOa/ BQXu8fGSuS1Sw== Received: by mail.kernel.org with local (Exim 4.94) (envelope-from ) id 1lblYR-001Ds9-3V; Wed, 28 Apr 2021 16:52:43 +0200 From: Mauro Carvalho Chehab Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Mauro Carvalho Chehab , Colin Ian King , Hans Verkuil , Mauro Carvalho Chehab , Paul Kocialkowski , Sakari Ailus , Yang Li , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v4 53/79] media: i2c: ov8865: use pm_runtime_resume_and_get() Date: Wed, 28 Apr 2021 16:52:14 +0200 Message-Id: X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: Mauro Carvalho Chehab To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") added pm_runtime_resume_and_get() in order to automatically handle dev->power.usage_count decrement on errors. Use the new API, in order to cleanup the error check logic. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/i2c/ov8865.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/ov8865.c b/drivers/media/i2c/ov8865.c index 9ecf180635ee..3bf6ee4898a9 100644 --- a/drivers/media/i2c/ov8865.c +++ b/drivers/media/i2c/ov8865.c @@ -2497,11 +2497,9 @@ static int ov8865_s_stream(struct v4l2_subdev *subdev, int enable) int ret; if (enable) { - ret = pm_runtime_get_sync(sensor->dev); - if (ret < 0) { - pm_runtime_put_noidle(sensor->dev); + ret = pm_runtime_resume_and_get(sensor->dev); + if (ret < 0) return ret; - } } mutex_lock(&sensor->mutex); -- 2.30.2