Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp621327pxy; Wed, 28 Apr 2021 10:38:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwvZDqIh0mK9MUXUDTm15Rv4XE+3wLe1a/fY5iHy8/qNrPnxl0LgZOU3324XQQbHC88J44k X-Received: by 2002:a05:6402:17fc:: with SMTP id t28mr12085775edy.283.1619631487663; Wed, 28 Apr 2021 10:38:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619631487; cv=none; d=google.com; s=arc-20160816; b=NfcYydECOWRdrT+Z0aY/ShphVaRq/8w6K78e+MRTPe8cxjc5BwF1auQNAgVz0u3aFC 02bygvGtuYU6OnbXBDTL20D4Z7w/nA9nKhN9FSbhJzf7TAW+deWgOp9iHOxQPEM/zOZz u4834HiA4BSkVi2pdWCpeMnYk+PAEuF9MmPlQpOO/Dd7UnlTno75DB0Jw431Pb1JW2sx /PMgzYXjUFIXgk4Mh6YXeu6ZJXPK0wkphVpOBEOo0D66FOd6FXJvoWTdt3CUuchxGNB6 BnGy68+1oRDiMxsqHCJBr3l5qtbv6qEgw4c/o95PJsXCVgpwc8CGWPxN3OWqnfpZDcH/ iqOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:from :dkim-signature; bh=dSOEoM10daHE4l7vWm5N/lgBLlAdUfkgG885M5nCQIs=; b=Ph32Zlvp/GWaDOSHcOk4Rleb7WkUgjN+b2/8m0aVDygevuYwFTcDzP/EY4TpXBUt8P ffZHGqJl+Nv6IPFUVNXyX2tS+kG0frEM3c3pepusyJDV+TlV57Hvs+dh6JaDH6afhAlS 6H39AV7CRn03mLiOb3i5czj6z9Z4nInUpzFsM2G/0MZHePLOvhcBEW1qQ95TkmeQkl3q ptV5ofHYqe8DXwpkkhD36IcEwTZyOADT0oKmjEckMF6C5quQj4EaX5ePTSVc9ldITNp1 +9LdzrF7hWCehJ5RlaO7XOJfBCAIarN544GRwIIExYmqMkc4GVJp0s4Y8ALAFXm71K60 Hfzg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@kernel.org header.s=k20201202 header.b=GT6O0nt4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s7si333830edq.258.2021.04.28.10.37.38; Wed, 28 Apr 2021 10:38:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@kernel.org header.s=k20201202 header.b=GT6O0nt4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239887AbhD1O7I (ORCPT + 99 others); Wed, 28 Apr 2021 10:59:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:36740 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240496AbhD1OyN (ORCPT ); Wed, 28 Apr 2021 10:54:13 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id EA0CA61474; Wed, 28 Apr 2021 14:52:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619621566; bh=6SWDMHkSlrYNzq7GtPd5DH9pbQJCAbHbxO2AKYAv8vU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GT6O0nt4qbLs0BXJSqPpmzUgFzklLqjIri1f2tLeoqZuz9LcJdWjB349S+TBP6WKU x8F1Pi5vVafuSn/nu3YrR4c2DQ4943anN6Ei7AUqvMUQ09vQpmifdYdz1eFuPrI+Ot yucgbpNM17yxhgdDybfXpo3tCCT+zFtDNGXiT3bxEgC534pZN7rx1TQ9CDMGc6iYJR 1CZhKgg+gaXMSiEmUQ3im6rBBLN9z7HIS5DOgIi7SxC79vCccGbCrGadww3JF5UZiF TB4jJccOGimPw4GYdlw7Rfwel62hO61K0eciKZx9Yml2SwcOnvrm2UHfnyXERaCjo3 t8xEn0gecBWRw== Received: by mail.kernel.org with local (Exim 4.94) (envelope-from ) id 1lblYQ-001DrQ-LG; Wed, 28 Apr 2021 16:52:42 +0200 From: Mauro Carvalho Chehab Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Mauro Carvalho Chehab , Bingbu Cao , Mauro Carvalho Chehab , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v4 38/79] media: i2c: imx319: use pm_runtime_resume_and_get() Date: Wed, 28 Apr 2021 16:51:59 +0200 Message-Id: <353715a6b23c075e43d4d21bb77bea6abb2d13da.1619621413.git.mchehab+huawei@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: Mauro Carvalho Chehab To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") added pm_runtime_resume_and_get() in order to automatically handle dev->power.usage_count decrement on errors. Use the new API, in order to cleanup the error check logic. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/i2c/imx319.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/imx319.c b/drivers/media/i2c/imx319.c index 38540323a156..4e0a8c9d271f 100644 --- a/drivers/media/i2c/imx319.c +++ b/drivers/media/i2c/imx319.c @@ -2141,11 +2141,9 @@ static int imx319_set_stream(struct v4l2_subdev *sd, int enable) } if (enable) { - ret = pm_runtime_get_sync(&client->dev); - if (ret < 0) { - pm_runtime_put_noidle(&client->dev); + ret = pm_runtime_resume_and_get(&client->dev); + if (ret < 0) goto err_unlock; - } /* * Apply default & customized values -- 2.30.2