Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp671049pxy; Wed, 28 Apr 2021 11:41:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxk/yQuXYrln1AueObIpOwnB0+zphQJPiS7RjQVrm2jjQ6XsshKn82E/Ew0B6CzgGH8Ecwk X-Received: by 2002:a17:902:6b0a:b029:ec:9899:6a2 with SMTP id o10-20020a1709026b0ab02900ec989906a2mr31356461plk.31.1619635317562; Wed, 28 Apr 2021 11:41:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619635317; cv=none; d=google.com; s=arc-20160816; b=SxqJWroa3H3816QmgpqEU2iEQ4v76D565ryeKKngUkov1RBSwJpsG4god194hwkFFq 7LnfdDUZYqOz3MLDLs6l6rUPNt4SlG6wBc9DVn59OeBpb12WLOA+QC48Sp/qEJICmti0 bbl2Vg9FP7d6V0p05hFfdJ4D8tuzdizRPcSv1VyvJep+WWDmmbYQRiagRVzXE0MDDgzt vZxVMqh7MLiyhJNW+M0bKDg+8R7uL0bgVAE4l2bDLqPi7jZ4YL4oFe9kIrjTpZwNBH+Z YYsc5A85mUNZYL8Q94/M/o4ACqPkYn7wt6GVxCZxnWVDETgi5Vq/n3FXM/9vtzXmvWEL Qf4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:from :dkim-signature; bh=1++ipKYspVVkHWV8NBkwkiZMnEbLSuRUdF0D66oNe2s=; b=m1m28BGKM2jIugPIGRhseY1ZP9pcrKvlOr0Ecn6pX4zkvAm3tYK+dNiRzlbquvjxq7 hHBs+aIOFjtk9Hy7i6O3Kp9odXaWDTatoqGd031CXiAC6jRLoSUOgfF4Vyt5sflrlp3x RQT7zwpcdfudlaVW2e97KvxgmmaP+dnqt4gzJufyOgVnsWYkbNePpff4vMZ1jWu2e6GO N4sFdcUvktizjV7vZBywXO9OAVI8ygOCnOAMR9FITb9qX9HYA7Ni3nbxeuiye6ENUhqC qDS3q9a6NdN7iQvBspYY+9z7IXN9JcZaiLqmtteEL4D7MnQBLjxj0my1sNmldbSDQmbL xi0Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@kernel.org header.s=k20201202 header.b=oSFD5gjj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ng6si560596pjb.85.2021.04.28.11.41.44; Wed, 28 Apr 2021 11:41:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@kernel.org header.s=k20201202 header.b=oSFD5gjj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240593AbhD1Oyv (ORCPT + 99 others); Wed, 28 Apr 2021 10:54:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:36366 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240292AbhD1Oxa (ORCPT ); Wed, 28 Apr 2021 10:53:30 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 104BD61482; Wed, 28 Apr 2021 14:52:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619621564; bh=kZnJ3c5lxpnyMUPcou0x/B7YpZdYmZe9W/fJf9NvZfI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oSFD5gjj1UhSA5WJUYg4n0cCSF6kFkwx1Z8v9LX72qbiifLtfs4O1M80mPTmB3eiD 1Z3J6u++rlX0YrXAOv52opoAPVUF8J+4HEipvqGNBiUUP9+sRWU+o5F6usoKHSmFN3 cw7tzFyLyyXm0tbSNHbbrYXx6bp77puSsAxEskJJbQiaGlFvfthvfT2F2fZPAbuVuZ hR4kRBVabfZyU1ygSCPEgS/ehEcYcOWjh/j4SrJb/vQpr/uvfzRu+ku5zpoc3/2S4H MdaO1KxTiCxV9v3hblGbNnAwcEBnkLskuGC7XS5upffVde2RDJy9RoRGsbxw1N1uNw 70d/68RpzcNVQ== Received: by mail.kernel.org with local (Exim 4.94) (envelope-from ) id 1lblYQ-001DqP-1s; Wed, 28 Apr 2021 16:52:42 +0200 From: Mauro Carvalho Chehab Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Mauro Carvalho Chehab , Andrzej Pietrasiewicz , Jacek Anaszewski , Mauro Carvalho Chehab , Sylwester Nawrocki , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v4 17/79] media: s5p-jpeg: fix pm_runtime_get_sync() usage count Date: Wed, 28 Apr 2021 16:51:38 +0200 Message-Id: <83a1f7979382d5d5c44964baae819589c94d80c2.1619621413.git.mchehab+huawei@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: Mauro Carvalho Chehab To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The pm_runtime_get_sync() internally increments the dev->power.usage_count without decrementing it, even on errors. Replace it by the new pm_runtime_resume_and_get(), introduced by: commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") in order to properly decrement the usage counter and avoid memory leaks. Reviewed-by: Sylwester Nawrocki Acked-by: Andrzej Pietrasiewicz Signed-off-by: Mauro Carvalho Chehab --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/s5p-jpeg/jpeg-core.c b/drivers/media/platform/s5p-jpeg/jpeg-core.c index 026111505f5a..c4f19418a460 100644 --- a/drivers/media/platform/s5p-jpeg/jpeg-core.c +++ b/drivers/media/platform/s5p-jpeg/jpeg-core.c @@ -2568,7 +2568,7 @@ static int s5p_jpeg_start_streaming(struct vb2_queue *q, unsigned int count) struct s5p_jpeg_ctx *ctx = vb2_get_drv_priv(q); int ret; - ret = pm_runtime_get_sync(ctx->jpeg->dev); + ret = pm_runtime_resume_and_get(ctx->jpeg->dev); return ret > 0 ? 0 : ret; } -- 2.30.2