Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp765724pxy; Wed, 28 Apr 2021 13:50:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxjoq3+UD39EDv6qnJ9GfW2SDyaabylJdG0zOVR+CbP3owqP4ch8ttqYDNswphLHIe9R12H X-Received: by 2002:aa7:cf07:: with SMTP id a7mr10505665edy.261.1619643018075; Wed, 28 Apr 2021 13:50:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619643018; cv=none; d=google.com; s=arc-20160816; b=cPqlnbQ/5wpjXIOvGW6MtXoPJmMEkKG/mPBmtlOfkQvfdkq99GyzA9HL1MjjO/G1Dq pGr9hw4fd3JfoFDeKY4znl2p2Ze8OII+o6f3fna1jDcprgtA+b70TMIb9DfCsE8DM36Q xZvrhQouNZYf/5U2LrvcPUQ8bXeGzjoXzeFlaKV5oqyKb1QIXgfDqX2kWOApK2gvG4hr S7B1jIOsjE1BZ2LBgWaIWED0ePEtReXibjh1IGMmuSmdqnMNy2//j06+WFMaU23pvQTh ma3ewOGEwQL6kP1ranw7PlPAU1J5f2fZ99raJ2RcRbrrME6d+0bDZRWxx7/sIbCDiEHL lTVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id:dkim-signature; bh=9sQOg2djYqFyyvZ+XRPCZzW7QjwnUE+n/y705XB+4KU=; b=FirEuZr/4pTRHBIBRE2g3MP+VPpRgh+IUiviPDTBcICiU7Tka+AP+hglQpCruoEpQ5 C3iKdWOIqtLJDlzlG67dJsiOM+K8+5P3Z7gjEhjnzZvYMDvtKS2BKZ9kbILU7lBtUQWT q7a7v3Jfb8fMtvJVkzU03PCQWj0PdY66JD6HsJrxyTobgsZz+ikLNYY7tUBpT+sIo6if 3TJfhS/QBAaRcpE9xU2Z5UuosIFhLmB+B773zsqWn7aJumToGm9ZgPOjhcadP8DeT2eX cuh7IMRHyfOH9qd+wqmjJeQOEhv8rDgJFahNRzcMhHZLhWbcJvn9dqA3tNIowKueHXiD iiDw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=OT9RIuYm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bm15si790042edb.233.2021.04.28.13.49.54; Wed, 28 Apr 2021 13:50:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=OT9RIuYm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236545AbhD1QNk (ORCPT + 99 others); Wed, 28 Apr 2021 12:13:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57008 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229961AbhD1QNf (ORCPT ); Wed, 28 Apr 2021 12:13:35 -0400 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 484DEC061573; Wed, 28 Apr 2021 09:12:50 -0700 (PDT) Received: by mail-wr1-x42b.google.com with SMTP id t18so6081371wry.1; Wed, 28 Apr 2021 09:12:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=9sQOg2djYqFyyvZ+XRPCZzW7QjwnUE+n/y705XB+4KU=; b=OT9RIuYm+aabyzcOmaIYB1vZmez4cppddKZ7Ayy1I/WCN7lMtjqQMLGAf5Rx0HGge5 g59UN1CtU1VNFOTDdoZo8JN5560267VMC3cMpU/YqDzkC8telFGP319YlbQ6CnyTC1FA D72jN9L0NMCcbUWCg4xlLH1DltT7Y6LEt9YnE2edPXkBymFoaZCq6/h24BGkg9Rn9sEZ 0n83OR+QgMgj9aeicOIO+p/nVVyXxSJoB2tlZBZtProESTB7Vwe+aYeDhf6Zv7vQSwRs Z98rNu5LiJo4gzW5z0N+t3RYU7AioWDuaML58L8KfodbOQ7uxBBlVwO2Ur6go2KyX2vH XkIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=9sQOg2djYqFyyvZ+XRPCZzW7QjwnUE+n/y705XB+4KU=; b=HExP1pjfTSEE8xW+C4mQPil5RrNHtsgRLiuym6Ed0beEL78qADLlFaZmtVlm/T/56B lDypHbRauugycHZfV20/Y1DEmcGIe6YKBryrLvNhTY7PHIIaIRjee12czdN/zLcCV4YD WVSEakLQ4hdEjmhSVKs7tp6Zrzkm1yKQJAgkuPLzHQN8C/yubJI4zJMOO3d0axK8YDIt 2qGmE73kVPvMT34bA5xVRDwf8mEkclFiiHcj6slmaaGB3euAm9X3Sx+XjgLn2KFvBh8p bJD01SUXMO0FFScm4zRkCed6WsKHYrA8kR9VAbkeEmgztfrq6iw79LV01GGbQQVNHAYP BFeA== X-Gm-Message-State: AOAM531MRIS/Jnf82hMiCOovnIA1b4fK08eQm/CneEAIE4oyzt/WUMwj 55CVVOPeJTIHsrfv7DBUZDE= X-Received: by 2002:a5d:654c:: with SMTP id z12mr37123433wrv.12.1619626369046; Wed, 28 Apr 2021 09:12:49 -0700 (PDT) Received: from 192.168.10.5 ([39.46.118.120]) by smtp.gmail.com with ESMTPSA id l14sm228211wrv.94.2021.04.28.09.12.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Apr 2021 09:12:48 -0700 (PDT) Message-ID: <8e81d6a32408f172a6ab4ebf68eee760444d9666.camel@gmail.com> Subject: Re: [PATCH v2] cifs: remove unnecessary copies of tcon->crfid.fid From: Muhammad Usama Anjum To: Steve French , =?ISO-8859-1?Q?Aur=E9lien?= Aptel Cc: musamaanjum@gmail.com, Steve French , Ronnie Sahlberg , "open list:COMMON INTERNET FILE SYSTEM CLIENT (CIFS)" , open list , kernel-janitors , Dan Carpenter , Colin King Date: Wed, 28 Apr 2021 21:12:43 +0500 In-Reply-To: References: <20210415152409.GA2286719@LEGION> <8735vp18su.fsf@suse.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.4-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2021-04-19 at 18:39 -0500, Steve French wrote: > I changed the comment to > > + /* > + * See commit 2f94a3125b87. Increment the refcount when we > + * get a lease for root, release it if lease break occurs > + */ > > and added Aurelien's Reviewed-by. Let me know if you see any > additional problems. > Thank you so much!