Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 28 Apr 2021 19:38:44 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Fenglin Wu <fenglinw@codeaurora.org>
Cc:     linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
        Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= 
        <u.kleine-koenig@pengutronix.de>, Lee Jones <lee.jones@linaro.org>,
        Rob Herring <robh+dt@kernel.org>, linux-pwm@vger.kernel.org,
        devicetree@vger.kernel.org, subbaram@codeaurora.org,
        collinsd@codeaurora.org, aghayal@codeaurora.org
Subject: Re: [PATCH 1/2] dt-bindings: pwm: add bindings for PWM modules
 inside QCOM PMICs
Message-ID: <YImdpBE+8LIu9rIq@orome.fritz.box>
References: <20210427102247.822-1-fenglinw@codeaurora.org>
 <20210427102247.822-2-fenglinw@codeaurora.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="Rl6xxuSZCAayz1wt"
Content-Disposition: inline
In-Reply-To: <20210427102247.822-2-fenglinw@codeaurora.org>
User-Agent: Mutt/2.0.6 (98f8cb83) (2021-03-06)
Precedence: bulk


--Rl6xxuSZCAayz1wt
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 27, 2021 at 06:22:09PM +0800, Fenglin Wu wrote:
> Add bindings for QCOM PMIC PWM modules which are accessed through SPMI
> bus.
>=20
> Signed-off-by: Fenglin Wu <fenglinw@codeaurora.org>
> ---
>  .../devicetree/bindings/pwm/pwm-qcom.yaml          | 51 ++++++++++++++++=
++++++
>  1 file changed, 51 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/pwm/pwm-qcom.yaml
>=20
> diff --git a/Documentation/devicetree/bindings/pwm/pwm-qcom.yaml b/Docume=
ntation/devicetree/bindings/pwm/pwm-qcom.yaml
> new file mode 100644
> index 0000000..e8d8ed6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pwm/pwm-qcom.yaml
> @@ -0,0 +1,51 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/pwm/pwm-qcom.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm Technologies, Inc. PMIC PWM bindings
> +
> +maintainers:
> +  - Fenglin Wu <fenglinw@codeaurora.org>
> +
> +description:
> +  PWM modules inside Qualcomm Technologies, Inc. PMICs can be accessed t=
hrough
> +  SPMI bus and normally one PMIC would have multiple PWM modules with ad=
jacent
> +  SPMI address space.
> +
> +Properties:
> +  compatible:
> +    const: qcom,pwm

This seems a bit vague. What if Qualcomm ever designs a different PWM?
How are you going to tell them apart? Typically this would include some
sort of ID for the SoC family, or the first SoC that this was introduced
on. That way you can more easily distinguish between different designs
later on.

> +
> +  reg:
> +    description:
> +      The SPMI address base of the PWM module, if there are multiple PWM
> +      modules present with adjacent SPMI address space, only need to spe=
cify
> +      the address base of the 1st PWM module.

That seems like an odd way to define these. It looks like this is a bus
with #address-cells =3D <1> and #size-cells =3D <0>. Such busses are usually
assumed to have a single address per device (see for example I2C). How
does the SPMI addressing work? Is there a specification somewhere?

Actually, Documentation/devicetree/bindings/spmi/spmi.yaml says that
SPMI child devices should have two address cells, so this seesm to be at
odds with that specification.

Thierry

--Rl6xxuSZCAayz1wt
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmCJnaIACgkQ3SOs138+
s6FgmQ//VuVwjokE9jtiAEimFWqqanQrH1hywO01eTDIxCdIo7U+KPepZb4d90bp
/+MbVGE8IKcwbFV+a00v9PP0vEzeJR8hpGTxt1k52M/ht/lTfc5iS8UAapTISlZR
9keuykMewiBvZSzdkTcv+2Q4wsH8JTKud2t4coeMTT8AVEoutHBc12eke7rui4SH
373cBqMp2JLrMtz9oWYp1bFXUDluqthaSWWjzvb71Y7wFk7LUE2Md7swgEmo97zo
D6dUiX4khZ6H3Do/cvTIAf4V4yROvZDecPq17AZsi/Zun1JBG4KkJkInz8536tV0
qJ3Iv8YgrqJ9f0rqZQq/1jW+NQj9PE/jYph4HqJzVH3M7VHYvlrkiUbxxl8BkSDm
i6D5Sfi+i2GKa7cWg7HMO9NRaME6jArFADsT50DYAbbk7JjonccNmpR5lfqPC3Wl
kM7nA0ldAzXIv7EgCwtkc50XKD3J6HLx5T87YHurZpAPhH6D54Xf7Fto8UQjyHxF
sXsAhxG0xxJZl1ZdXD9kTn4OjE1OwPafCILlmihX/ynsrbg+ahvR4xMbvhO6weDl
QubqdgDjXu4+L5pPQ9LrO4rWRdrwAfUItKm9VEb2/7945hQPtrEaAJMwpZBT9lja
LKtFqt1qCkiAF4GNwgeLb00Dq4MSAyVOkxNitNcT/KhT4ec+kus=
=UZeF
-----END PGP SIGNATURE-----

--Rl6xxuSZCAayz1wt--