Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 28 Apr 2021 18:40:10 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Catalin Marinas <catalin.marinas@arm.com>
Cc:     Bill Wendling <morbo@google.com>, Kees Cook <keescook@google.com>,
        Ard Biesheuvel <ardb@kernel.org>,
        Will Deacon <will@kernel.org>, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        Szabolcs Nagy <szabolcs.nagy@arm.com>,
        Daniel Kiss <Daniel.Kiss@arm.com>
Subject: Re: [PATCH] arm64/vdso: Discard .note.gnu.property sections in vDSO
Message-ID: <20210428174010.GA4593@sirena.org.uk>
References: <20210423205159.830854-1-morbo@google.com>
 <20210428172847.GC4022@arm.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="HcAYCG3uE/tztfnV"
Content-Disposition: inline
In-Reply-To: <20210428172847.GC4022@arm.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk


--HcAYCG3uE/tztfnV
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Apr 28, 2021 at 06:28:47PM +0100, Catalin Marinas wrote:
> On Fri, Apr 23, 2021 at 01:51:59PM -0700, Bill Wendling wrote:

> > Since the note.gnu.property section in the vDSO is not checked by the
> > dynamic linker, discard the .note.gnu.property sections in the vDSO.

> Can we not instead fix the linker script to preserve the
> .note.gnu.property, correctly aligned? It doesn't take much space and
> while we don't use it now, it has the BTI information about the binary.

> Cc'ing a few others who were involved in the BTI support.

Not just BTI, we also flag PAC usage in there too and could add other
extensions going forwards.  While the note isn't actively used by
anything right now due to the kernel mapping the vDSO prior to userspace
starting it is part of the ABI and something could end up wanting to use
it and getting confused if it's not there.  It would be much better to
fix the alignment issue.

--HcAYCG3uE/tztfnV
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmCJnfkACgkQJNaLcl1U
h9AMeQf+JjCPE1mknCrwwNnvPnXcUenU0DeOnChJJgTGhQGIe4ovug+jvSsiDRvp
GKEOeeNYh3E2iABmqi46Ysc2bcVnzsivqsjXnlMGQP857+jnMgwh3lktKmQueL8P
XgEHWN4fT2k6+tPbREAUVkYqBHWz3VhKXNt44qEw0Byn3WchMMBfuX7HkN6H6CzR
60nUXcfnyX4u51TMrefOlakdvAOV21g2Qy37DuLjSGS9A2M/ojsEKQzDbWqG88t7
ZU/FGiybkObxq0DPXJtzVXU5JxYVeRprwdHuyx6jHLGd5v9M/x6TAzMRx6i6KrhS
kpuM+XkFWP1W7DlH2ECcQ9UY6E/qTg==
=1KEY
-----END PGP SIGNATURE-----

--HcAYCG3uE/tztfnV--