Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp768193pxy; Wed, 28 Apr 2021 13:53:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxdCMUy14ATyXnzu3diVU3rC7slEGKmaSXTSNT2ZHWeKYnw4CPql9WTtLgMh7yZBm6bzisW X-Received: by 2002:aa7:d594:: with SMTP id r20mr5546203edq.242.1619643235580; Wed, 28 Apr 2021 13:53:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619643235; cv=none; d=google.com; s=arc-20160816; b=k2pWfE6Zq6LMfIZtnm3MXd+3g8HDNBlcBorwN1SDmEUn6BYx0e2cgZsFKhyLZmJPIy qzFW7wYJkgLz550kY32EvO3608EaU3wgpOuHG5NHJCXeXBSI4vQSISbX9E61qfV9MdB4 fAyBLZ0sNwBeScOUuAWJ+1SGfnv/PHBFYgQOTEWGEB98CYXH6rb8ayQf4RQbRtIVJaXs r9KhF6FQuoswE7htNxlY6qyM9vb8IUV1DliGtbFsGYsiLn8XnJPpz7Cm0h+gN8j+HytF ixgJuOwu6k1JfpU7j0GBPGE+/a4Q/L7yyrHyfxY6l5oM8Kmind1QhvB3e45SZQ9bnNeD KXTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=qTwMGOArgfdkMLgBspx25AjS80QLDYquAELPhqhjNQQ=; b=poEDnsJsQVg8VecPO6oTnq6Comeh2+KVyYb7Wr5W8bW6tSFBTxvhMhw5+D1t1paERt SUEwl2RVtdGH7esHtFjtGTNmoNjhfyJHN+gRo65xKuatfnzHPWDXJLu29jbeeq/MGASH S5jw2vjkf7fQXvTd82nO/elGRwLel9jUk/9zyfGTJzJOO7Y6Jph4jki0I+5sdSTd3l79 lhBXDYEVgsT0Y5JuIjDSNl/3r8gEbz2CmjjWNHKycBuGAEGC1/UKwwANjLXkQCJvAKwd FNuTmYMaRzUM5t0oz28+JYq2R8Bce6yT0qek08m0nAr9vl2g7sQAuPLW47uLu7a4nV/B 6pWQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=CfqfDaxI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y22si1202696ejo.76.2021.04.28.13.53.32; Wed, 28 Apr 2021 13:53:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=CfqfDaxI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243446AbhD1SH5 (ORCPT + 99 others); Wed, 28 Apr 2021 14:07:57 -0400 Received: from msg-1.mailo.com ([213.182.54.11]:35256 "EHLO msg-1.mailo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243398AbhD1SHt (ORCPT ); Wed, 28 Apr 2021 14:07:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1619633216; bh=+c5igyr8ENA48LJUJ/MMslL7XQZTgfJo1NBswH6SmIo=; h=X-EA-Auth:Date:From:To:Cc:Subject:Message-ID:References: MIME-Version:Content-Type:In-Reply-To; b=CfqfDaxIVm/aoCteFsNNFRU4sUSTJEjh1RH4MLgp4aGZ7bSIJ84MHXW54ko3gb2Vf alfIm74EcGAjv9UPm63zSw+TYahJ34Ofr+/N4we9/1Ef1eoHeKWAKJzx8V2jX4nB1t M04fIU3PD0dUQxNVlSRaxGYdsnCFpal7UhporQD8= Received: by 192.168.90.11 [192.168.90.11] with ESMTP via ip-206.mailobj.net [213.182.55.206] Wed, 28 Apr 2021 20:06:56 +0200 (CEST) X-EA-Auth: +kU11S5f0ZcelkzG3a+GaSCjPWDesBvh4IV8IbrpdtwTS/md0f6X9qSiFEPSj1t9kFxuweCmS3pFKVyLFfvSYS5fAdVjnvdN Date: Wed, 28 Apr 2021 23:36:50 +0530 From: Deepak R Varma To: Mauro Carvalho Chehab , Sakari Ailus , Greg Kroah-Hartman Cc: linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, drv@mailo.com Subject: [PATCH v4 3/9] staging: media: atomisp: remove unnecessary braces Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org According to the coding style guidelines, if...else blocks with single instructions do not need enclosing braces. This resolves checkpatch WARNING / CHECK complaints. Signed-off-by: Deepak R Varma --- Changes since v3: - introduced. Changes since v2: - None. Changes since v1: - None. drivers/staging/media/atomisp/i2c/atomisp-ov2680.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c b/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c index c90730513438..f167781e258a 100644 --- a/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c +++ b/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c @@ -461,11 +461,11 @@ static int ov2680_v_flip(struct v4l2_subdev *sd, s32 value) ret = ov2680_read_reg(client, 1, OV2680_FLIP_REG, &val); if (ret) return ret; - if (value) { + if (value) val |= OV2680_FLIP_MIRROR_BIT_ENABLE; - } else { + else val &= ~OV2680_FLIP_MIRROR_BIT_ENABLE; - } + ret = ov2680_write_reg(client, 1, OV2680_FLIP_REG, val); if (ret) -- 2.31.1