Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [RFC PATCH v2 3/3] sched/doc: Update the CPU capacity asymmetry
 bits
To:     Beata Michalska <beata.michalska@arm.com>,
        linux-kernel@vger.kernel.org
Cc:     peterz@infradead.org, mingo@redhat.com, juri.lelli@redhat.com,
        vincent.guittot@linaro.org, valentin.schneider@arm.com,
        dietmar.eggemann@arm.com, corbet@lwn.net, linux-doc@vger.kernel.org
References: <1619602363-1305-1-git-send-email-beata.michalska@arm.com>
 <1619602363-1305-4-git-send-email-beata.michalska@arm.com>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <79223641-6b3e-6b48-50df-3a9c73c003cd@infradead.org>
Date:   Wed, 28 Apr 2021 10:19:10 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.0
MIME-Version: 1.0
In-Reply-To: <1619602363-1305-4-git-send-email-beata.michalska@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 4/28/21 2:32 AM, Beata Michalska wrote:
> Update the documentation bits referring to capacity aware scheduling
> with regards to newly introduced SD_ASYM_CPUCAPACITY_FULL shed_domain

                                                            sched_domain
I guess.

> flag.
> 
> Signed-off-by: Beata Michalska <beata.michalska@arm.com>
> ---
>  Documentation/scheduler/sched-capacity.rst | 6 ++++--
>  Documentation/scheduler/sched-energy.rst   | 2 +-
>  2 files changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/scheduler/sched-capacity.rst b/Documentation/scheduler/sched-capacity.rst
> index 9b7cbe4..92d16e7 100644
> --- a/Documentation/scheduler/sched-capacity.rst
> +++ b/Documentation/scheduler/sched-capacity.rst
> @@ -284,8 +284,10 @@ whether the system exhibits asymmetric CPU capacities. Should that be the
>  case:
>  
>  - The sched_asym_cpucapacity static key will be enabled.
> -- The SD_ASYM_CPUCAPACITY flag will be set at the lowest sched_domain level that
> -  spans all unique CPU capacity values.
> +- The SD_ASYM_CPUCAPACITY_FULL flag will be set at the lowest sched_domain
> +  level that spans all unique CPU capacity values.
> +- The SD_ASYM_CPUCAPACITY flag will be set for any sched_domain that spans
> +  cpus with any range of asymmetry.

     CPUs
please.

>  
>  The sched_asym_cpucapacity static key is intended to guard sections of code that
>  cater to asymmetric CPU capacity systems. Do note however that said key is
> diff --git a/Documentation/scheduler/sched-energy.rst b/Documentation/scheduler/sched-energy.rst
> index afe02d3..8fbce5e 100644
> --- a/Documentation/scheduler/sched-energy.rst
> +++ b/Documentation/scheduler/sched-energy.rst
> @@ -328,7 +328,7 @@ section lists these dependencies and provides hints as to how they can be met.
>  
>  As mentioned in the introduction, EAS is only supported on platforms with
>  asymmetric CPU topologies for now. This requirement is checked at run-time by
> -looking for the presence of the SD_ASYM_CPUCAPACITY flag when the scheduling
> +looking for the presence of the SD_ASYM_CPUCAPACITY_FULL flag when the scheduling
>  domains are built.
>  
>  See Documentation/scheduler/sched-capacity.rst for requirements to be met for this
> 

thanks.
-- 
~Randy