Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp769001pxy; Wed, 28 Apr 2021 13:54:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyGnqUy/5l0KGjtvaul9TC/yDDAR+vDp7Y5s4PV42Yr0zRADh4SS3UyiFX5s8yix4ZJNDgs X-Received: by 2002:a17:906:cb11:: with SMTP id lk17mr31511104ejb.517.1619643294060; Wed, 28 Apr 2021 13:54:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619643294; cv=none; d=google.com; s=arc-20160816; b=w5m5SRRQojdUzMhMtdm64D1xW/Ym6oMd7Zf67PDZlaVnxT3g15ZKAbdCvEX83p8WIp emFqKwIjOWboSNNR07r+WXO3NCUdHvwxJfUZihnMoiCtZGjDHG4RASMQVRXRK+OoLboU bknkOmGeUdr795TYKE+Q4eKsDjot+/VDpXdjttrIKy+p3jK2qLR4pmeB62xjOAVAnnCC 4vNmYdQRAU70LclNWzmrnggyBNa6fuNVWBgz9joji26T7793DSzYQp6xccaRRHU+5lGN 0EF9FTv5z20VyqX14squljc8Is2onRM19wgmo+yniqvky2IEpJ/w/Qjmm8vLtIv0f+tT q3rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=8+2OtwHWU/tw8LyuKCnydCIMPp36fg2I7h1qBJBeASE=; b=TCRMR5KkA58NMrRoDVE23rvITkgGGeq0K79rUz3wuUMUsF2cqIYVzNvnUK/SbgCGQp +/5esjzAk4LOICYsnCYvjfIPz5S9KJaLcaIZPbdXZ/F8KLjPEgsEOWWAoMIES50oDzmc ftT1QZwAFZFNmCYE4BFIsALL0EJM11Ypo9ZQJ1BJ5YXp7tg30VH+Z/jyCmOaahs7sB/w wSIp88Eb55/clp68TLLnv1EBqA/CkNlUwJemvy3/IvL1o6nVzJxSmhC2lDUqLxo/Rdlj 7/ZLHv48r1PD2Ig6pwVHiEgpmiP5KYwZo3DbPkkyQvCX9sdt4xC56at4AaSq3NG7/owp vR2Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gKJmJvCd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id kg22si416687ejc.723.2021.04.28.13.54.30; Wed, 28 Apr 2021 13:54:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gKJmJvCd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243599AbhD1TOh (ORCPT + 99 others); Wed, 28 Apr 2021 15:14:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:33684 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232310AbhD1TOg (ORCPT ); Wed, 28 Apr 2021 15:14:36 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1A6E6613F1; Wed, 28 Apr 2021 19:13:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619637231; bh=tT66t63JdIpz5yQPVhQuv9m4JujetKOEC9l42sV1tMo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=gKJmJvCd/7xSOjayOgxjgKRuPikxnm25lQlzziciFQZALjJ2l7UIp6LQVe611ruzv SlFxm4DRSB0yL27OJCHGHItTEkE9Q28VCTxXZZuzV3WXLNQ74JG+7Rkag2QdAO0kDS nmV1nRxKbv/ExLd/6HTNg3LOTJ2mQjTugQtJMSqU5rpwjotlLbdKnmkwqHLDnN9nfb kw32jnw3m+MW7H7Wwh53EPlJt3uQiPccIxhwM2pnPNN0hSwzAeOBkxlKHOTbMsDevD 7d42YayW0q3SEUfa31+IDN7o6ml1R3du+MWDAsU+5ZfJca7P3vp9qEcmDnBfMRog4X 43vncnfASWyGA== Date: Wed, 28 Apr 2021 12:13:50 -0700 From: Jakub Kicinski To: Jiapeng Chong Cc: simon.horman@netronome.com, davem@davemloft.net, oss-drivers@netronome.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] nfp: flower: Remove redundant assignment to mask Message-ID: <20210428121350.20d10dcf@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <1619604330-122462-1-git-send-email-jiapeng.chong@linux.alibaba.com> References: <1619604330-122462-1-git-send-email-jiapeng.chong@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 28 Apr 2021 18:05:30 +0800 Jiapeng Chong wrote: > The value stored to mask in the calculations this patch removes is > not used, so the calculation and the assignment can be removed. > > Cleans up the following clang-analyzer warning: > > drivers/net/ethernet/netronome/nfp/flower/offload.c:1230:3: warning: > Value stored to 'mask' is never read > [clang-analyzer-deadcode.DeadStores]. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong Seems cleaner to always move ext and mask, in case some code is added later in the function and starts accessing mask.