Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 29 Apr 2021 01:09:01 +0530
From:   Anupama K Patil <anupamakpatil123@gmail.com>
To:     Jaroslav Kysela <perex@perex.cz>,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
        linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
        B K Karthik <bkkarthik@pesu.pes.edu>
Subject: [PATCH v2] drivers: pnp: proc.c: Removed unnecessary variables
Message-ID: <20210428193901.rqs64di4g2svpaeg@ubuntu>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="wpqdbbx7thmklwzk"
Content-Disposition: inline
Precedence: bulk


--wpqdbbx7thmklwzk
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

de, e are two variables of the type 'struct proc_dir_entry'
which can be removed to save memory. This also fixes a coding style
issue reported by checkpatch where we are suggested to make assignment
outside the if statement.

Reviewed-by: Jaroslav Kysela <perex@perex.cz>
Signed-off-by: Anupama K Patil <anupamakpatil123@gmail.com>
---
v2: Added Reviewed-by: tag

 drivers/pnp/isapnp/proc.c | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/drivers/pnp/isapnp/proc.c b/drivers/pnp/isapnp/proc.c
index 785a796430fa..1ae458c02656 100644
--- a/drivers/pnp/isapnp/proc.c
+++ b/drivers/pnp/isapnp/proc.c
@@ -57,21 +57,20 @@ static const struct proc_ops isapnp_proc_bus_proc_ops =
=3D {
 static int isapnp_proc_attach_device(struct pnp_dev *dev)
 {
 	struct pnp_card *bus =3D dev->card;
-	struct proc_dir_entry *de, *e;
 	char name[16];
=20
-	if (!(de =3D bus->procdir)) {
+	if (!bus->procdir) {
 		sprintf(name, "%02x", bus->number);
-		de =3D bus->procdir =3D proc_mkdir(name, isapnp_proc_bus_dir);
-		if (!de)
+		bus->procdir =3D proc_mkdir(name, isapnp_proc_bus_dir);
+		if (!bus->procdir)
 			return -ENOMEM;
 	}
 	sprintf(name, "%02x", dev->number);
-	e =3D dev->procent =3D proc_create_data(name, S_IFREG | S_IRUGO, de,
+	dev->procent =3D proc_create_data(name, S_IFREG | S_IRUGO, bus->procdir,
 					    &isapnp_proc_bus_proc_ops, dev);
-	if (!e)
+	if (!dev->procent)
 		return -ENOMEM;
-	proc_set_size(e, 256);
+	proc_set_size(dev->procent, 256);
 	return 0;
 }
=20
--=20
2.25.1


--wpqdbbx7thmklwzk
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQGzBAEBCgAdFiEEDSQZGCDcREXgcOjQtGmOOZV75b4FAmCJudUACgkQtGmOOZV7
5b7ZGQv+OsD9HAhDMBbsq6Ute4rDohSUul6M4rW7LUnq+WnRUnvrNCr2LmgavQCT
2t6y8PDlb2lREPK3/I8bbIky5uX5d+/sC83qNpoKzhvYbepC/fptg/33OFIe3hbR
gbPrRmkDkqM8yhE/fOkQYSLGBnvFSzjSulh3VhcQlLkLsG5MmOHFzuyMsO0ANp58
0JzH181yuYUF9A+Q7+xoizF570q4Q9vmi88N5u7TEey3JLOwqMa9bu0ynGYHpzIn
DLFMfpZQNsOLX6Fy/mztzx0FZLb8H9xoHv7g0ypQExfIA/BPWcpPjs88AC0lhgTL
QxquiBbR6s37zM4ktMjwxOzu1bCHJK0SdmkXxWi1hlFuylxaDMbZI4tjfNjq3KsC
FZRuD31uKt7XQ/Q+8UZwoq2Bo4M3KIU8LaPy238Ef5p9L6QKS56+DKiu/LCEMCSV
6g8ASBxTB7mg3sxJiumP+xe9KKYEGETfwqLyC1hJ5cDvTtGvMkBS4glM0X8Dp3W5
fbekUmGL
=csKr
-----END PGP SIGNATURE-----

--wpqdbbx7thmklwzk--