Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp771457pxy; Wed, 28 Apr 2021 13:58:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw0MdfScawjfjPkLnQb5FgadwajlvcV8jtbrLAb6Kkm8Ve4SSRp2UfbXioV96XEsRLDXPE8 X-Received: by 2002:aa7:c810:: with SMTP id a16mr13799996edt.280.1619643482369; Wed, 28 Apr 2021 13:58:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619643482; cv=none; d=google.com; s=arc-20160816; b=vXYHbKCBvB85L8tOn/e1WXQJBzHyxZajfTSgdQasf2sQ8+ZfRvNRkYp5uByXGS0iFF OhgAc6YJ839acsx+5TRNc27SiyqWKYfYqqcRfS7wmbu2wjNYDVf8ZCCUldLIlZTgEWB8 RXa0LfiJDW7PZa5c9f0X4NZxp8bk/0RmjLn47mdh1U96OeHtMBB15oo+ITrneG2AKTbI 7egWH2bm5D3SOoMGONhqOctH1vHDLJXgYmOaC6qBRHpd880JXwGLG/IqdnO0azl90ump E8UT/FTqzYDpdo1nJ23tDdKX/v9ZV4qTeSizrpcP4x4aAS+KbKavAN/lXMbFAk5pWxLe OkGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=zX+hK2XOLgRiQ/qjPvLplrcpep/+GXekqfv3v8DoP8Y=; b=pDp86iH4OohBcII/O6F40ZGADAvbl/q9cpMIk9OuPeoZ+bUSVUYKmVKGMUg9feiE20 ARJNGHAYRkOo3auqaIQwVxcMFdFS3PqZ/v/++1k1i6Lbwms4Vuw7EgfFpECdvW6xSgVG aEJ5jVoRJVCsaTG/fb5oG5ySH843yhWwyXg9mkOC8Pn1iMTHL2XrBvEKFOgHUmfDlCsN I0EWh1gdX960ndrMlxmuF2aCmyfqOeLI5y8ht1I6NHiel52q8lK0xKDpP6gA9mUuuCaq YPJr0M/BPS7HI9GA8e1dGP7Le6gvgbbnVptJ+MmVFqeNL8uYvSvxy35hlPeW+t6Ie16W 3CQA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=eznfVr2r; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z13si883473edc.6.2021.04.28.13.57.39; Wed, 28 Apr 2021 13:58:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=eznfVr2r; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235287AbhD1Ujt (ORCPT + 99 others); Wed, 28 Apr 2021 16:39:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234904AbhD1Ujr (ORCPT ); Wed, 28 Apr 2021 16:39:47 -0400 Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E80EC06138C for ; Wed, 28 Apr 2021 13:39:01 -0700 (PDT) Received: by mail-pj1-x1029.google.com with SMTP id f2-20020a17090a4a82b02900c67bf8dc69so9679044pjh.1 for ; Wed, 28 Apr 2021 13:39:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=zX+hK2XOLgRiQ/qjPvLplrcpep/+GXekqfv3v8DoP8Y=; b=eznfVr2r6hniEBhA8Ti+a0WaocGIo4MLATqiMl0YuCwQdn7/ROGHFaGBkasECeL9Az fEWErThEPHa5OsYKa0GcUhBcxmaoAxsyjf5VOYBedtZmCOodHSC1O25SKBhGKCK1bySC 7bmHayjv7zY6FC8zKZhK3XrVTNddE6Mi9fQ5A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=zX+hK2XOLgRiQ/qjPvLplrcpep/+GXekqfv3v8DoP8Y=; b=V/eW7NFDibcon9tCJ6USKteGe+TkiGNNSjKXLtx7O47WqK3YMgykoO2naawNQjZsVN YqxkNDvlZikOG3cddH8Zy/7o9jVh1vmQS4xq/AAIBFmnWSdtPN/B5ZsM6poxZfCqUtB1 dao93XLTBsrghTW2P4+giHyLysOq4pORKf7IVJtQeWM9TJxPZeIEqy1YVObfStcHceBk zbg3jix1mt//3UO3ahym8magCY+z18MadGJDkkTYiBciOIZQ2JoxvKoj9D82Z9AvJXhM HCNFCUFbpFJH73rmuSU1/Uo9r1rgfU+auMesIM9Jfk0qEmBGEyzb+hUyyNeViHGC/GjU F1Cw== X-Gm-Message-State: AOAM531pzMUnzy6XGyr3D4mv4xmn0/p+AYnYZMElZGgQuKq78+s0Y2e5 rB/z44J4QIQGgID4F0746tUwLw== X-Received: by 2002:a17:90b:4017:: with SMTP id ie23mr5716039pjb.155.1619642340911; Wed, 28 Apr 2021 13:39:00 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id k17sm320598pji.47.2021.04.28.13.39.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Apr 2021 13:39:00 -0700 (PDT) Date: Wed, 28 Apr 2021 13:38:59 -0700 From: Kees Cook To: Yu-cheng Yu Cc: x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V. Shankar" , Vedvyas Shanbhogue , Dave Martin , Weijiang Yang , Pengfei Xu , Haitao Huang Subject: Re: [PATCH v26 6/9] x86/vdso: Insert endbr32/endbr64 to vDSO Message-ID: <202104281338.223448FB@keescook> References: <20210427204720.25007-1-yu-cheng.yu@intel.com> <20210427204720.25007-7-yu-cheng.yu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210427204720.25007-7-yu-cheng.yu@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 27, 2021 at 01:47:17PM -0700, Yu-cheng Yu wrote: > From: "H.J. Lu" > > When Indirect Branch Tracking (IBT) is enabled, vDSO functions may be > called indirectly, and must have ENDBR32 or ENDBR64 as the first > instruction. The compiler must support -fcf-protection=branch so that it > can be used to compile vDSO. > > Signed-off-by: H.J. Lu Reviewed-by: Kees Cook -- Kees Cook