Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 28 Apr 2021 16:40:35 -0400
From:   "J. Bruce Fields" <bfields@fieldses.org>
To:     =?utf-8?B?QXVyw6lsaWVu?= Aptel <aaptel@suse.com>
Cc:     Namjae Jeon <namjae.jeon@samsung.com>,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        smfrench@gmail.com, senozhatsky@chromium.org, hyc.lee@gmail.com,
        viro@zeniv.linux.org.uk, hch@lst.de, hch@infradead.org,
        ronniesahlberg@gmail.com, aurelien.aptel@gmail.com,
        sandeen@sandeen.net, dan.carpenter@oracle.com,
        colin.king@canonical.com, rdunlap@infradead.org,
        willy@infradead.org
Subject: Re: [PATCH v2 00/10] cifsd: introduce new SMB3 kernel server
Message-ID: <20210428204035.GD7400@fieldses.org>
References: <CGME20210422003835epcas1p246c40c6a6bbc0e9f5d4ccf9b69bef0d7@epcas1p2.samsung.com>
 <20210422002824.12677-1-namjae.jeon@samsung.com>
 <20210428191829.GB7400@fieldses.org>
 <878s52w49d.fsf@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <878s52w49d.fsf@suse.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Precedence: bulk

On Wed, Apr 28, 2021 at 10:19:58PM +0200, Aurélien Aptel wrote:
> bfields@fieldses.org (J. Bruce Fields) writes:
> > On Thu, Apr 22, 2021 at 09:28:14AM +0900, Namjae Jeon wrote:
> >> This is the patch series for cifsd(ksmbd) kernel server.
> >
> > Looks like this series probably isn't bisectable.  E.g. while looking at
> > the ACL code I noticed ksmbd_vfs_setxattr is defined in a later patch
> > than it's first used in.
> 
> The Kconfig and Makefile are added in the last patch so it should be ok.

I'm not sure if doing that way is really any better than making it one
big patch.

I'd rather see multiple patches that were actually functional at each
stage: e.g., start with a server that responds to some sort of rpc-level
ping but does nothing else, then add basic file IO, etc.

I don't know if that's practical.

--b.