Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp796748pxy; Wed, 28 Apr 2021 14:29:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxx6WD1P6uuzwOt+YOLksOm2BuA1ohdMehciWKRvVBKG1WuYQvoj7VmlHVCc7JkbHoJjEdc X-Received: by 2002:a05:6402:42c3:: with SMTP id i3mr14240676edc.270.1619645368595; Wed, 28 Apr 2021 14:29:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619645368; cv=none; d=google.com; s=arc-20160816; b=V6SN0z0Ly9FteDntxH2k694paAkhGLe9cyjBN547ZYQgpDtZa0JE7NCYcU+45+UgL3 ekNOCOVhpB3Ap+iyKHJigcnLsXBC85MsI8ekJ5WiWualWzMAIGWslVXM2zrY7RfCR01T JrCIKzNV9++U9PdzE8aXLKdZmyFH9iECLPj/GykADfA6UOKmXCe90KwkKpRYjJdAf5cu TC3f7dZ65mWu5lCy492t2ZR2Zcj4N15YogEZxEEDlGH/lTe70Kw2ng0l/uJeeAuVBHRK KuIiwHnXwnQeVZlNtA2z5aI9SBy5JfRIDDCnyZKF5iPwbOLEZHI46BgZLwUdnYAva0C5 kgGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=fS2MnhDRb95G9b5Lg/PUrZLt96sD5Hm8cCLj7SyXiTI=; b=WRryj3mSUCfVohbqimAR127vJt7MdmTZfyhWvP38uN56I3clehyAuPCUPKYFQpom/t qRgV2+2DiROuOheu47SzrP5G1+/ri/klfRm9gRbEdF5s2dGvGNKFcL9zXTmum0QDul4Q r4Eg+3MP5BlXV42Lsr669aVijnhSy60S+fH+Y2jlmzU7O3jpkK/iIfPsRhlhNTBb6sVj QBqn82e7PdU1nKhoKVRTgNdI05KXcyBFyeI0s3LNynBD4dDwkMVvFubw/yb2ohlJP7PS DlLJvy3b1S4CTGfYjh4rIZaR/7xz8nNaV6MCaPs+ZUfi9KNsqrpUUf2b0ofs0911Ulmk j5gw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t6si1101467ejj.37.2021.04.28.14.29.05; Wed, 28 Apr 2021 14:29:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230245AbhD1V2E (ORCPT + 99 others); Wed, 28 Apr 2021 17:28:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:34280 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229691AbhD1V2E (ORCPT ); Wed, 28 Apr 2021 17:28:04 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CB10F6143C; Wed, 28 Apr 2021 21:27:15 +0000 (UTC) Date: Wed, 28 Apr 2021 17:27:14 -0400 From: Steven Rostedt To: Lai Jiangshan Cc: linux-kernel@vger.kernel.org, Lai Jiangshan , Thomas Gleixner , Paolo Bonzini , Sean Christopherson , Andi Kleen , Andy Lutomirski , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, Josh Poimboeuf , Uros Bizjak , Maxim Levitsky , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , Peter Zijlstra , Alexandre Chartre , Joerg Roedel , Jian Cai , xen-devel@lists.xenproject.org Subject: Re: [PATCH 1/4] x86/xen/entry: Rename xenpv_exc_nmi to noist_exc_nmi Message-ID: <20210428172714.53adac43@gandalf.local.home> In-Reply-To: <20210426230949.3561-2-jiangshanlai@gmail.com> References: <20210426230949.3561-1-jiangshanlai@gmail.com> <20210426230949.3561-2-jiangshanlai@gmail.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 27 Apr 2021 07:09:46 +0800 Lai Jiangshan wrote: > From: Lai Jiangshan > > There is no any functionality change intended. Just rename it and > move it to arch/x86/kernel/nmi.c so that we can resue it later in > next patch for early NMI and kvm. Nit, but in change logs, please avoid stating "next patch" as searching git history (via git blame or whatever) there is no such thing as "next patch". Just state: "so that we can reuse it for early NMI and KVM." I also just noticed the typo in "resue". Or maybe both NMI and KVM should be sued again ;-) -- Steve