Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210427224201.32285-1-tsbogend@alpha.franken.de>
 <1619648109.762240.4061025.nullmailer@robh.at.kernel.org> <20210428224153.GA15709@alpha.franken.de>
In-Reply-To: <20210428224153.GA15709@alpha.franken.de>
From:   Rob Herring <robh@kernel.org>
Date:   Wed, 28 Apr 2021 18:45:03 -0500
Message-ID: <CAL_JsqKvL0tT=NG6nu1uuzzF_2ce2RNTJxR5iz4VmfTq3iTz2g@mail.gmail.com>
Subject: Re: [PATCH] dt-binding: interrupt-controller: Add missing interrupts property
To:     Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        devicetree@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
        Marc Zyngier <maz@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Apr 28, 2021 at 5:42 PM Thomas Bogendoerfer
<tsbogend@alpha.franken.de> wrote:
>
> On Wed, Apr 28, 2021 at 05:15:09PM -0500, Rob Herring wrote:
> > On Wed, 28 Apr 2021 00:42:00 +0200, Thomas Bogendoerfer wrote:
> > > Interrupts property is required, so add it.
> > >
> > > Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> > > ---
> > >  .../bindings/interrupt-controller/idt,32434-pic.yaml          | 4 ++++
> > >  1 file changed, 4 insertions(+)
> > >
> >
> > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> >
> > yamllint warnings/errors:
> >
> > dtschema/dtc warnings/errors:
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun4i-a10-ic.example.dt.yaml: interrupt-controller@1c20400: 'oneOf' conditional failed, one must be fixed:
> >       'interrupts' is a required property
> >       'interrupts-extended' is a required property
> >       From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun4i-a10-ic.yaml
>
> now I'm confused... is this a problem of your test ? make dt_binding_check
> was ok with that change...

You and me both. I'll look into it when I apply.

Rob