Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <CAPM=9txMo5f9QvPqdzt8g3CmUpyDFf2Q_0XS4V1FyjHX8WQPRA@mail.gmail.com>
 <CAHk-=wh3x4Q4pCkYe7__OAnvOyPqdZLN5ha0z4U035FwT5G57w@mail.gmail.com> <e6532806-ba36-d5d0-6d74-488182787a6c@amd.com>
In-Reply-To: <e6532806-ba36-d5d0-6d74-488182787a6c@amd.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Wed, 28 Apr 2021 22:09:29 -0400
Message-ID: <CADnq5_Nd6Xo+dQ01Lvoe-e+21zp-gihPZ67ykxec6AG5W=j6CQ@mail.gmail.com>
Subject: Re: [git pull] drm for 5.13-rc1
To:     Mikita Lipski <mlipski@amd.com>
Cc:     Linus Torvalds <torvalds@linux-foundation.org>,
        Dave Airlie <airlied@gmail.com>,
        Mikita Lipski <mikita.lipski@amd.com>,
        Sun peng Li <Sunpeng.Li@amd.com>,
        Qingqing Zhuo <qingqing.zhuo@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        Daniel Vetter <daniel.vetter@ffwll.ch>,
        LKML <linux-kernel@vger.kernel.org>,
        dri-devel <dri-devel@lists.freedesktop.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Apr 28, 2021 at 8:14 PM Mikita Lipski <mlipski@amd.com> wrote:
>
> Hi Linus,
>
> The patch to fix the warning is here
> (https://www.spinics.net/lists/amd-gfx/msg61614.html)
>
> I guess it just didn't propagate all the way to the release.
> Can it still be pulled into 5.13-rc1 release?

I'll include it in my -fixes pull next week.

Alex


>
>
> From: Mikita Lipski <mikita.lipski@xxxxxxx>
>
> [why]
> Previous statement would always evaluate to true
> making it meaningless
> [how]
> Just check if a connector is MST by checking if its port exists.
>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Signed-off-by: Mikita Lipski <mikita.lipski@xxxxxxx>
> Reviewed-by: Nicholas Kazlauskas <Nicholas.Kazlauskas@xxxxxxx>
> Acked-by: Wayne Lin <waynelin@xxxxxxx>
> ---
>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
> b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
> index 656bc8f00a42..8bf0b566612b 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
> @@ -3030,7 +3030,7 @@ static int trigger_hpd_mst_set(void *data, u64 val)
>                         if (!aconnector->dc_link)
>                                 continue;
>
> -                       if (!(aconnector->port && &aconnector->mst_port->mst_mgr))
> +                       if (!aconnector->mst_port)
>                                 continue;
>
>                         link = aconnector->dc_link;
> --
> 2.17.1
>
>
>
> Thanks,
> Mikita
>
>
> On 2021-04-28 6:21 p.m., Linus Torvalds wrote:
> > On Tue, Apr 27, 2021 at 8:32 PM Dave Airlie <airlied@gmail.com> wrote:
> >>
> >> This is the main drm pull request for 5.13. The usual lots of work all
> >> over the place. [...]
> >>
> >> Mikita Lipski:
> >>        drm/amd/display: Add MST capability to trigger_hotplug interface
> >
> > Hmm. I've already merged this, but my clang build shows that this looks buggy:
> >
> > drivers/gpu/drm/amd/amdgpu/amdgpu_dm/amdgpu_dm_debugfs.c:3015:53:
> > warning: address of 'aconnector->mst_port->mst_mgr' will always
> > evaluate to 'true' [-Wpointer-bool-conversion]
> >                          if (!(aconnector->port &&
> > &aconnector->mst_port->mst_mgr))
> >                                                 ~~  ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
> >
> > and yeah, checking for the address of a member of a structure benign
> > NULL doesn't really work.
> >
> > I'm assuming the '&' is just a left-over cut-and-paste error or something.
> >
> > Please fix after reviewing (I'm not going to blindly just remove the
> > '&' just to silence the warning, since I don't know the code).
> >
> >                  Linus
> >
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel