Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: Valdis Kletnieks <valdis@vt.edu>
From:   "Valdis Kl=?utf-8?Q?=c4=93?=tnieks" <valdis.kletnieks@vt.edu>
To:     Leon Romanovsky <leon@kernel.org>
Cc:     bkkarthik <bkkarthik@pesu.pes.edu>,
        Anupama K Patil <anupamakpatil123@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
        linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
        skhan@linuxfoundation.org, gregkh@linuxfoundation.org,
        kernelnewbies@kernelnewbies.org
Subject: Re: [PATCH] drivers: pnp: proc.c: Handle errors while attaching devices
In-Reply-To: <YIeSc1qePhuQ1XRK@unreal>
References: <20210424194301.jmsqpycvsm7izbk3@ubuntu> <YIZJwkux0ghJ8k9d@unreal> <20210426175031.w26ovnffjiow346h@burgerking>
 <YIeSc1qePhuQ1XRK@unreal>
Mime-Version: 1.0
Content-Type: multipart/signed; boundary="==_Exmh_1619670673_209619P";
         micalg=pgp-sha1; protocol="application/pgp-signature"
Content-Transfer-Encoding: 7bit
Date:   Thu, 29 Apr 2021 00:31:13 -0400
Message-ID: <210271.1619670673@turing-police>
Precedence: bulk

--==_Exmh_1619670673_209619P
Content-Type: text/plain; charset=us-ascii

On Tue, 27 Apr 2021 07:26:27 +0300, Leon Romanovsky said:
> On Mon, Apr 26, 2021 at 11:20:32PM +0530, bkkarthik wrote:
> > These were only intended for a clean-up job, the idea of this function came from how PCI handles procfs.
> > Maybe those should be changed?
>
> Probably, the CONFIG_PROC_FS around pci_proc_*() is not needed too.

Will that actually build correctly if it's an embedded system or something build with
CONFIG_PROC_FS=n?  I'd expect that to die a horrid death while linking vmlinx due
to stuff inside that #ifdef calling symbols only present with PROC_FS=m/y.

In general, inline ifdef's are frowned upon, so if you come across one in the kernel
source, that's probably a *big* hint that either (a) refactoring the code to eliminate
an inline ifdef was just too ugly to be allowed to live or (b) you *have* to put a guard
around it because you're guaranteed a build failure otherwise.

--==_Exmh_1619670673_209619P
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Comment: Exmh version 2.9.0 11/07/2018

iQIVAwUBYIo2kAdmEQWDXROgAQLtVA/7BvMbjCP/xvK8WkA+Fk2QhCEVXOxBUGkH
n5t1+/k62wdCTY7EcqhNW5MQWu1VZ16aN0T1RHeTFX3rv7AmDxyXTVlf3ksyof4v
a1/oyPr5mEIzLXmpFjIkHICY2OysaUkLgeScwEOpfpkAAqGrx+DTblzEN08VVbTf
84/gwKgvb8CxU3D5MVpPFUbmDY9JXqJsK3/sPBNYseyXi76ypTSkaANNB8aY7HsZ
C43Qo7wqr8lwe2q/uKjE0Fw5bfPb2B/otaEgfABrRTLDiqyODvSKVdticcHUIWsg
GUpW3QPqYhttPRNjVy+vLQsAytSQVMBuSApoyplJ/ebZUrPRXophRE7WmxoW7q5X
yX/7rnuEB4aT0VeqIcL3LSiUJBGKptBgJiT9qsCYnYTMva0hMQjMKJRRZ1Xczrp7
NDxGMbkkPlre09Z2OsOQqJblQJHiztGTOA6fcXjnigThux5H5xXZCUUklinXcGO3
6jhx5qNOSJ+a5OeLrShSDvR9XuQPxIk8ql/qDs4wkcLb2YB/56d6Lr8reCdsce7n
dChAkKG5CugsOC/E7ZYLtzm8E6ezyiqDPCa+Z4yhdSNPtaxbBW6Ies+Dmkyj8MzO
ChgiQRW04BofS4dU5bF3LgRTuvAtlrKxB94qK+u8YkXYydgV2mfYmCo/Gd/Y62zt
iKcs8dUS/ko=
=MSZI
-----END PGP SIGNATURE-----

--==_Exmh_1619670673_209619P--