Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 29 Apr 2021 08:55:18 +0200
From:   Johan Hovold <johan@kernel.org>
To:     Tung Pham <Tung.Pham@silabs.com>
Cc:     Pho Tran <photranvan0712@gmail.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Hung Nguyen <Hung.Nguyen@silabs.com>,
        Pho Tran <Pho.Tran@silabs.com>
Subject: Re: [PATCH v9] USB: serial: cp210x: Add support for GPIOs on CP2108
Message-ID: <YIpYVk0bwIXFyAuE@hovoldconsulting.com>
References: <20210408103607.2077-1-photranvan0712@gmail.com>
 <YIA8HD0S6C+x5ZC9@hovoldconsulting.com>
 <CO1PR11MB48829DEA0747C1B19278868E81429@CO1PR11MB4882.namprd11.prod.outlook.com>
 <YIksjb9IjOwSpPgw@hovoldconsulting.com>
 <CO1PR11MB4882A90461E033F8EA301C07815F9@CO1PR11MB4882.namprd11.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CO1PR11MB4882A90461E033F8EA301C07815F9@CO1PR11MB4882.namprd11.prod.outlook.com>
Precedence: bulk

On Thu, Apr 29, 2021 at 02:54:09AM +0000, Tung Pham wrote:

> So my questions again are:
> 
>  1) Have you verified that the struct cp210x_quad_port_config above
>     actually matches what the device uses?
> 
>  2) Do you have any documentation of the structures as expected by the
>     device firmware (not your library)?
> 
> 
> Tung Pham: the device return some unused bytes, and manufacturing
> library already discard these byte to assign value to PORT_CONFIG, so
> you don't see padding byte on PORT_CONFIG structure.   you can find
> the structure  of port setting in this code: 
> 
> https://www.silabs.com/documents/public/software/USBXpressHostSDK-Linux.tar
> 
> 
> \USBXpressHostSDK-Linux\USBXpressHostSDK\CP210x\srcpkg\cp210xmanufacturing_1.0.tar\cp210xmanufacturing_1.0\cp210xmanufacturing\cp210xmanufacturing\src\CP2104Device.cpp
> 
> CP210x_STATUS CCP2104Device::GetPortConfig(PORT_CONFIG* PortConfig)

Thanks for confirming.

Johan