Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
To:     robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de
Cc:     kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
        p.zabel@pengutronix.de, l.stach@pengutronix.de, krzk@kernel.org,
        agx@sigxcpu.org, marex@denx.de, andrew.smirnov@gmail.com,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, ping.bai@nxp.com,
        frieder.schrempf@kontron.de, aford173@gmail.com, abel.vesa@nxp.com,
        Peng Fan <peng.fan@nxp.com>
Subject: [PATCH 13/16] soc: imx: gpcv2: correct pm_runtime_get_sync usage
Date:   Thu, 29 Apr 2021 15:30:47 +0800
Message-Id: <20210429073050.21039-14-peng.fan@oss.nxp.com>
In-Reply-To: <20210429073050.21039-1-peng.fan@oss.nxp.com>
References: <20210429073050.21039-1-peng.fan@oss.nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from linux-1xn6.ap.freescale.net (119.31.174.71) by HK2PR02CA0208.apcprd02.prod.outlook.com (2603:1096:201:20::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.29 via Frontend Transport; Thu, 29 Apr 2021 07:00:14 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 615bb2b2-6687-4cd4-2a6f-08d90adc7367
X-MS-TrafficTypeDiagnostic: DB7PR04MB5468:
X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DB7PR04MB54682FE48F8D99499F8E52B9C95F9@DB7PR04MB5468.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:989;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: WRVRVPHhcwGCdhBGX9LKXXBsTw67Ti6a/Eun1tfvgSuLI/ogJ4gqKRj07mbXX/rbj3PLfvgX9VqXpshYuumy9yHmO+mklPfRlgHbximGMSMjyuGfAy7DCOCRtthXF4ubvs+Q4PN9i/L+rn1IRMi9tnaJmEae4b2tXlQwI3wqjP+6nBPRGHXYxtyjkkBGIItX/OB3bQ89KAngkql0aguhX6VsYmhyTMH0NxyahkDa4Un8bLPT+xfiZPSMOMYMQ2qxPtaljLnRuDYDWGxm0phzP8MV9K6mVm1mbVkNjNF//irAeBR+QE2wjxvAGzgyb8sWu6MXy1dSYoqsCtf/YFWQilwWakYuPpgdURgo6kvVmb9oBRkxYHRxjzmOEQ/gwjg8uXVNinNVEwxZ2grzrQnU8DX6MQaNKwi/2uqSolMmkS5zvYLRzRIdBTq2mC2yAjtuTKrzJJ3IjgJV8UMgvGIcTHLrLCnZBKWocbylCZ4NobFYiHTKO2axNfMIcnA/85g8k7lwBR6jLwDUftbifuw77xI1sKkCpGRHm7Fsc95OOCB/03TC1Oi7ay6FezlLyWznS8XWEwpKjRP3AOvzOnehSBCUGcBVWs+TEqM9aspEFl3rhHKyLLSx7dlObbEkPXDcz6ceKaoM6X53zXom7d2B8g==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0402MB2760.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(396003)(376002)(39860400002)(346002)(136003)(2906002)(8936002)(4326008)(52116002)(38100700002)(38350700002)(6666004)(956004)(6512007)(83380400001)(8676002)(66946007)(66476007)(16526019)(2616005)(1076003)(6506007)(186003)(6486002)(66556008)(7416002)(478600001)(4744005)(5660300002)(26005)(316002)(86362001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?AlMN295AY+G7neEculDspmywES2brq4KqsUJMHPfb/0U3OiZwVxd5VzKRHNx?=
 =?us-ascii?Q?vs+O0D4Tib3jupFIsAGlhSPK+Dj93SEi19xfhewVREwkCSw67/XPW7ikfS/y?=
 =?us-ascii?Q?mA2GEieg70/58tud6fdorKlhqa8L78xzc5Spkq1iGKstCnCb/IyV+gfy0mU7?=
 =?us-ascii?Q?2tPoFTZt+tfm0n5SMQr244AjVHKuAJSimLvnvezlPzeBGgthV0QMxe5ucnG2?=
 =?us-ascii?Q?6ZmZY+eciaElAEd7elkqdD9sz21zC8+hYtpMEr/txhC9zpa7hSRK8L0PNqA2?=
 =?us-ascii?Q?7ZXhNcgy02v6smuTjAjvflh94MvzwAXBho1U7jWa95LQQqBHfMm0dcHC6uzH?=
 =?us-ascii?Q?8GnqS3DW9oruC5rzaOCmwrpUHSY2XZwszxcFJ1g/xW5eZwJtFznlSKCvO7kS?=
 =?us-ascii?Q?SKSsgvKg++8TxgUanZRhE6pXwVcSCEOOF3FfMgL1X3sOtOFEQJZNoYK2P5Qv?=
 =?us-ascii?Q?mly9esRkWw5p8nbYZijYvsRhdbc8VcQHJuh3cMLKouRjjOo1r/VMY1r7Qp3K?=
 =?us-ascii?Q?p7Rrs2TRo0XqL2qH8cSaQLbuSLHCBwP9bW8daRmhu9e89xyIWTk5rYACN6oy?=
 =?us-ascii?Q?ZzZV3izdX5kTQRFu1ToDpMD/vSaR7yrPsU5E/6e/UTzS0C7n6XAywXxGWngC?=
 =?us-ascii?Q?eum0IPJfWHfer74Dzh/7vD8b+kCMf1uc7Ydacw729vR7AHVGNQSgpdEzSo3a?=
 =?us-ascii?Q?QFC26jnmBDP+26MdoeAs8gxuRXwQDYUYhOaPZXTnmY1XlzdBSFco4kfjWqVT?=
 =?us-ascii?Q?WnGg74JEu/IQJ4lD+29xSuYqj80NxnJ+ST7ZckNo8lGUKBUk92BUubnvjxJ9?=
 =?us-ascii?Q?hTdOqemR8wYZ1EfoGrrLrIJBBMOQo3MipjOn0snRY/jCarswWXFaBhAPpgg7?=
 =?us-ascii?Q?xIHdxwH0yJGNkjJD1P4aGTHcNgY2iIRYvBvszPyXPTQy9anzFr5m/XH+X9yI?=
 =?us-ascii?Q?MgkkZjgW+nOpaFCG51XT2JOd/K9f4f1oqkCmAlKlageQS30ckYrlg81/NbyN?=
 =?us-ascii?Q?vohEB4Li/vhfvdbnu/aS/huRPu5ufbl4W3CLbJT2sRuwpcbFKAm2ahPr5/Cr?=
 =?us-ascii?Q?uIZZ7Deo7r8O2NknUZKLNh0/b5xTGwLXSC6rEb5CWxyrp0kWi87MMY4UhTJ3?=
 =?us-ascii?Q?iDUeZT9ULg0Ot1n0iXq41MG8EpSJUf8Awo8M7frkIMGQ0wy4Qq1Wt22feaM+?=
 =?us-ascii?Q?i5aj6ayfzRfEVlq3rhcpYLi0JExbY/pZSiqPhHpMgmOU+FU9peWYgX0F8BIg?=
 =?us-ascii?Q?sFBXkVPgQXlqlkIRlcBm/iGYDl/H2SnemJPyT2e8N8eb4QnMH+4WN3EpyCCp?=
 =?us-ascii?Q?nBVb6KsQdA6Orgp5tPEyVKce?=
X-OriginatorOrg: oss.nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 615bb2b2-6687-4cd4-2a6f-08d90adc7367
X-MS-Exchange-CrossTenant-AuthSource: DB6PR0402MB2760.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2021 07:00:19.9207
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: t4uHnv+aVGy4Bw0g+MLaHX/VO+yZ0aI9JnH5kwcigIWroM0O6lBs4mLOTOgYj33P7obK57I19SxU+zses8Dr7g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB5468
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Peng Fan <peng.fan@nxp.com>

When the return value is negative, there is error, otherwise it is
expected.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 drivers/soc/imx/gpcv2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c
index 42b9be05e1f2..d2ce47a5ebad 100644
--- a/drivers/soc/imx/gpcv2.c
+++ b/drivers/soc/imx/gpcv2.c
@@ -197,7 +197,7 @@ static int imx_pgc_power_up(struct generic_pm_domain *genpd)
 	int ret;
 
 	ret = pm_runtime_get_sync(domain->dev);
-	if (ret) {
+	if (ret < 0) {
 		pm_runtime_put_noidle(domain->dev);
 		return ret;
 	}
-- 
2.30.0