Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 29 Apr 2021 10:05:13 +0300
From:   Leon Romanovsky <leon@kernel.org>
To:     Valdis =?utf-8?Q?Kl=C4=93tnieks?= <valdis.kletnieks@vt.edu>
Cc:     bkkarthik <bkkarthik@pesu.pes.edu>,
        Anupama K Patil <anupamakpatil123@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
        linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
        skhan@linuxfoundation.org, gregkh@linuxfoundation.org,
        kernelnewbies@kernelnewbies.org
Subject: Re: [PATCH] drivers: pnp: proc.c: Handle errors while attaching
 devices
Message-ID: <YIpaqTHV/zYHrV1z@unreal>
References: <20210424194301.jmsqpycvsm7izbk3@ubuntu>
 <YIZJwkux0ghJ8k9d@unreal>
 <20210426175031.w26ovnffjiow346h@burgerking>
 <YIeSc1qePhuQ1XRK@unreal>
 <210271.1619670673@turing-police>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <210271.1619670673@turing-police>
Precedence: bulk

On Thu, Apr 29, 2021 at 12:31:13AM -0400, Valdis Kl=C4=93tnieks wrote:
> On Tue, 27 Apr 2021 07:26:27 +0300, Leon Romanovsky said:
> > On Mon, Apr 26, 2021 at 11:20:32PM +0530, bkkarthik wrote:
> > > These were only intended for a clean-up job, the idea of this functio=
n came from how PCI handles procfs.
> > > Maybe those should be changed?
> >
> > Probably, the CONFIG_PROC_FS around pci_proc_*() is not needed too.
>=20
> Will that actually build correctly if it's an embedded system or somethin=
g build with
> CONFIG_PROC_FS=3Dn?  I'd expect that to die a horrid death while linking =
vmlinx due
> to stuff inside that #ifdef calling symbols only present with PROC_FS=3Dm=
/y.

We are talking about pci_proc_detach_device() and pci_proc_detach_bus() her=
e.
They will build perfectly without CONFIG_PROC_FS.

Thanks