Received: by 2002:a05:6520:4211:b029:f4:110d:56bc with SMTP id o17csp1325606lkv; Thu, 29 Apr 2021 03:27:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyZYpQgmukluR6H5bH7EmrqoPofuoEX5SV5YWMRVhUmOUVM8okDR8IDRIFgnqYOti0X/2ZY X-Received: by 2002:a63:6fcc:: with SMTP id k195mr16973653pgc.284.1619692046839; Thu, 29 Apr 2021 03:27:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619692046; cv=none; d=google.com; s=arc-20160816; b=YW9sz1yzD31n02y3igPIlkkQVCIIYwhQMsrm+hqw8497yd8OW3zfWFQ2SFWgrXc3Q1 eZKbSQP6l/zO5GROFvVWex51MJVxIQUQ6ZSGxewXENtzK0H9hWOnq7W6R4txpgTO95xf iXKzTRSugNWPNes9xkR22ZB6EgITF2vYknW8V588HvEAkU/jc3vkXnBaxct3gMMFKu5N 3LtxxWCbu3Vz2G9jREFjaLi9xJN6lV7kjI5yoxfMPYY3fUxgfOYvvbCUIWk2nNOOzgdF BIkY18Ab/yO7cCu0U+zKszB6Tpk7pJPXujTsyLFIc8IQfaKTlSc3jfzLptwB+3tcUWis tKbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=jdvyiwfxk6EhWWBBvXgI59VcLf6U+A7h1FH/Y/4CYVI=; b=YPGdrXY/RDGOz4cu3jz/3TTyZ4LiBq5C6E4WdjC2QPN58yBF0DsbaYJagXswkQKxvD LQjsNo3Ipa8B4Vi+PXvwhrXN+BMRdzO3HNADUsHdx/4Hkku9ylNBCI6sSUekiYivGVFa kcdVbAhZeyKu4v6FEKHHbSnjCIcmpV0AJmye7KLxbgy2NFJtn3PxffiUWbAcQ+1W2dnC q5Qbqk6UW+5I6VNlTW8D/KYShSwnsCgBHghMlJYPJqqyi4O1DAALsZ4pBNiQB1AHffLf KykMRB/ZsN8rVDG/4aCwYeD/QMHnxmI1tuzpNNFlClY76wgFZZNv/myY3YPLAsw1J/tX 6RVg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d20si3125554pgi.311.2021.04.29.03.27.11; Thu, 29 Apr 2021 03:27:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240389AbhD2K0r (ORCPT + 99 others); Thu, 29 Apr 2021 06:26:47 -0400 Received: from out30-57.freemail.mail.aliyun.com ([115.124.30.57]:48897 "EHLO out30-57.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233114AbhD2K0q (ORCPT ); Thu, 29 Apr 2021 06:26:46 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R111e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04426;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=11;SR=0;TI=SMTPD_---0UX9cCYY_1619691948; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0UX9cCYY_1619691948) by smtp.aliyun-inc.com(127.0.0.1); Thu, 29 Apr 2021 18:25:58 +0800 From: Jiapeng Chong To: nicolas.ferre@microchip.com Cc: claudiu.beznea@microchip.com, davem@davemloft.net, kuba@kernel.org, linux@armlinux.org.uk, palmer@dabbelt.com, paul.walmsley@sifive.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, Jiapeng Chong Subject: [PATCH] net: macb: Remove redundant assignment to queue Date: Thu, 29 Apr 2021 18:25:46 +0800 Message-Id: <1619691946-90305-1-git-send-email-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Variable queue is set to bp->queues but these values is not used as it is overwritten later on, hence redundant assignment can be removed. Cleans up the following clang-analyzer warning: drivers/net/ethernet/cadence/macb_main.c:4919:21: warning: Value stored to 'queue' during its initialization is never read [clang-analyzer-deadcode.DeadStores]. drivers/net/ethernet/cadence/macb_main.c:4832:21: warning: Value stored to 'queue' during its initialization is never read [clang-analyzer-deadcode.DeadStores]. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/net/ethernet/cadence/macb_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c index 0f6a6cb..5693850 100644 --- a/drivers/net/ethernet/cadence/macb_main.c +++ b/drivers/net/ethernet/cadence/macb_main.c @@ -4829,7 +4829,7 @@ static int __maybe_unused macb_suspend(struct device *dev) { struct net_device *netdev = dev_get_drvdata(dev); struct macb *bp = netdev_priv(netdev); - struct macb_queue *queue = bp->queues; + struct macb_queue *queue; unsigned long flags; unsigned int q; int err; @@ -4916,7 +4916,7 @@ static int __maybe_unused macb_resume(struct device *dev) { struct net_device *netdev = dev_get_drvdata(dev); struct macb *bp = netdev_priv(netdev); - struct macb_queue *queue = bp->queues; + struct macb_queue *queue; unsigned long flags; unsigned int q; int err; -- 1.8.3.1