Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp1268067pxy; Thu, 29 Apr 2021 03:28:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyYNjtt/52o3ZefcxSuZ9NKvxHAxT1cHVj9a32inQURgaQFDDPJ/8kz+/cjDbjZu5P/dxqc X-Received: by 2002:aa7:da92:: with SMTP id q18mr4197340eds.142.1619692103902; Thu, 29 Apr 2021 03:28:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619692103; cv=none; d=google.com; s=arc-20160816; b=r+7juHcz6MrMuhu4nSrhVMtN02/afEm7E08zTYwE/4IqN/wOOHi0rm+DZ+6Y3cu6vs rofYcfOFisauPBYGjB7Yrf1uHZuU0pXkQtvTxxvzVXmITEJ8otnmCq4wVUR20x/RUan+ CaJ5cEAUXFfqPCUaND4LSRivkZUG36Yu8gnFpF6AduvAtVc6DsUY6rm4Q8XOuCWgE0e8 qfE65FLvjuirkSd5jZVka5VBWfwdHGQectRwWj5fY9Lu6lmENaJ9li6qjXefhLvbye88 R2GBkDy0lkkoTZwOAKuA3H2cNtsb0FTWEtPX3wqqIa81+8VtOx6+GrYBxEW3KlmUe/0q uyZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=7ASz8akXgHSdBZgkf2rOLE3pIgd6yz/gB89jK+XW3d0=; b=jsIza/xKhMyh4AREFuIkIXveDqyRI+0QqYjHamiZ2WQUhBxE/ddioJrHsLYiZmiDXT YmIkUDWaNAogvh3YueQbLY5uH04vEPmNtFWjn2WIGaYLYWh+cwOCpcH54pozygHKBQTk XKCDOOhntXwAhxjcfDhXLMzeAVVBc9SNAaHruErhiyBgYWfKM7oGaFXqvdlSWzZQugQc ZVdcxxkD6XN3sjeCQZub+dE4C6D6wuQV2t0swsw4XWO0Vpi5F3XuF3r/2nv7xTenPJIc ws1moSW4Bm+wDbwK6HAhgHMP9kRD7k7I/BS0pb2kgRHReYW0/XTGxuPSL86Te7KNfC5Y mhZA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id kz24si1280406ejc.33.2021.04.29.03.27.58; Thu, 29 Apr 2021 03:28:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240441AbhD2K11 (ORCPT + 99 others); Thu, 29 Apr 2021 06:27:27 -0400 Received: from out30-44.freemail.mail.aliyun.com ([115.124.30.44]:54352 "EHLO out30-44.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240398AbhD2K10 (ORCPT ); Thu, 29 Apr 2021 06:27:26 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R171e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04423;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=11;SR=0;TI=SMTPD_---0UX9cCg3_1619691984; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0UX9cCg3_1619691984) by smtp.aliyun-inc.com(127.0.0.1); Thu, 29 Apr 2021 18:26:37 +0800 From: Jiapeng Chong To: nicolas.ferre@microchip.com Cc: claudiu.beznea@microchip.com, davem@davemloft.net, kuba@kernel.org, linux@armlinux.org.uk, palmer@dabbelt.com, paul.walmsley@sifive.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, Jiapeng Chong Subject: [PATCH] net: macb: Remove redundant assignment to w0 Date: Thu, 29 Apr 2021 18:26:22 +0800 Message-Id: <1619691982-90657-1-git-send-email-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Variable w0 is set to zero but these values is not used as it is overwritten later on, hence redundant assignment can be removed. Cleans up the following clang-analyzer warning: drivers/net/ethernet/cadence/macb_main.c:3265:3: warning: Value stored to 'w0' is never read [clang-analyzer-deadcode.DeadStores]. drivers/net/ethernet/cadence/macb_main.c:3251:3: warning: Value stored to 'w0' is never read [clang-analyzer-deadcode.DeadStores]. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/net/ethernet/cadence/macb_main.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c index 0f6a6cb..741b2e3 100644 --- a/drivers/net/ethernet/cadence/macb_main.c +++ b/drivers/net/ethernet/cadence/macb_main.c @@ -3248,7 +3248,6 @@ static void gem_prog_cmp_regs(struct macb *bp, struct ethtool_rx_flow_spec *fs) /* ignore field if any masking set */ if (tp4sp_m->ip4src == 0xFFFFFFFF) { /* 1st compare reg - IP source address */ - w0 = 0; w1 = 0; w0 = tp4sp_v->ip4src; w1 = GEM_BFINS(T2DISMSK, 1, w1); /* 32-bit compare */ @@ -3262,7 +3261,6 @@ static void gem_prog_cmp_regs(struct macb *bp, struct ethtool_rx_flow_spec *fs) /* ignore field if any masking set */ if (tp4sp_m->ip4dst == 0xFFFFFFFF) { /* 2nd compare reg - IP destination address */ - w0 = 0; w1 = 0; w0 = tp4sp_v->ip4dst; w1 = GEM_BFINS(T2DISMSK, 1, w1); /* 32-bit compare */ -- 1.8.3.1