Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp1299437pxy; Thu, 29 Apr 2021 04:12:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz2/XfQC8ZF3rPrrUJUURzuYrMVybkKl6XxcPfXDOTWZcouELiluSWisAii4U1PxszJZ//b X-Received: by 2002:a17:906:eda3:: with SMTP id sa3mr13528175ejb.415.1619694767773; Thu, 29 Apr 2021 04:12:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619694767; cv=none; d=google.com; s=arc-20160816; b=vtIq7xuQS8jCBw5CoHEYTMb/FHHjrrLFjYqx+DxoMX7mcOyGIYvGtcHir3qgO8IlFR styVXtPojU2mcEKYoE+4vn7hbIta7YzCarjKUCTSy7GEGLdY3gIcJb+yBWcxsTo7GVNH TGUBTCzICCAkKrJTFUqudiVE8ZF37X2rPukzZAnU6ENrRK+niVUxGeQwH+G88/17Unmz 8h7Wi9/Az0jMunKPF5NejPcKgZlKmoUK/lzdmAZGB6YzJXTYsLEAnK70MwYBtXUUoYj6 OBst7JWMtTHBDCr89IgkEiIlJDatH08gNNZg+apjCCixdH5SROq1SjEwq/eupEed9WA3 18Iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=pjbx6YU3Pb9iakqMts3aUqGQRpiMABsvx8fPGsVGQpY=; b=H38XcpNbh7W8uI1rP3kd4LeyoxIh8p+K9T1UmmLMLrINon7T2UDTi+EcqjpHE/RASk 9Rh3w7AqAs/0dXaGl367qCtFSz2e7lfMUZokEADZBdg3ra2S2CqlV2WWSa3gv3XNL18j D3MCmdPCEzfRcsqD3WN6IejU/oS4YZy8pJ/vsGDEe880z5hC+KTwPUNBbwHqXDT0JK2H Cg7JpRLht1eMogITSHxevAhUSgEFM6WiUC12Gu77Ou+5QuL7/euDto9lJKl4LaJgbhXi TXAP8SV8Ccdn7a2jCTM9zoKm8NX9m2WptZpymnojxm4di4kbo/jngl1S9vnyFSduJq7o nwSw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g17si3279601ejr.16.2021.04.29.04.12.23; Thu, 29 Apr 2021 04:12:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240673AbhD2LJn (ORCPT + 99 others); Thu, 29 Apr 2021 07:09:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235944AbhD2LJc (ORCPT ); Thu, 29 Apr 2021 07:09:32 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2BD8AC061343 for ; Thu, 29 Apr 2021 04:08:46 -0700 (PDT) Received: from dude.hi.pengutronix.de ([2001:67c:670:100:1d::7]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lc4X6-00074s-Dv; Thu, 29 Apr 2021 13:08:36 +0200 Received: from ore by dude.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1lc4X4-0000zG-MJ; Thu, 29 Apr 2021 13:08:34 +0200 From: Oleksij Rempel To: Woojung Huh , UNGLinuxDriver@microchip.com, Andrew Lunn , Florian Fainelli , Vivien Didelot , Vladimir Oltean , "David S. Miller" , Jakub Kicinski Cc: Oleksij Rempel , Colin Ian King , kernel@pengutronix.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Russell King , Michael Grzeschik Subject: [PATCH net-next v1 2/3] net: dsa: ksz: ksz8795_spi_probe: fix possible NULL pointer dereference Date: Thu, 29 Apr 2021 13:08:32 +0200 Message-Id: <20210429110833.2181-2-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210429110833.2181-1-o.rempel@pengutronix.de> References: <20210429110833.2181-1-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::7 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix possible NULL pointer dereference in case devm_kzalloc() failed to allocate memory Fixes: cc13e52c3a89 ("net: dsa: microchip: Add Microchip KSZ8863 SPI based driver support") Reported-by: Colin Ian King Signed-off-by: Oleksij Rempel --- drivers/net/dsa/microchip/ksz8795_spi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/dsa/microchip/ksz8795_spi.c b/drivers/net/dsa/microchip/ksz8795_spi.c index 85ba12aa82d8..ea7550d1b634 100644 --- a/drivers/net/dsa/microchip/ksz8795_spi.c +++ b/drivers/net/dsa/microchip/ksz8795_spi.c @@ -41,6 +41,9 @@ static int ksz8795_spi_probe(struct spi_device *spi) int i, ret = 0; ksz8 = devm_kzalloc(&spi->dev, sizeof(struct ksz8), GFP_KERNEL); + if (!ksz8) + return -ENOMEM; + ksz8->priv = spi; dev = ksz_switch_alloc(&spi->dev, ksz8); -- 2.29.2