Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp1313976pxy; Thu, 29 Apr 2021 04:33:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxBrUXUgAZYLlOldzXmPlC+xcOrWojwrLydb5+z574QfceBfX/Hb93jsCWp9A3bUpSi5KYW X-Received: by 2002:a17:906:5906:: with SMTP id h6mr34463833ejq.176.1619696026660; Thu, 29 Apr 2021 04:33:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619696026; cv=none; d=google.com; s=arc-20160816; b=a/3ACgIlzw9BCVFOh1NVTDP9lwkgjwbNUDoyIuq6SWMcYu+VJXecnVjBetE8+cXw/F jQT9zpqSf31FjH5avueDKHl36y+QpMVgx/yg/uoDS2BIZg+LZ+U/JQCjE1ddwLBDsdjw 2BkKHC2RofsLs7a22oJIqWGcRt1bLp5jZT+4FwGwfeha96JE/2rLO7A1G7zCU23Ivinh dgtEqRjel6liHZak4IGA1MYHaEtOjrX01N+9cyYUj8RMZ9ooTh6o9PgvYBVdKUMfa/d7 brSWPlZ1zdXr7bRNzdZJ9LZIJABXIkZ0hmR6m2n9HDTgn80pFC6tW3pFhTVM+rI7mL1k hMYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=9DKNen54n59CwTz0ERlhOfZJdCkC3F3YPEIgkiXT70Q=; b=pN+WlMZreSL0kf1Z385izhECcxwHPGqksJJ9SY+KOvKXdl628+w74wJsQmV6eA9RMp 2rpXlzLpPUcdQ4q6g43L+r20+IXZSV73BUljFYPM2WWD7SmR8wHY6Z2vvom+1J37XTP4 ws3CsVZR9nmkzOuFI1lJKSn90d60J7Yp2FC6ca9wJebjnG3AXngUaU9ye6J3eapjwbTR yfYs2eBzaqzfg08Z2uHyIx1Oe7wguB9YZLtI7bDhe3dRBUujcBnqrY/DBZMh42op0zKe BLZ4TVXVcDLoNEnH0K6DK5oTgh/x0xierrdNgHtfaX/GqzKIIM0cnTqYigvOsiD1e4XA DrDQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=LZsok5To; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hp26si2879228ejc.209.2021.04.29.04.33.20; Thu, 29 Apr 2021 04:33:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=LZsok5To; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232101AbhD2Lcz (ORCPT + 99 others); Thu, 29 Apr 2021 07:32:55 -0400 Received: from msg-2.mailo.com ([213.182.54.12]:36384 "EHLO msg-2.mailo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230148AbhD2Lcz (ORCPT ); Thu, 29 Apr 2021 07:32:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1619695910; bh=d3uPdEXE1jNAZ54QKIFbLqD5wKoRL+q+9gPNpRFnQIw=; h=X-EA-Auth:Date:From:To:Cc:Subject:Message-ID:References: MIME-Version:Content-Type:In-Reply-To; b=LZsok5TotTifFAujfAN9dRlgA5JB2P4OgCNd1ghlSOEPrPBi5IQxxRCdW3Zb3boz7 GNxdyI9hLomBtSVKS7SrKLwpwmzY2HjcW5AS+WkWECPrZAhV5NKzMGkAkeEDDq6P5i 0Uko0t8E4OwpwctefKBpb8oN+hpXDrKJuLHn2wQM= Received: by 192.168.90.16 [192.168.90.16] with ESMTP via ip-206.mailobj.net [213.182.55.206] Thu, 29 Apr 2021 13:31:50 +0200 (CEST) X-EA-Auth: CX0bTBDMWFCx2SMkg6z9D2BIwVUjGxNmB0nEYowyJhWVMQ6M3qPxHOtdCEn3sTk1EckjJk8FvCJTxXNGgQMUroIbvLmS2QJE Date: Thu, 29 Apr 2021 17:01:41 +0530 From: Deepak R Varma To: Dan Carpenter Cc: Mauro Carvalho Chehab , Sakari Ailus , Greg Kroah-Hartman , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, mh12gx2825@gmail.com Subject: Re: [PATCH v1 4/6] staging: media: atomisp: reformat code comment blocks Message-ID: References: <20210429100808.GZ1981@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210429100808.GZ1981@kadam> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 29, 2021 at 01:08:09PM +0300, Dan Carpenter wrote: > On Wed, Apr 21, 2021 at 10:26:09PM +0530, Deepak R Varma wrote: > > @@ -1044,7 +1048,7 @@ static long mt9m114_s_exposure(struct v4l2_subdev *sd, > > } > > > > /* > > - // set analog/digital gain > > + * set analog/digital gain > > switch(AnalogGain) > > { > > case 0: > > How on earth does this compile? There is a closing */ down under after the entire switch block. The change I made is within the comment block. I have compiled the built the driver successfully. Please let me know if you are seeing a different issue here. Thank you, deepak. > > > @@ -1069,8 +1073,10 @@ static long mt9m114_s_exposure(struct v4l2_subdev *sd, > > > regards, > dan carpenter >