Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp1344990pxy; Thu, 29 Apr 2021 05:17:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz/3oNvwJN0Fj/2tMNl4VYJKs0xP9fyrJmuyZVAL+/+GUftuqQ8nTXvIz3jzm559HnQ/gBq X-Received: by 2002:a17:902:f284:b029:ed:1840:5cad with SMTP id k4-20020a170902f284b02900ed18405cadmr24654648plc.34.1619698646723; Thu, 29 Apr 2021 05:17:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619698646; cv=none; d=google.com; s=arc-20160816; b=OE5x4aI7zCRX0u8adtUk8e5AJ3qimM/mdMbe3mRTPQEPxkgPhmca60IgfehVVkqShv hYO5TWHFcGCCoGBpzn09dgUb8ps7A92UzYb13IsL79/Nxc80sonYEtXIwvjwU8uXONA5 19KJ8oX5o4YbvjCoQqHreSfOc06hBPDShi72Q6ewz9sVKoR3495ytHMQEIy3ybRuClfk 2zX3tegBgu3Ni7wR8Xw3ZFx0DjlQp4CEX3AlZJyrSZnKPNCuerSUTc64/8IypHRcXYeo dRgIod+zav9cRqrvDsViOtZr7kQzHryXcdVZMw3DBcaaaJeSa+l2x5BQtiuFXjpjkXZV t0XA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=3dvgi4nh698lEwcBpT13JIyVAZI3HK83xIJukm7eZcs=; b=PS/Mi6e2USi+6ygUmqCEaW6L3Lw1a6yu8k/T7l7W8EHIflG2ySvkZsNAWafq5kW7tF M1wohxU4hKNg/GPpynvi8gcKxmNGyZL8rfEfOU3L+pb6ADsgjGI2BsabFD4GtjYUnUuS y9f2+CgaM/cOIw7FCDUFPn2xaldmc9TaF4RA+c9NQX00V8SRgUlctgANSEo6lwViIx4o au81QfQVL5r3jYp8kku3ut6xfbQoOXob/WSr9WuhZwHmgQ5qiDML8hkwNLJBHzQ0RMBh nHkmODXe0IfoexEkfwBRVDySZSso8rgmCliFH+bR+wLqDXQP1GfxvvYiae+dFXdoTE7D BVAw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z17si3493896plg.432.2021.04.29.05.17.13; Thu, 29 Apr 2021 05:17:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236545AbhD2MPj (ORCPT + 99 others); Thu, 29 Apr 2021 08:15:39 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:46042 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230148AbhD2MPi (ORCPT ); Thu, 29 Apr 2021 08:15:38 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1lc5Z9-001dqO-5L; Thu, 29 Apr 2021 14:14:47 +0200 Date: Thu, 29 Apr 2021 14:14:47 +0200 From: Andrew Lunn To: Oleksij Rempel Cc: Woojung Huh , UNGLinuxDriver@microchip.com, Florian Fainelli , Vivien Didelot , Vladimir Oltean , "David S. Miller" , Jakub Kicinski , kernel@pengutronix.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Russell King , Michael Grzeschik Subject: Re: [PATCH net-next v1 3/3] net: dsa: ksz: ksz8863_smi_probe: set proper return value for ksz_switch_alloc() Message-ID: References: <20210429110833.2181-1-o.rempel@pengutronix.de> <20210429110833.2181-3-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210429110833.2181-3-o.rempel@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 29, 2021 at 01:08:33PM +0200, Oleksij Rempel wrote: > ksz_switch_alloc() will return NULL only if allocation is failed. So, > the proper return value is -ENOMEM. > > Fixes: 60a364760002 ("net: dsa: microchip: Add Microchip KSZ8863 SMI based driver support") > Signed-off-by: Oleksij Rempel Reviewed-by: Andrew Lunn Andrew