Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp1434013pxy; Thu, 29 Apr 2021 07:06:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwKPxthM2eb7j8z2vLORQrO+LzHhI6/j6PPOFUSfmzt6BfjEAlPK3brtgd1vUm6+vvco0+i X-Received: by 2002:a17:90a:f303:: with SMTP id ca3mr9694742pjb.145.1619705165105; Thu, 29 Apr 2021 07:06:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619705165; cv=none; d=google.com; s=arc-20160816; b=weHgK55Zyp1QUfQspeySdcq0ZgtGpCX4qjOZ0YZ9wo+7GAUoc+su75UjDW1i2JzqdV yJ7rub8SYSBCUmVWTmx1LxRL/hLKzpSrZM7KpIy3PSfkDJbbBSU616jysDwBNNTY2Cyp IpOFBcY8RcDvA6Sst+rj+Gc1v2u2qFH7lekf0MRcc7PKCjm1fW2DxhvcxwTxu+q8wcab G61aO9Nm2Vcjrs8Sq/RC9mW3uGFRcFqUEvOAioBAJ7LmRcldnvVwQ6al3kJsVoUYp6tU xLFQyVW3uIO+N6ZkgthlOhhFqc2kewpx7ve0hLrFtiWOXdYYR7S3/xMFKcKMu7KJkVVF fCjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from; bh=O2yYmJ3wNeFxnmRxM3Uv9a5okNaGF6QTZaAwadkMyYA=; b=l7VeBxu7DSs4t8jAGhBAENJps6GJJClZbYvU3IQ8mju77quAz2r3sJkP3E+KI1KNEg 50tlBAGVyrXPMKEHZoHywMVC9r65tVBsgB4V99QMS7NUcK6rBpic2etWlBZjN84p8UFR 3s4YucwLPG4pV2u3xmT4SJ5fsrfJKjFBgL0Sy8wAOUKhVFFBPwf+ppUoQfYcr+w74WA0 /mKZUWCltvjW83iH0Q2okJ0DGxL23JE2Q628OaBo5nokjHtlo8A8nBYsTg3qrj19tps0 azjlvak+aZiY1jCHx7S6pfzyasYqGTnFbwS9w4JXfXjPXHOrUOWGcwsFU3E6t0p0Rd4F Z5dw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a18si3591196pfh.317.2021.04.29.07.05.51; Thu, 29 Apr 2021 07:06:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237315AbhD2ODe (ORCPT + 99 others); Thu, 29 Apr 2021 10:03:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34328 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239774AbhD2ODc (ORCPT ); Thu, 29 Apr 2021 10:03:32 -0400 Received: from ozlabs.org (bilbo.ozlabs.org [IPv6:2401:3900:2:1::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 970B9C06138B for ; Thu, 29 Apr 2021 07:02:44 -0700 (PDT) Received: by ozlabs.org (Postfix, from userid 1034) id 4FWHJK6k2Bz9sX2; Fri, 30 Apr 2021 00:02:41 +1000 (AEST) From: Michael Ellerman To: Michael Ellerman , Nathan Chancellor Cc: clang-built-linux@googlegroups.com, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Nick Desaulniers , Paul Mackerras In-Reply-To: <20210426203518.981550-1-nathan@kernel.org> References: <20210426203518.981550-1-nathan@kernel.org> Subject: Re: [PATCH] powerpc: Avoid clang uninitialized warning in __get_user_size_allowed Message-Id: <161970488758.4033873.8885072573106528353.b4-ty@ellerman.id.au> Date: Fri, 30 Apr 2021 00:01:27 +1000 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 26 Apr 2021 13:35:18 -0700, Nathan Chancellor wrote: > Commit 9975f852ce1b ("powerpc/uaccess: Remove calls to __get_user_bad() > and __put_user_bad()") switch to BUILD_BUG() in the default case, which > leaves x uninitialized. This will not be an issue because the build will > be broken in that case but clang does static analysis before it realizes > the default case will be done so it warns about x being uninitialized > (trimmed for brevity): > > [...] Applied to powerpc/next. [1/1] powerpc: Avoid clang uninitialized warning in __get_user_size_allowed https://git.kernel.org/powerpc/c/f9cd5f91a897ea0c45d0059ceeb091cee78c6ebe cheers