Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp1451441pxy; Thu, 29 Apr 2021 07:24:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJygjxCZph5+0dPaJrVDjXgu5fX/ajI08ArirgZ1rAtfUHpj9p8sv9V/gAteROlnnRQYZnh9 X-Received: by 2002:a17:906:e118:: with SMTP id gj24mr67836ejb.205.1619706251434; Thu, 29 Apr 2021 07:24:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619706251; cv=none; d=google.com; s=arc-20160816; b=JKTpAedJdO2z7A1bM7ZA13l1Wv51SO4Q1L/O6fXnRopyiQWBMFhA6IEfQK62nCB7a5 BkF/f3wFLw5AOLQhDTSQUS1G0b+Ta9MEH5ef4Nk+lWaBa7FtA+F7GbtvRAbNPO3NylOk KMCpGraSFsNVFLad+m/4+B1WgUmeWvhJZM7HOzbV6vC+E+sRPxMvPQfghOiNAWYIN008 UNvoxoXAmul1sCcL3pgDM35w93tmRkULT0zlavztdDm75czKraenRWNVqZ/8id+uTxt5 2fGe2cXld+bR7MjuQZ0zmGAzul05q9iY93sUC54ZQO3XakmnzsyojFSymqgxyOpthEOD iEbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject:ironport-sdr:ironport-sdr; bh=GqQkmUDQJp2qavfAJ/Ssa7XmwqmnuzLs6fd1eOxj4og=; b=U4YK3uAUI0i8SdqEMDGNRVxDG+MeCa7/miFtITMGLghkdfbfK7u9fIdJWgRnSvfd9j TK31PmDNW5znicaLo+VW+7mRqG6pbnF9PX5JzQtq37E/FC7Ng8PfNwt3rlyt+LveErmm 9WRAYfDULhk80d9FppYQuNZg35hS1gC+LSHkQYRHGAZBmDaQl4LQBfMjLEhsVjpELPkD 9OAcfQ5gBpemP4qWzWBGEYbYvE59U6ze+ynx+8QG0M7jIEZdcYH7QsxWjaOET2mWcWyA Rq5g5gaZ9oro2/WHKyiow2QHJYoOq9C/9oEUWj4TOL0yPrngzdUhlVD0WIGV60T06tTo kWpQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bj22si148849ejb.53.2021.04.29.07.23.25; Thu, 29 Apr 2021 07:24:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240048AbhD2OWG (ORCPT + 99 others); Thu, 29 Apr 2021 10:22:06 -0400 Received: from mga11.intel.com ([192.55.52.93]:2507 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235277AbhD2OWF (ORCPT ); Thu, 29 Apr 2021 10:22:05 -0400 IronPort-SDR: QON8KYeyAQX5PgyflekTMiuuTDSzffyVOhniStm1bwTBJ9E6GL7jTcwTIRRGymDgP6z08dMnbA JMzJafsjsuog== X-IronPort-AV: E=McAfee;i="6200,9189,9969"; a="193829153" X-IronPort-AV: E=Sophos;i="5.82,259,1613462400"; d="scan'208";a="193829153" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Apr 2021 07:21:17 -0700 IronPort-SDR: j4YqGUIp2zuCAmOa/Uy5XZKAKw+oAnFxuG+Wi1aoXcDHbN8KcV4hFdmKA2rlrQBSjW0eb89nv/ xswrXBDvP/jw== X-IronPort-AV: E=Sophos;i="5.82,259,1613462400"; d="scan'208";a="386955325" Received: from ndutta-mobl.amr.corp.intel.com (HELO [10.212.215.226]) ([10.212.215.226]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Apr 2021 07:21:16 -0700 Subject: Re: [PATCH 1/2] CPU, NUMA topology ABIs: clarify the overflow issue of sysfs pagebuf To: Tian Tao , corbet@lwn.net, gregkh@linuxfoundation.org, song.bao.hua@hisilicon.com Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , Peter Zijlstra , Valentin Schneider , Dave Hansen , Daniel Bristot de Oliveira References: <1619679819-45256-1-git-send-email-tiantao6@hisilicon.com> <1619679819-45256-2-git-send-email-tiantao6@hisilicon.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzShEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gPGRhdmVAc3I3MS5uZXQ+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAUCTo3k0QIZAQAKCRBoNZUwcMmSsMO2D/421Xg8pimb9mPzM5N7khT0 2MCnaGssU1T59YPE25kYdx2HntwdO0JA27Wn9xx5zYijOe6B21ufrvsyv42auCO85+oFJWfE K2R/IpLle09GDx5tcEmMAHX6KSxpHmGuJmUPibHVbfep2aCh9lKaDqQR07gXXWK5/yU1Dx0r VVFRaHTasp9fZ9AmY4K9/BSA3VkQ8v3OrxNty3OdsrmTTzO91YszpdbjjEFZK53zXy6tUD2d e1i0kBBS6NLAAsqEtneplz88T/v7MpLmpY30N9gQU3QyRC50jJ7LU9RazMjUQY1WohVsR56d ORqFxS8ChhyJs7BI34vQusYHDTp6PnZHUppb9WIzjeWlC7Jc8lSBDlEWodmqQQgp5+6AfhTD kDv1a+W5+ncq+Uo63WHRiCPuyt4di4/0zo28RVcjtzlGBZtmz2EIC3vUfmoZbO/Gn6EKbYAn rzz3iU/JWV8DwQ+sZSGu0HmvYMt6t5SmqWQo/hyHtA7uF5Wxtu1lCgolSQw4t49ZuOyOnQi5 f8R3nE7lpVCSF1TT+h8kMvFPv3VG7KunyjHr3sEptYxQs4VRxqeirSuyBv1TyxT+LdTm6j4a mulOWf+YtFRAgIYyyN5YOepDEBv4LUM8Tz98lZiNMlFyRMNrsLV6Pv6SxhrMxbT6TNVS5D+6 UorTLotDZKp5+M7BTQRUY85qARAAsgMW71BIXRgxjYNCYQ3Xs8k3TfAvQRbHccky50h99TUY sqdULbsb3KhmY29raw1bgmyM0a4DGS1YKN7qazCDsdQlxIJp9t2YYdBKXVRzPCCsfWe1dK/q 66UVhRPP8EGZ4CmFYuPTxqGY+dGRInxCeap/xzbKdvmPm01Iw3YFjAE4PQ4hTMr/H76KoDbD cq62U50oKC83ca/PRRh2QqEqACvIH4BR7jueAZSPEDnzwxvVgzyeuhwqHY05QRK/wsKuhq7s UuYtmN92Fasbxbw2tbVLZfoidklikvZAmotg0dwcFTjSRGEg0Gr3p/xBzJWNavFZZ95Rj7Et db0lCt0HDSY5q4GMR+SrFbH+jzUY/ZqfGdZCBqo0cdPPp58krVgtIGR+ja2Mkva6ah94/oQN lnCOw3udS+Eb/aRcM6detZr7XOngvxsWolBrhwTQFT9D2NH6ryAuvKd6yyAFt3/e7r+HHtkU kOy27D7IpjngqP+b4EumELI/NxPgIqT69PQmo9IZaI/oRaKorYnDaZrMXViqDrFdD37XELwQ gmLoSm2VfbOYY7fap/AhPOgOYOSqg3/Nxcapv71yoBzRRxOc4FxmZ65mn+q3rEM27yRztBW9 AnCKIc66T2i92HqXCw6AgoBJRjBkI3QnEkPgohQkZdAb8o9WGVKpfmZKbYBo4pEAEQEAAcLB XwQYAQIACQUCVGPOagIbDAAKCRBoNZUwcMmSsJeCEACCh7P/aaOLKWQxcnw47p4phIVR6pVL e4IEdR7Jf7ZL00s3vKSNT+nRqdl1ugJx9Ymsp8kXKMk9GSfmZpuMQB9c6io1qZc6nW/3TtvK pNGz7KPPtaDzvKA4S5tfrWPnDr7n15AU5vsIZvgMjU42gkbemkjJwP0B1RkifIK60yQqAAlT YZ14P0dIPdIPIlfEPiAWcg5BtLQU4Wg3cNQdpWrCJ1E3m/RIlXy/2Y3YOVVohfSy+4kvvYU3 lXUdPb04UPw4VWwjcVZPg7cgR7Izion61bGHqVqURgSALt2yvHl7cr68NYoFkzbNsGsye9ft M9ozM23JSgMkRylPSXTeh5JIK9pz2+etco3AfLCKtaRVysjvpysukmWMTrx8QnI5Nn5MOlJj 1Ov4/50JY9pXzgIDVSrgy6LYSMc4vKZ3QfCY7ipLRORyalFDF3j5AGCMRENJjHPD6O7bl3Xo 4DzMID+8eucbXxKiNEbs21IqBZbbKdY1GkcEGTE7AnkA3Y6YB7I/j9mQ3hCgm5muJuhM/2Fr OPsw5tV/LmQ5GXH0JQ/TZXWygyRFyyI2FqNTx4WHqUn3yFj8rwTAU1tluRUYyeLy0ayUlKBH ybj0N71vWO936MqP6haFERzuPAIpxj2ezwu0xb1GjTk4ynna6h5GjnKgdfOWoRtoWndMZxbA z5cecg== Message-ID: <146e051b-603c-a6d3-43d8-d083cf2c8119@intel.com> Date: Thu, 29 Apr 2021 07:21:13 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1619679819-45256-2-git-send-email-tiantao6@hisilicon.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/29/21 12:03 AM, Tian Tao wrote: > diff --git a/Documentation/ABI/stable/sysfs-devices-node b/Documentation/ABI/stable/sysfs-devices-node > index 484fc04..82dfe64 100644 > --- a/Documentation/ABI/stable/sysfs-devices-node > +++ b/Documentation/ABI/stable/sysfs-devices-node > @@ -47,7 +47,10 @@ What: /sys/devices/system/node/nodeX/cpulist > Date: October 2002 > Contact: Linux Memory Management list > Description: > - The CPUs associated to the node. > + The CPUs associated to the node. The format is like 0-3, > + 8-11, 14,17. maximum size is PAGE_SIZE, so the tail > + of the string will be trimmed while its size is larger > + than PAGE_SIZE. I think it's pretty arguable that truncating output on a real system is an ABI break. Doing this would make the interface rather useless. Don't we need a real solution rather than throwing up our hands? Do we think >PAGE_SIZE data out of a sysfs file is a worse ABI break or something?