Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp1455853pxy; Thu, 29 Apr 2021 07:29:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz9V4A3e5rWwYRoGB6Ow3LVfaSVQgnVM1GYvFjMpeAkcwvDxGGZYD9ENs6348SNTaD3sCYr X-Received: by 2002:aa7:c9cf:: with SMTP id i15mr18986817edt.4.1619706571688; Thu, 29 Apr 2021 07:29:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619706571; cv=none; d=google.com; s=arc-20160816; b=cNnfaah5I6aa10wVAuqjjaYSRzDzcZBLHUhHlizSVO63UxUKi4WXr+93ZDnqD00/T/ +YKQfoUc8j3lYmEFAjogrjEGKjoMYXFNm4Kf9uXLZ71O8r/KELhpLlzMbw9PvkQNsaYV tSQqCiTbXVal3LI9eqBFPOvPvpZthiiko8y24Nu0vmSqQab+nutnpi38o9Lt92mIcXos chVHuD6Sn5nhAX8NZyKF+7JIa2xxT2hPW7JIoZr4F42Oo7PfxESyzx2twAWEZuqkGOoG L9RmzFn0Uui5pYSDwbjZPokb5rkupwhhtRn/47J3Ip67yQQJ+Dm5W/j8sn9u1aXAAShR GUEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=oX7qYgxXYUDTnDWIrAAdrMAk23CW1FWOs8hQTp5c3yY=; b=NOOfN1D9g1HZjNv2KMrhqbzj9mGzGti3bU4ebdNd7eyGIWOu02yuuGWfDCwFPV+yLA Fi/PQ6xmZqkJCwRdFUGFoHe94pjUJjDj+BZfvtwyZ5qZL9AKnNl+pJFNODoVXereZ7Xb UXfs1m6pbVHhrlusXdwZ6LkruacDWvkszCxQfwanpFNmLiuEVr415IS7hk2jBcDOOdyJ tJG8l7B9Duv3LSBs+AkFATlvVHyMa+oFSdK5O9njPqqk3zlG7fkTuW4bm4b3WKlbA/qC QLxa9r/BQq1Y3Y6d07R+2NNl0Jo41WrFV9gYlcRz2IsBztnah8oEhY6dVwtpzcWA7fyi sWFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=U4mbRlv5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hq37si146439ejc.262.2021.04.29.07.29.07; Thu, 29 Apr 2021 07:29:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=U4mbRlv5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239655AbhD2O2L (ORCPT + 99 others); Thu, 29 Apr 2021 10:28:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239032AbhD2O2K (ORCPT ); Thu, 29 Apr 2021 10:28:10 -0400 Received: from mail-il1-x134.google.com (mail-il1-x134.google.com [IPv6:2607:f8b0:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B69D7C06138D for ; Thu, 29 Apr 2021 07:27:21 -0700 (PDT) Received: by mail-il1-x134.google.com with SMTP id c15so6846964ilj.1 for ; Thu, 29 Apr 2021 07:27:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=oX7qYgxXYUDTnDWIrAAdrMAk23CW1FWOs8hQTp5c3yY=; b=U4mbRlv5UHD7sn2yKKFCrR+4XJ13UgOrePmZ9r2zi4LgU/UxNb72eYOLK/TvO7VUlz 30WM7WkrcRFNI/x/ite+fOcgwI2QEtgUxsjoskRUTfetp2ZeV8V6EvbTQJQ8k/LVqLSz LkoD3TnCV+fTaXYxRE35BxH8SiXnv7w1dxW3bIcojZXcQEWKEdKLy4tpks1Cw+gUrAkq VuQqMkHFdQ0zszYyHwo5cmhjNf9iphNdIiDdkLefNDM7yiRp1rrPoe+45r/HOSWh/7WI vNsgd2MnuJMVvW5PuGtKQDv4GD6uCtf2xJAILqgH4/102fTtZdT3o7pZTZtcy7g1yg4X 791A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=oX7qYgxXYUDTnDWIrAAdrMAk23CW1FWOs8hQTp5c3yY=; b=AlZMIxq0YCZ3yYD+Sz4ijV+Cl5f4sDTKLq3COeK1jXewHq+j+G0Bvx+IhEnRmMlJWc KhX2XivUjIBNbIIPO2PXb+m0QkwXZlHWu5OWlNKYIlC5r6XwlBiQxDGKog+W+MybLeFO YIyITnqNzNJ2P7z/a/Z97gVpjzTFMZYI0RHl/Tu3lLdWlMFRxO0ObDKbBQurH/mRD0XP HD9RWaqKcMW4qubupNWbU++/R3TyPxWV9MjBB073Symv1V7xLXPSXSb6GpAboAHasBQY 3+puyjgVoKiILXrTa4XKjlOxgsCKs3wsh2eGjzA5PTMfxZkliCfRU+O7MquQsfkspgI9 BJfg== X-Gm-Message-State: AOAM531bfdIBIPQwzt2Ml9mOBeUg0SSZoWqy9hh9Ol4GplyeUGmX/+Bz FvwMmACMKzXwBj1ApxIMXbHDhcDmBtHosQ== X-Received: by 2002:a05:6e02:20ed:: with SMTP id q13mr26252658ilv.235.1619706440821; Thu, 29 Apr 2021 07:27:20 -0700 (PDT) Received: from [192.168.1.30] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id p1sm1453223ilp.10.2021.04.29.07.27.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Apr 2021 07:27:20 -0700 (PDT) Subject: Re: [PATCH][next][V2] io_uring: Fix premature return from loop and memory leak To: Colin King , Pavel Begunkov , io-uring@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210429104602.62676-1-colin.king@canonical.com> From: Jens Axboe Message-ID: <8513d853-fd44-c90f-26ba-45b763b8879a@kernel.dk> Date: Thu, 29 Apr 2021 08:27:20 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210429104602.62676-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/29/21 4:46 AM, Colin King wrote: > From: Colin Ian King > > Currently the -EINVAL error return path is leaking memory allocated > to data. Fix this by not returning immediately but instead setting > the error return variable to -EINVAL and breaking out of the loop. > > Kudos to Pavel Begunkov for suggesting a correct fix. Applied, thanks. -- Jens Axboe