Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp1460631pxy; Thu, 29 Apr 2021 07:34:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxaoKa242ubTrufmuE274z7EOM/1FSrg3OWCBHLwBc8MckFJqArtGQqy5/xbzgye1n7Z1tp X-Received: by 2002:a17:906:4004:: with SMTP id v4mr165575ejj.278.1619706876221; Thu, 29 Apr 2021 07:34:36 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1619706876; cv=pass; d=google.com; s=arc-20160816; b=lk7TyoF2vdp8vg3PcJvfv8TeGbT7hASPYS47264Bzrv3RIdhJqhJ0IZ7wESSl8Ms/B p+NifLMZhYTb4M6C+QjEcImceyef0y1NfOpyHXdC7XgiPc7suBEfjhOZDwByNMrGGnKh r4zZV2YCYyjGkBLEEWXrvu1GRkwxpPQl2nL4k5eWWGUNtbColRqZmLA4cjn3qanyvpd9 Rvx6kHcq1BExyUeV7RmJGwiGR5Aak993InvF6/ka3UDXY3Mp6H3NvFwR/zNnz2qoiv/W u3khn1HVWEshqOtYiFPUs+SDWt2U61RpOkSz231H5ZzOPFDg6vG7pLzHXKFNKOMzkZJd yhXw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:in-reply-to:content-disposition :references:message-id:subject:cc:to:from:date:dkim-signature; bh=UEOluUaLyB2byncnXhTMUz+KKHVeash59tIWxkeStUY=; b=yTKrm9keAV2zl3mOk6AkYsFS7TZy/7w07r3NYNAcEgCW0JtJHwcZ7nGFEgZODjDJbW Bw6+rR0ZDMn1SkWT3RH9IyQjScOcUndOEnA0tlzir2/R5umENPQ9PR7vWwpbiieWSxp5 giDZxtRHNBKlHoK2FbOI8XhhFCRWlQQl2NSEgQ2nkBghxTVu+pAzKiMxVOgMwEwNd2IH vuHsxhw4+onZio5HiY6kibNiTqidKtIlszd/LeNAZ5JeKMFf0XYTJ6auK4XoNon/hpOZ h/mVe2UaUnlZRMdYOZtkH8pDOw5pM5B4Axd9D6Ryjx3KIYZ/L2qm02FsazMUCMLVliQp 9IvA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b="IkYZhjC/"; arc=pass (i=1 spf=pass spfdomain=amd.com dkim=pass dkdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amd.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g8si181188ejm.240.2021.04.29.07.34.12; Thu, 29 Apr 2021 07:34:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b="IkYZhjC/"; arc=pass (i=1 spf=pass spfdomain=amd.com dkim=pass dkdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amd.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239049AbhD2Obh (ORCPT + 99 others); Thu, 29 Apr 2021 10:31:37 -0400 Received: from mail-bn7nam10on2076.outbound.protection.outlook.com ([40.107.92.76]:9376 "EHLO NAM10-BN7-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S234473AbhD2Obh (ORCPT ); Thu, 29 Apr 2021 10:31:37 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Rc8XgqIqNOoIqYy1MP3Js36hfynYmKZ60kgT3z3aUtt1pRrz47TXvCw0Y7K04ej9v1oNnyuKvhN0UDl/x+uJxGI09oyzlGFmM5WjG2ouK8RqtDLtz7gwQIMVfAfd4tH7rtdyqj9NXdQfNSBfy5rm8Nx/975Zw4tLlf2H7Q6eBixgkrcpoYdyUu9vx1tm7jFzdROFdWxRHmodAeDgqc8daEeQ8rfgMNZqI0YmZmBwIvkO86xoMqlfh3Xf3q6Wn+8Vr2BkezO62bfnl4fT55fm6xBSyDyl31feNs/Dz52zwEHH7pjPVsYKZqcJCp+12CwWMCqP4bY/AMrhimnZRuo9Og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UEOluUaLyB2byncnXhTMUz+KKHVeash59tIWxkeStUY=; b=JqlsiEKztVRCQTRP8/hqCfBswITF0Yy0njJxXbEGfmzKooOuBwpRYbBKhpZfLSwvnn+tHTqRIXQzo1tenrPoi5rq1pWNkTO12nnuIt7QNfGlVrbMTXFnoHHVoF/6YkU5I+HhGwa3QP0fY2bMw1AyCxy5O57DCxFRYPyAB+ryPBu5qDqHlxDwBMT7EDJQJiSRLphDsI3FbJf+wE4fuhjVhAkvhdxfsO7Fcb+3XgQteW9NOObLFo70ljvh3zJCeMbJA3DL2/2a4QSEHkuU+GIcyYfdjUgnEAicBqoQfs7U+9gw+v8n0bKLgq/8+Ouc6Yw5B7xju59zoqwbeXv+kkdQYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UEOluUaLyB2byncnXhTMUz+KKHVeash59tIWxkeStUY=; b=IkYZhjC/O0U8ALlsxqNJCB1FzOo7XDQA7PEb8qAnNSJUp39h1++jQ+Dx7OT+9zQGNRSGaeft3kJUILVl1l1zQH5xuK91+n7jvR4eTyVLmpD5LYjHY4YIwxl8ReJVXIdfjc40lsywNaS0HBS8iz+/9JmTyd0NgBQZ8rHps33WGBQ= Authentication-Results: vivo.com; dkim=none (message not signed) header.d=none;vivo.com; dmarc=none action=none header.from=amd.com; Received: from DM6PR12MB2601.namprd12.prod.outlook.com (2603:10b6:5:45::27) by DM6PR12MB4250.namprd12.prod.outlook.com (2603:10b6:5:21a::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.26; Thu, 29 Apr 2021 14:30:47 +0000 Received: from DM6PR12MB2601.namprd12.prod.outlook.com ([fe80::3d2c:5edf:5d51:4101]) by DM6PR12MB2601.namprd12.prod.outlook.com ([fe80::3d2c:5edf:5d51:4101%7]) with mapi id 15.20.4065.027; Thu, 29 Apr 2021 14:30:47 +0000 Date: Thu, 29 Apr 2021 10:30:43 -0400 From: Rodrigo Siqueira To: Wan Jiabing Cc: Harry Wentland , Leo Li , Alex Deucher , Christian =?utf-8?B?S8O2bmln?= , David Airlie , Daniel Vetter , Aric Cyr , Qingqing Zhuo , Aurabindo Pillai , Bhawanpreet Lakha , Jacky Liao , Meenakshikumar Somasundaram , Nicholas Kazlauskas , Wenjing Liu , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kael_w@yeah.net Subject: Re: [PATCH] [v2] drm/amd/display: Remove duplicate declaration of dc_state Message-ID: <20210429143043.psmabddm74bljtpx@outlook.office365.com> References: <20210429123900.25156-1-wanjiabing@vivo.com> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="pxa2pngw4xywjlgp" Content-Disposition: inline In-Reply-To: <20210429123900.25156-1-wanjiabing@vivo.com> X-Originating-IP: [2607:fea8:56e0:6d60:9d3b:95a7:19db:40c3] X-ClientProxiedBy: BN0PR03CA0019.namprd03.prod.outlook.com (2603:10b6:408:e6::24) To DM6PR12MB2601.namprd12.prod.outlook.com (2603:10b6:5:45::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from outlook.office365.com (2607:fea8:56e0:6d60:9d3b:95a7:19db:40c3) by BN0PR03CA0019.namprd03.prod.outlook.com (2603:10b6:408:e6::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.27 via Frontend Transport; Thu, 29 Apr 2021 14:30:45 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 71299113-5cee-4ace-8fc2-08d90b1b6144 X-MS-TrafficTypeDiagnostic: DM6PR12MB4250: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:773; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XidyLaVhDyTUhYF6m9eOCJEJ2UZhzvLBAEExVOALR/+ghylDeWAZrwXajNCJsZmK7IYND2/wD3Vb30/vucyRTjhZVXFVj6Or44NqgkYnWdseecaKYBdNjSIeyeP+j9qJqdNRq5RsrAd2VL6mnVduN+VjyU7afhHygAXKBA+qMLhFz0z5obRUj9UAEy/JMOFRPMnLatIvWn+zPIg0p2/tzxMX1ZCQxQo1gxRVvcGH9Hxn8njbWk9BiQbmyMhdWo2QnnchR0okCNPcKRFHrR3tznCjjyJQNyECCeZEz7F9vGsYh/3sjU2YfPNGzCTFfMw5FO5doxwOD6EzfSxQKpnbdACyLDm0xPsvAU4eyYg7Hn3fJWkLDtZraVexyKrqZmzPIPi7kPZvrc3AkoBvFM9EN82WjaWDBVADqrwiORP8HNujdoboi/eU4BmwvmbuaoNtCvaWv4aqAUFeuRoLt9jOLksltig2oVdCl9uCl1v+MdZf6htmgA9Jd5JffXVCeq5Hfd49FN/WCc8R4tJWewHQl8HYzNY25vKSXPRYlJ6tLba5Bk6rDloNXO2QuaSUl6ai1UaIz8AYFFX4RAxROsi0dREbk9P3kxFop0wW/cfoyzHLQzwAE3SrxlXCPm0AasSdfZltgQ3OOWlZxvgmKM66IYK/Cnr9+c9MTdALcVn10R1loowt/Id9ZxetjZJ/q1yC+tCFgz9fq77ICC5mBlg2e+J/7RRfPUUmHZE1V+wOUHY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB2601.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(346002)(136003)(376002)(39860400002)(396003)(21480400003)(6916009)(2906002)(38100700002)(4326008)(66946007)(316002)(66556008)(16526019)(55016002)(9686003)(186003)(54906003)(1076003)(66476007)(8936002)(6506007)(7696005)(86362001)(5660300002)(52116002)(478600001)(966005)(8676002)(83380400001)(44144004)(2700100001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?5YEon8Pab58Jsk+m7XoO3SUGTU49Dg65MWx4oB1C0YKl37SsS3LcA+OQDvYb?= =?us-ascii?Q?apKbwbCBveiw9/rf18EOGr1PpO5d67Tdok5ck9ymQi8oZ2KxmIgsSnfs1P3F?= =?us-ascii?Q?mdhJzXJfwEjDtse3vDPZlikAO85oJeUGtRcb6GlBVPRuskB1Q0sF7udascpR?= =?us-ascii?Q?adp9GEYmi81Jc39vGlbQpp8/DOn2f+wlfeubxu3m4aD+gVvHeTA7vw1yGGfM?= =?us-ascii?Q?U4F650svvu9wfjTRoC+4dytQN5aHqunsRcnwPNMFIsqixn/9YzHio/IgijNG?= =?us-ascii?Q?IV7F0Ihiw1p9K1jcep0qam5r893IWuN0Xh1Amf5MCYm1xOSHVP+pLoy77d7h?= =?us-ascii?Q?SQmGsx+9tIYWvaWNStfwetJsq0i0/ta1x8k1q0d9WHv48rapCS2SE7h3RGce?= =?us-ascii?Q?hFezQnmwMuXR9CfW+qMLWjoirNWhdLC8SNFwC3E7tTkqyXHYn1PmiaI1RBao?= =?us-ascii?Q?KMSVamfYsCDnvLOwe6VZZu9ygQif6rOSfQkQEnWMLCnZcjH9TqgSvZOUAS/x?= =?us-ascii?Q?c1Iufig8EqylSOAMLMo/oeDO1gEaS4KrEVPL6Xcd78n6LQ3dRHQC5CG8jhvd?= =?us-ascii?Q?iGLT8zkbiCaM9kejgy0+hxdJyCraAJ3RM0/KaEL83e75pGOv1gL0e5DR3yiq?= =?us-ascii?Q?FnizYjR1TAsyscmCHoFhDzwRbsucojFu3CH7Vmx4FMVwMIgJoVQGxUCuYCpb?= =?us-ascii?Q?82F5hAYIr+nDtZ5tPp+K6CJ0oIVusPgTICzI/eVaOWXqnLfv2czXPJ4AoyzQ?= =?us-ascii?Q?l5C+Mn7RdxZRGnZaYwOvLzaz7Id82YQTI/2ZzooPTd12hqhGZofxieVXb0qW?= =?us-ascii?Q?rp+eMGgscAp9dXGHOnZZan2o6c4unECR0NyUaqKJmvfF+mBYfraoqpwSJ+PV?= =?us-ascii?Q?euGYJFor1a8zXUWGse3Ud+SnAc7xtxH6aLc0wTbFqAOeh3/qdd9o1xK7+q0c?= =?us-ascii?Q?6LVCrpnRjyBUAc62uAxVfKaGPJxjLlYn1VKu8qF5pK6MjLNVl7sb/VdL874L?= =?us-ascii?Q?+oBftNwCyIQ+1x7qlhj6me+UDe+s2Yo5Ff8DzdeUnsOY2Oyw12Vbuq6thP1A?= =?us-ascii?Q?jU7X64Qkraeqe2zR1yDJef+U5a9v2hb/f51vRXvWR2ujlcu/BjIAZ5iw89oi?= =?us-ascii?Q?yJgO6RHGHDEUGHcujqEfpvserdM9PqzYwRkTthnj7Dz4d9sicOW462UQvPo/?= =?us-ascii?Q?N4Tc2Eo3JgfqOHFidgzpfsT/Frcbcxc0GPygM1BZcgbN/Ds0GIcmSNqj3Pr5?= =?us-ascii?Q?6ttlluC7YBKHYWB12A297dpe6m9/P1xUaYiQ0wVYT+H4fBZUg4kwaeX5B5k6?= =?us-ascii?Q?y3lUwyJIYepwmngTtBVRPnZUKyJLK+VF1PefZngJj4pZzWSyUCSWobx6iSJH?= =?us-ascii?Q?ngqS+Q5ZW4Modmn6bCdqGraTjIBB?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 71299113-5cee-4ace-8fc2-08d90b1b6144 X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2601.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2021 14:30:47.5280 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7k4Jwl/f0Kw4AeiqMY+KwiXPyaw/NVnSx3RAPfm9qa4padety6K4LsfKGGAzhW6b72x4kCbWcVphchtQwkRXzg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4250 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --pxa2pngw4xywjlgp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Reviewed-by: Rodrigo Siqueira On 04/29, Wan Jiabing wrote: > There are two declarations of struct dc_state here. > Remove the later duplicate more secure. >=20 > Signed-off-by: Wan Jiabing > --- > Changelog: > v2: > - Remove the later duplicate instead of the former. > --- > drivers/gpu/drm/amd/display/dc/dc.h | 1 - > 1 file changed, 1 deletion(-) >=20 > diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/di= splay/dc/dc.h > index 8108b82bac60..6f3c95b5d1a2 100644 > --- a/drivers/gpu/drm/amd/display/dc/dc.h > +++ b/drivers/gpu/drm/amd/display/dc/dc.h > @@ -594,7 +594,6 @@ struct dc_bounding_box_overrides { > int min_dcfclk_mhz; > }; > =20 > -struct dc_state; > struct resource_pool; > struct dce_hwseq; > struct gpu_info_soc_bounding_box_v1_0; > --=20 > 2.25.1 >=20 --=20 Rodrigo Siqueira https://siqueira.tech --pxa2pngw4xywjlgp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE4tZ+ii1mjMCMQbfkWJzP/comvP8FAmCKww8ACgkQWJzP/com vP/ggQ/8CfGtjmkV50kOe1v8HJZBnGNKUGy3IqvB4aNVU1FEtg4GqXY66S77Iarx 7gc+QO8d2w5TJe07n+/Wdeho3Vj71OI4zktscX2kyFNrce+OmR4T9sFU+m8aKpCN HQK6PPV0Fec2Qe3JZPOJsvcETHUuL8gPIL+/XQ33uboagvFqYsec5CSNoUmCWqZM TtA2M/yq24WRR4nhbascTuhiS0kBShC28xxXyqZBKHIIKSapBb6DonyAtZYVSgrg rqfCJUdkzgA2jMaZn1nnNySGHV4niFbpPIWmHE5l3PZgSMc+rKHYv8NKYn7wLk6L /spnGzj8WR+U6a1v7RCRlzJoeU65sf6WapJk1nVim9HAUhykcJdeLdM2MN6/mC1N CndJz+xRhIDVfaLGviDb9i72swgTn92pAI6+TFxdO4R0Kg3Jy9pdCuVPD0DbiZRU InKCQl10YhprBfAd9pIo86/Qjn3DGF3Me6o/Czo3/RgOAa4QWaeMVRLJCvLn6wyM wH9j3brJpZY8xYaUBSlUvP6jnrRH0FmIx+301m+A3+0ZSI/gicl//xYjajJGlpbL 6dfpGEnHvRJOiK0wEkJaiDDcndtFji3DzTXyqlLQ5GQOSfJIve/lTQX65hqmRYUT lHcRcQnWtGYn2giQG3fqj+zHON707RNdKhtOhbqeutxryOHRmMM= =+V0s -----END PGP SIGNATURE----- --pxa2pngw4xywjlgp--