Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 4K8whC8pH4pZnsglkeESp/n21+Yb9sWonmFXXi66Z9QmtaPBAfKw5UH5oKdabtpj9hgkRIEqiE
 5eePx1rpReCQ==
IronPort-SDR: 2vVxhEbejwAlySUKZBbM/Mwld9KINWOVFUSrNWwGKtQIUrWfcS8mDGQRHjWmSNl5iXS4+I+qUa
 rJQ25GfKt92g==
Date:   Thu, 29 Apr 2021 11:46:51 -0700
From:   Andi Kleen <ak@linux.intel.com>
To:     Adrian Hunter <adrian.hunter@intel.com>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Jiri Olsa <jolsa@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 05/12] perf inject: Add --vm-time-correlation option
Message-ID: <20210429184651.GD4032392@tassilo.jf.intel.com>
References: <20210429125854.13905-1-adrian.hunter@intel.com>
 <20210429125854.13905-6-adrian.hunter@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210429125854.13905-6-adrian.hunter@intel.com>
Precedence: bulk

On Thu, Apr 29, 2021 at 03:58:47PM +0300, Adrian Hunter wrote:
>  		evsel->handler = drop_sample;
>  }
>  
> +static int parse_vm_time_correlation(const struct option *opt, const char *str, int unset)
> +{
> +	struct perf_inject *inject = opt->value;
> +	const char *args;
> +	char *dry_run;
> +
> +	if (unset)
> +		return 0;
> +
> +	inject->itrace_synth_opts.set = true;
> +	inject->itrace_synth_opts.vm_time_correlation = true;
> +	inject->in_place_update = true;
> +
> +	if (!str)
> +		return 0;
> +
> +	dry_run = strstr(str, "dry-run");

Please use a proper split, otherwise it cannot be extended.

Right now just !strcmp is enough I guess

>